LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Icenowy Zheng <icenowy@aosc.io>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs
Date: Wed, 2 May 2018 00:23:38 +0800	[thread overview]
Message-ID: <CAGb2v66MKooAAroCzYdsXZDY0Oh66Dydpy59xj80QfiY+5mz_A@mail.gmail.com> (raw)
In-Reply-To: <20180430114058.5061-4-jagan@amarulasolutions.com>

On Mon, Apr 30, 2018 at 7:40 PM, Jagan Teki <jagan@amarulasolutions.com> wrote:
> Allwinner 64-bit SoC like H5/A64 has DE2 CCU so enable them
> as default.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/clk/sunxi-ng/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
> index 79dfd296c3d1..1fffd3bf6ff3 100644
> --- a/drivers/clk/sunxi-ng/Kconfig
> +++ b/drivers/clk/sunxi-ng/Kconfig
> @@ -58,6 +58,8 @@ config SUN8I_V3S_CCU
>
>  config SUN8I_DE2_CCU
>         bool "Support for the Allwinner SoCs DE2 CCU"
> +       default ARM64 && ARCH_SUNXI
> +       depends on (DRM_SUN4I && (ARM64 && ARCH_SUNXI)) || COMPILE_TEST

There is no reason to depend on DRM_SUN4I. There is no compile dependency.

Also, this is needed on SUN8I as well, pretty much anything with DE 2.0.
So you shouldn't limit it to ARM64. That pretty much breaks things for
people with A83T's or H3's. In fact you should enable it by default for
these as well.

ChenYu

>
>  config SUN8I_R40_CCU
>         bool "Support for the Allwinner R40 CCU"
> --
> 2.14.3
>

  reply	other threads:[~2018-05-01 16:24 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 11:40 [PATCH 00/21] arm64: allwinner: Add A64 DE2 HDMI support Jagan Teki
2018-04-30 11:40 ` [PATCH 01/21] dt-bindings: clock: Add compatible for A64 DE2 CCU Jagan Teki
2018-05-01 16:16   ` Rob Herring
2018-05-01 16:19     ` Chen-Yu Tsai
2018-05-01 16:34       ` Rob Herring
2018-04-30 11:40 ` [PATCH 02/21] arm64: dts: allwinner: a64: Add " Jagan Teki
2018-05-02 11:32   ` Maxime Ripard
2018-05-02 11:34     ` [linux-sunxi] " Icenowy Zheng
2018-05-02 11:49       ` Maxime Ripard
2018-05-02 11:50       ` Jagan Teki
2018-05-02 11:55         ` Icenowy Zheng
2018-04-30 11:40 ` [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs Jagan Teki
2018-05-01 16:23   ` Chen-Yu Tsai [this message]
2018-05-14  8:20     ` Jagan Teki
2018-05-14 16:43       ` Chen-Yu Tsai
2018-04-30 11:40 ` [PATCH 04/21] bindings: display: Add compatible for A64 DE2 pipeline Jagan Teki
2018-05-01 16:17   ` Rob Herring
2018-05-01 16:31     ` Chen-Yu Tsai
2018-05-01 16:34       ` Rob Herring
2018-04-30 11:40 ` [PATCH 05/21] drm/sun4i: Add support for A64 display engine Jagan Teki
2018-04-30 11:40 ` [PATCH 06/21] arm64: defconfig: Enable CONFIG_DRM_SUN4I Jagan Teki
2018-04-30 11:40 ` [PATCH 07/21] bindings: display: Add compatible for A64 HDMI Jagan Teki
2018-04-30 11:40 ` [PATCH 08/21] bindings: display: Add compatible for A64 HDMI PHY Jagan Teki
2018-05-01 16:19   ` Rob Herring
2018-05-02  6:27     ` Jagan Teki
2018-05-02 12:37       ` Rob Herring
2018-04-30 11:40 ` [PATCH 09/21] arm64: dts: allwinner: a64: Add HDMI support Jagan Teki
2018-05-01 16:20   ` Rob Herring
2018-05-02 11:34   ` Maxime Ripard
2018-05-14  8:33     ` Jagan Teki
2018-05-14  8:40       ` Maxime Ripard
2018-05-14 10:31         ` Jagan Teki
2018-05-15 11:19           ` Maxime Ripard
2018-04-30 11:40 ` [PATCH 10/21] drm/sun4i: Enable DesignWare HDMI for Allwinner 64-bit SoCs Jagan Teki
2018-05-01 16:20   ` Chen-Yu Tsai
2018-04-30 11:40 ` [PATCH 11/21] bindings: display: Add compatible for A64 Mixer1 Jagan Teki
2018-05-01 16:21   ` Rob Herring
2018-04-30 11:40 ` [PATCH 12/21] bindings: display: Add compatible for A64 tcon-tv Jagan Teki
2018-05-01 16:22   ` Rob Herring
2018-04-30 11:40 ` [PATCH 13/21] drm/sun4i: Enable DE2 Mixer for Allwinner 64-bit SoCs Jagan Teki
2018-04-30 11:40 ` [PATCH 14/21] arm64: dts: allwinner: a64: Add HDMI pipeline Jagan Teki
2018-04-30 11:40 ` [PATCH 15/21] drm: sun4i: add support for HVCC regulator for DWC HDMI glue Jagan Teki
2018-05-02 11:48   ` Maxime Ripard
2018-05-02 11:51     ` Icenowy Zheng
2018-04-30 11:40 ` [PATCH 16/21] arm64: dts: allwinner: a64: bananapi-m64: Enable HDMI output Jagan Teki
2018-04-30 11:40 ` [PATCH 17/21] arm64: dts: allwinner: a64: nanopi-a64: " Jagan Teki
2018-04-30 11:40 ` [PATCH 18/21] arm64: dts: allwinner: a64: orangepi-win: " Jagan Teki
2018-04-30 11:40 ` [PATCH 19/21] arm64: dts: allwinner: a64: a64-olinuxino: " Jagan Teki
2018-04-30 11:40 ` [PATCH 20/21] arm64: dts: allwinner: a64: pine64: " Jagan Teki
2018-04-30 11:40 ` [PATCH 21/21] arm64: dts: allwinner: a64: sopine: " Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v66MKooAAroCzYdsXZDY0Oh66Dydpy59xj80QfiY+5mz_A@mail.gmail.com \
    --to=wens@csie.org \
    --cc=airlied@linux.ie \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=icenowy@aosc.io \
    --cc=jagan@amarulasolutions.com \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=michael@amarulasolutions.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=will.deacon@arm.com \
    --subject='Re: [PATCH 03/21] clk: sunxi-ng: Enable DE2_CCU for Allwinner 64-bit SoCs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).