LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH v5 08/12] mfd: axp20x: Add AXP22x regulator information to DT bindings
Date: Mon, 23 Mar 2015 10:43:04 -0700 [thread overview]
Message-ID: <CAGb2v673WWV4q5eEGQF-nhX=Zq=ciD=yXgei-eZjKMWPDxKv4A@mail.gmail.com> (raw)
In-Reply-To: <20150323115425.GC24422@x1>
On Mon, Mar 23, 2015 at 4:54 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 10 Mar 2015, Chen-Yu Tsai wrote:
>
>> Add the list of regulators for AXP22x to the DT bindings.
>> This includes the names and supply names.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>> ---
>> Documentation/devicetree/bindings/mfd/axp20x.txt | 27 ++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
>> index 3914a3f91ff6..0fc2f1f35cef 100644
>> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
>> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
>> @@ -49,6 +49,33 @@ LDO3 : LDO : ldo3in-supply
>> LDO4 : LDO : ldo24in-supply : shared supply
>> LDO5 : LDO : ldo5in-supply
>>
>> +
>
> Nit: I'm not keen on double line spacing.
>
>> +AXP221 regulators, type, and corresponding input supply names:
>> +
>> +Regulator Type Supply Name Notes
>> +--------- ---- ----------- -----
>> +DCDC1 : DC-DC buck : vin1-supply
>> +DCDC2 : DC-DC buck : vin2-supply
>> +DCDC3 : DC-DC buck : vin3-supply
>> +DCDC4 : DC-DC buck : vin4-supply
>> +DCDC5 : DC-DC buck : vin5-supply
>> +DC1SW : On/Off Switch : dcdc1-supply : DCDC1 secondary output
>> +DC5LDO : LDO : dcdc5-supply : input from DCDC5
>> +ALDO1 : LDO : aldoin-supply : shared supply
>> +ALDO2 : LDO : aldoin-supply : shared supply
>> +ALDO3 : LDO : aldoin-supply : shared supply
>> +DLDO1 : LDO : dldoin-supply : shared supply
>> +DLDO2 : LDO : dldoin-supply : shared supply
>> +DLDO3 : LDO : dldoin-supply : shared supply
>> +DLDO4 : LDO : dldoin-supply : shared supply
>> +ELDO1 : LDO : eldoin-supply : shared supply
>> +ELDO2 : LDO : eldoin-supply : shared supply
>> +ELDO3 : LDO : eldoin-supply : shared supply
>> +LDO_IO0 : LDO : ips-supply : GPIO 0
>> +LDO_IO1 : LDO : ips-supply : GPIO 1
>> +RTC_LDO : LDO : ips-supply : always on
>> +
>> +
>
> Nit: I'm not keen on double line spacing.
Ok. I can get rid of them. IMHO it makes different sections clearer though.
I assume you don't want them in the original axp20x patches either?
ChenYu
>> Example:
>>
>> axp209: pmic@34 {
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-03-23 17:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 11:59 [PATCH v5 00/12] mfd: axp20x: add AXP221 PMIC support Chen-Yu Tsai
2015-03-10 11:59 ` [PATCH v5 01/12] ARM: dts: sun6i: add p2wi controller node to dtsi Chen-Yu Tsai
2015-03-10 21:27 ` Maxime Ripard
2015-03-10 11:59 ` [PATCH v5 02/12] ARM: dts: sun6i: hummingbird: Enable P2WI controller Chen-Yu Tsai
2015-03-10 21:27 ` Maxime Ripard
2015-03-10 11:59 ` [PATCH v5 03/12] mfd: axp20x: add AXP22x PMIC support Chen-Yu Tsai
2015-03-23 11:52 ` Lee Jones
2015-03-23 16:58 ` Chen-Yu Tsai
2015-03-10 11:59 ` [PATCH v5 04/12] mfd: axp20x: update DT bindings with AXP22x compatibles Chen-Yu Tsai
2015-03-23 11:53 ` Lee Jones
2015-03-10 11:59 ` [PATCH v5 05/12] ARM: dts: sun6i: hummingbird: Add AXP221 PMIC device node Chen-Yu Tsai
2015-03-10 21:28 ` Maxime Ripard
2015-03-10 11:59 ` [PATCH v5 06/12] regulator: axp20x: prepare support for multiple AXP chip families Chen-Yu Tsai
2015-03-10 20:04 ` Mark Brown
2015-03-10 20:05 ` Mark Brown
2015-03-10 11:59 ` [PATCH v5 07/12] regulator: axp20x: add support for AXP22X regulators Chen-Yu Tsai
2015-03-10 20:04 ` Mark Brown
2015-03-10 20:05 ` Mark Brown
2015-03-10 11:59 ` [PATCH v5 08/12] mfd: axp20x: Add AXP22x regulator information to DT bindings Chen-Yu Tsai
2015-03-23 11:54 ` Lee Jones
2015-03-23 17:43 ` Chen-Yu Tsai [this message]
2015-03-10 11:59 ` [PATCH v5 09/12] mfd: axp20x: Enable AXP22X regulators Chen-Yu Tsai
2015-03-23 11:55 ` Lee Jones
2015-03-10 11:59 ` [PATCH v5 10/12] ARM: dts: sun6i: hummingbird: Add AXP221 regulator nodes Chen-Yu Tsai
2015-03-10 21:30 ` Maxime Ripard
2015-03-10 11:59 ` [PATCH v5 11/12] ARM: dts: sun6i: Add pinmux settings for mmc1 to dtsi Chen-Yu Tsai
2015-03-10 21:31 ` Maxime Ripard
2015-03-10 11:59 ` [PATCH v5 12/12] ARM: dts: sun6i: hummingbird: Add basic support for the WiFi module Chen-Yu Tsai
2015-03-23 22:16 ` Maxime Ripard
2015-03-24 0:24 ` Chen-Yu Tsai
2015-03-10 11:59 ` [PATCH v5 12/12] ARM: dts: sun6i: hummingbird: Enable the onboard " Chen-Yu Tsai
2015-03-10 21:32 ` Maxime Ripard
2015-03-11 3:11 ` Chen-Yu Tsai
2015-03-11 8:52 ` Maxime Ripard
2015-03-11 9:08 ` Chen-Yu Tsai
2015-03-11 14:28 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v673WWV4q5eEGQF-nhX=Zq=ciD=yXgei-eZjKMWPDxKv4A@mail.gmail.com' \
--to=wens@csie.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).