LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations
@ 2015-02-05  7:23 Krzysztof Kozlowski
  2015-02-05  7:23 ` [PATCH v3 2/3] ARM: EXYNOS: Constify exynos_pm_data and of_device_id array Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-02-05  7:23 UTC (permalink / raw)
  To: Russell King, Kukjin Kim, linux-arm-kernel, linux-samsung-soc,
	linux-kernel
  Cc: Pankaj Dubey, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
	Krzysztof Kozlowski

The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs'
and 'exynos5420_release_ret_regs' are not exported nor used outside of
suspend.c file. Make them static.

This fixes following sparse warnings:
arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static?
arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static?
arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static?

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---
Changes since v2:
None

Changes since v1:
1. Add static to 'exynos3250_release_ret_regs' (suggested by Kukjin).
---
 arch/arm/mach-exynos/suspend.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
index 82e6b6fba23f..77cc39bdad47 100644
--- a/arch/arm/mach-exynos/suspend.c
+++ b/arch/arm/mach-exynos/suspend.c
@@ -75,7 +75,7 @@ struct exynos_pm_data {
 	int (*cpu_suspend)(unsigned long);
 };
 
-struct exynos_pm_data *pm_data;
+static struct exynos_pm_data *pm_data;
 
 static int exynos5420_cpu_state;
 static unsigned int exynos_pmu_spare3;
@@ -104,7 +104,7 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
 	{ /* sentinel */ },
 };
 
-unsigned int exynos_release_ret_regs[] = {
+static unsigned int exynos_release_ret_regs[] = {
 	S5P_PAD_RET_MAUDIO_OPTION,
 	S5P_PAD_RET_GPIO_OPTION,
 	S5P_PAD_RET_UART_OPTION,
@@ -115,7 +115,7 @@ unsigned int exynos_release_ret_regs[] = {
 	REG_TABLE_END,
 };
 
-unsigned int exynos3250_release_ret_regs[] = {
+static unsigned int exynos3250_release_ret_regs[] = {
 	S5P_PAD_RET_MAUDIO_OPTION,
 	S5P_PAD_RET_GPIO_OPTION,
 	S5P_PAD_RET_UART_OPTION,
@@ -128,7 +128,7 @@ unsigned int exynos3250_release_ret_regs[] = {
 	REG_TABLE_END,
 };
 
-unsigned int exynos5420_release_ret_regs[] = {
+static unsigned int exynos5420_release_ret_regs[] = {
 	EXYNOS_PAD_RET_DRAM_OPTION,
 	EXYNOS_PAD_RET_MAUDIO_OPTION,
 	EXYNOS_PAD_RET_JTAG_OPTION,
-- 
1.9.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 2/3] ARM: EXYNOS: Constify exynos_pm_data and of_device_id array
  2015-02-05  7:23 [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
@ 2015-02-05  7:23 ` Krzysztof Kozlowski
  2015-02-05  7:23 ` [PATCH v3 3/3] ARM: EXYNOS: Remove left over 'extra_save' Krzysztof Kozlowski
  2015-02-05 11:25 ` [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Pankaj Dubey
  2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-02-05  7:23 UTC (permalink / raw)
  To: Russell King, Kukjin Kim, linux-arm-kernel, linux-samsung-soc,
	linux-kernel
  Cc: Pankaj Dubey, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
	Krzysztof Kozlowski

The 'exynos5420_pm_data' and of_device_id array are not modified and can
be made const.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>

---
Changes since v2:
1. Add Pankaj's reviewed-by.

Changes since v1:
1. New patch.
---
 arch/arm/mach-exynos/suspend.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
index 77cc39bdad47..e6c961126087 100644
--- a/arch/arm/mach-exynos/suspend.c
+++ b/arch/arm/mach-exynos/suspend.c
@@ -572,7 +572,7 @@ static const struct exynos_pm_data exynos5250_pm_data = {
 	.cpu_suspend	= exynos_cpu_suspend,
 };
 
-static struct exynos_pm_data exynos5420_pm_data = {
+static const struct exynos_pm_data exynos5420_pm_data = {
 	.wkup_irq	= exynos5250_wkup_irq,
 	.wake_disable_mask = (0x7F << 7) | (0x1F << 1),
 	.release_ret_regs = exynos5420_release_ret_regs,
@@ -583,7 +583,7 @@ static struct exynos_pm_data exynos5420_pm_data = {
 	.cpu_suspend	= exynos5420_cpu_suspend,
 };
 
-static struct of_device_id exynos_pmu_of_device_ids[] = {
+static const struct of_device_id exynos_pmu_of_device_ids[] = {
 	{
 		.compatible = "samsung,exynos3250-pmu",
 		.data = &exynos3250_pm_data,
-- 
1.9.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 3/3] ARM: EXYNOS: Remove left over 'extra_save'
  2015-02-05  7:23 [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
  2015-02-05  7:23 ` [PATCH v3 2/3] ARM: EXYNOS: Constify exynos_pm_data and of_device_id array Krzysztof Kozlowski
@ 2015-02-05  7:23 ` Krzysztof Kozlowski
  2015-02-05 16:07   ` Pankaj Dubey
  2015-02-05 11:25 ` [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Pankaj Dubey
  2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-02-05  7:23 UTC (permalink / raw)
  To: Russell King, Kukjin Kim, linux-arm-kernel, linux-samsung-soc,
	linux-kernel
  Cc: Pankaj Dubey, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
	Krzysztof Kozlowski

Since 32b0aa9aaeb4 ("ARM: EXYNOS: Remove i2c sys configuration related
code") the Exynos 5250 no longer saves additional registers under
'exynos_pm_data.extra_save' field.

No one else uses this code so get rid of it making also 'exynos_pm_data'
const everywhere.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---
Changes since v2:
2. Remove also 'num_extra_save' field (suggested by Pankaj Dubey).

Changes since v1:
1. New patch.
---
 arch/arm/mach-exynos/suspend.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
index e6c961126087..71e2ba6dbc3d 100644
--- a/arch/arm/mach-exynos/suspend.c
+++ b/arch/arm/mach-exynos/suspend.c
@@ -63,8 +63,6 @@ static struct sleep_save exynos_core_save[] = {
 
 struct exynos_pm_data {
 	const struct exynos_wkup_irq *wkup_irq;
-	struct sleep_save *extra_save;
-	int num_extra_save;
 	unsigned int wake_disable_mask;
 	unsigned int *release_ret_regs;
 
@@ -75,7 +73,7 @@ struct exynos_pm_data {
 	int (*cpu_suspend)(unsigned long);
 };
 
-static struct exynos_pm_data *pm_data;
+static const struct exynos_pm_data *pm_data;
 
 static int exynos5420_cpu_state;
 static unsigned int exynos_pmu_spare3;
@@ -240,10 +238,6 @@ static void exynos_pm_prepare(void)
 
 	s3c_pm_do_save(exynos_core_save, ARRAY_SIZE(exynos_core_save));
 
-	 if (pm_data->extra_save)
-		s3c_pm_do_save(pm_data->extra_save,
-				pm_data->num_extra_save);
-
 	exynos_pm_enter_sleep_mode();
 
 	/* ensure at least INFORM0 has the resume address */
@@ -362,10 +356,6 @@ static void exynos_pm_resume(void)
 	/* For release retention */
 	exynos_pm_release_retention();
 
-	if (pm_data->extra_save)
-		s3c_pm_do_restore_core(pm_data->extra_save,
-					pm_data->num_extra_save);
-
 	s3c_pm_do_restore_core(exynos_core_save, ARRAY_SIZE(exynos_core_save));
 
 	if (cpuid == ARM_CPU_PART_CORTEX_A9)
@@ -618,7 +608,7 @@ void __init exynos_pm_init(void)
 		pr_err("Failed to find PMU node\n");
 		return;
 	}
-	pm_data = (struct exynos_pm_data *) match->data;
+	pm_data = (const struct exynos_pm_data *) match->data;
 
 	/* Platform-specific GIC callback */
 	gic_arch_extn.irq_set_wake = exynos_irq_set_wake;
-- 
1.9.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations
  2015-02-05  7:23 [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
  2015-02-05  7:23 ` [PATCH v3 2/3] ARM: EXYNOS: Constify exynos_pm_data and of_device_id array Krzysztof Kozlowski
  2015-02-05  7:23 ` [PATCH v3 3/3] ARM: EXYNOS: Remove left over 'extra_save' Krzysztof Kozlowski
@ 2015-02-05 11:25 ` Pankaj Dubey
  2 siblings, 0 replies; 5+ messages in thread
From: Pankaj Dubey @ 2015-02-05 11:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Russell King, Kukjin Kim, linux-arm-kernel,
	linux-samsung-soc, linux-kernel
  Cc: Bartlomiej Zolnierkiewicz, Marek Szyprowski, cpgs

Hi Krzysztof,

On Thursday 05 February 2015 12:53 PM, Krzysztof Kozlowski wrote:
> The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs'
> and 'exynos5420_release_ret_regs' are not exported nor used outside of
> suspend.c file. Make them static.
>
> This fixes following sparse warnings:
> arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static?
> arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static?
> arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static?
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>

Thanks,
Pankaj Dubey

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 3/3] ARM: EXYNOS: Remove left over 'extra_save'
  2015-02-05  7:23 ` [PATCH v3 3/3] ARM: EXYNOS: Remove left over 'extra_save' Krzysztof Kozlowski
@ 2015-02-05 16:07   ` Pankaj Dubey
  0 siblings, 0 replies; 5+ messages in thread
From: Pankaj Dubey @ 2015-02-05 16:07 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Russell King, Kukjin Kim, linux-arm-kernel, linux-samsung-soc,
	linux-kernel, Marek Szyprowski, Bartlomiej Zolnierkiewicz

Hi Krzysztof

On 5 February 2015 at 12:53, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
>
> Since 32b0aa9aaeb4 ("ARM: EXYNOS: Remove i2c sys configuration related
> code") the Exynos 5250 no longer saves additional registers under
> 'exynos_pm_data.extra_save' field.
>
> No one else uses this code so get rid of it making also 'exynos_pm_data'
> const everywhere.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>

Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>

Thanks,
Pankaj Dubey

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-02-05 16:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05  7:23 [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
2015-02-05  7:23 ` [PATCH v3 2/3] ARM: EXYNOS: Constify exynos_pm_data and of_device_id array Krzysztof Kozlowski
2015-02-05  7:23 ` [PATCH v3 3/3] ARM: EXYNOS: Remove left over 'extra_save' Krzysztof Kozlowski
2015-02-05 16:07   ` Pankaj Dubey
2015-02-05 11:25 ` [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Pankaj Dubey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).