LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Azael Avalos <coproscefalo@gmail.com>
To: Darren Hart <dvhart@infradead.org>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Azael Avalos <coproscefalo@gmail.com>
Subject: Re: [PATCH] toshiba_acpi: Add a check for TOS_NOT_SUPPORTED in the sci_open function
Date: Mon, 26 Jan 2015 19:52:43 -0700	[thread overview]
Message-ID: <CAGdLNWFc5wwwcDzp+Htg4Uuqsp9GQvXuX2g-ZdqeZabw_2WyoQ@mail.gmail.com> (raw)
In-Reply-To: <1421633832-28490-1-git-send-email-coproscefalo@gmail.com>

Hi Darren,

Any input on this patch?

2015-01-18 19:17 GMT-07:00 Azael Avalos <coproscefalo@gmail.com>:
> This was "toshiba_acpi: Change sci_open function return value"
>
> Some Toshiba laptops have "poorly implemented" SCI calls on their
> BIOSes and are not checking for sci_{open, close} calls, therefore,
> the sci_open function is failing and making some of the supported
> features unavailable (kbd backlight, touchpad, illumination, etc.).
>
> This patch checks wheter we receive TOS_NOT_SUPPORTED and returns
> 1, making the supported features work on such laptops.
>
> In the case that some laptops really do not support the SCI, all the
> SCI dependent functions check for TOS_NOT_SUPPORTED, and thus, not
> registering support for the queried feature.
>
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
> Darren,
>
> Hopefully this new patch eases some of the concerns of the previous
> patch, and this time I added a comment block explaining a bit, but of
> course, let me know if there is something else that needs change.
>
> Cheers
> Azael
>
>  drivers/platform/x86/toshiba_acpi.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index fc34a71..899ead6b 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -389,6 +389,19 @@ static int sci_open(struct toshiba_acpi_dev *dev)
>         } else if (out[0] == TOS_ALREADY_OPEN) {
>                 pr_info("Toshiba SCI already opened\n");
>                 return 1;
> +       } else if (out[0] == TOS_NOT_SUPPORTED) {
> +               /* Some BIOSes do not have the SCI open/close functions
> +                * implemented and return 0x8000 (Not Supported), failing to
> +                * register some supported features.
> +                *
> +                * Simply return 1 if we hit those affected laptops to make the
> +                * supported features work.
> +                *
> +                * In the case that some laptops really do not support the SCI,
> +                * all the SCI dependent functions check for TOS_NOT_SUPPORTED,
> +                * and thus, not registering support for the queried feature.
> +                */
> +               return 1;
>         } else if (out[0] == TOS_NOT_PRESENT) {
>                 pr_info("Toshiba SCI is not present\n");
>         }
> --
> 2.2.1
>



-- 
-- El mundo apesta y vosotros apestais tambien --

  reply	other threads:[~2015-01-27  2:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19  2:17 Azael Avalos
2015-01-27  2:52 ` Azael Avalos [this message]
2015-01-29  6:19 ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGdLNWFc5wwwcDzp+Htg4Uuqsp9GQvXuX2g-ZdqeZabw_2WyoQ@mail.gmail.com \
    --to=coproscefalo@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --subject='Re: [PATCH] toshiba_acpi: Add a check for TOS_NOT_SUPPORTED in the sci_open function' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).