LKML Archive on
help / color / mirror / Atom feed
From: Sven Van Asbroeck <>
To: Greg KH <>
Cc: Dan Carpenter <>,,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH] staging: fieldbus: anybuss: force address space conversion
Date: Tue, 21 May 2019 11:53:15 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, May 21, 2019 at 11:42 AM Greg KH <> wrote:
> Ick, if you are using __force, almost always something is wrong.

What if I create a separate structure for the regmap context ?

struct anybus_regmap_context {
        void __iomem *base;

Then just store the base pointer inside the struct, and pass the struct
as the regmap context:

ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
ctx->base = base;
devm_regmap_init(..., ctx);

static int write_reg_bus(void *context, unsigned int reg,
                  unsigned int val)
        struct anybus_regmap_context *ctx = context;
        <now access ctx->base>

Penalty is an additional dynamic pointer-size
allocation. Pro: it'll be formally correct ?

  reply	other threads:[~2019-05-21 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 14:51 Sven Van Asbroeck
2019-05-21 15:10 ` Dan Carpenter
2019-05-21 15:19   ` Sven Van Asbroeck
2019-05-21 15:42     ` Greg KH
2019-05-21 15:53       ` Sven Van Asbroeck [this message]
2019-05-21 16:24         ` Greg KH
2019-05-21 16:53           ` Sven Van Asbroeck
2019-05-21 17:06             ` Sven Van Asbroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \
    --subject='Re: [PATCH] staging: fieldbus: anybuss: force address space conversion' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).