LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sean Wang <sean.wang@kernel.org>
To: manivannan.sadhasivam@linaro.org
Cc: "Sean Wang (王志亘)" <sean.wang@mediatek.com>,
	linus.walleij@linaro.org, matthias.bgg@gmail.com,
	robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	amit.kucheria@linaro.org, linux-gpio@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] arm64: dts: mediatek: mt6797: Add pinctrl support
Date: Thu, 18 Oct 2018 22:24:25 +0800	[thread overview]
Message-ID: <CAGp9LzqKEpmJMZhU0KW2GWXT4mxEiMqA0xhGxeX2kv+7_ADtKw@mail.gmail.com> (raw)
In-Reply-To: <20181008191411.32555-3-manivannan.sadhasivam@linaro.org>

On Tue, Oct 9, 2018 at 3:16 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> Add pinctrl support for Mediatek MT6797 SoC.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  arch/arm64/boot/dts/mediatek/mt6797.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6797.dtsi b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> index 4beaa71107d7..231230d32d09 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6797.dtsi
> @@ -14,6 +14,7 @@
>  #include <dt-bindings/clock/mt6797-clk.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/pinctrl/mt6797-pinfunc.h>
>
>  / {
>         compatible = "mediatek,mt6797";
> @@ -129,6 +130,19 @@
>                 #clock-cells = <1>;
>         };
>
> +       pio: pinctrl@10005000 {
> +               compatible = "mediatek,mt6797-pinctrl";
> +               reg = <0 0x10005000 0 0x1000>,
> +                     <0 0x10002000 0 0x400>,
> +                     <0 0x10002400 0 0x400>,
> +                     <0 0x10002800 0 0x400>,
> +                     <0 0x10002C00 0 0x400>;
> +               reg-names = "gpio", "iocfgl", "iocfgb",
> +                           "iocfgr", "iocfgt";
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +       };
> +

The content looks good to me, but the dt-binding document is required
to be added for MT6797 SoC before the DTS instance is being added.

>         scpsys: scpsys@10006000 {
>                 compatible = "mediatek,mt6797-scpsys";
>                 #power-domain-cells = <1>;
> --
> 2.17.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2018-10-18 14:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 19:14 [PATCH 0/5] Add initial pinctrl support for MT6797 SoC Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 1/5] dt-bindings: pinctrl: Add devicetree constants " Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 2/5] arm64: dts: mediatek: mt6797: Add pinctrl support Manivannan Sadhasivam
2018-10-18 14:24   ` Sean Wang [this message]
     [not found]   ` <CAGp9LzoSA=06CF_yNMOHnfmRnFzpBA4R2YGhbWmxdSKci2uF0w@mail.gmail.com>
2018-10-19  8:27     ` Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 3/5] arm64: dts: mediatek: x20: Add pinmux support for UART1 Manivannan Sadhasivam
2018-10-08 19:14 ` [PATCH 4/5] pinctrl: mediatek: pinctrl-mtk-common-v2: Make eint_m u16 Manivannan Sadhasivam
2018-10-11  9:29   ` Matthias Brugger
2018-10-15 14:18   ` Linus Walleij
2018-10-08 19:14 ` [PATCH 5/5] pinctrl: mediatek: Add initial pinctrl driver for MT6797 SoC Manivannan Sadhasivam
2018-10-11  9:30   ` Matthias Brugger
2018-10-11 15:50   ` Matthias Brugger
2018-10-11 16:44     ` Manivannan Sadhasivam
2018-10-16 13:58       ` Matthias Brugger
2018-10-18 15:06         ` Sean Wang
2018-10-30 12:51           ` Linus Walleij
2018-10-30 23:45             ` Sean Wang
2018-10-16  8:36 ` [PATCH 0/5] Add initial pinctrl support " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGp9LzqKEpmJMZhU0KW2GWXT4mxEiMqA0xhGxeX2kv+7_ADtKw@mail.gmail.com \
    --to=sean.wang@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    --subject='Re: [PATCH 2/5] arm64: dts: mediatek: mt6797: Add pinctrl support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).