LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Frans Klaver <fransklaver@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 30/60] mtd: nand: fsl_elbc_nand: show device in sysfs
Date: Tue, 10 Mar 2015 08:42:43 +0100	[thread overview]
Message-ID: <CAH6sp9OOVNev47i_3zXQ8Oznj-TVPgA-+E93Uok=acCnnMzTuA@mail.gmail.com> (raw)
In-Reply-To: <20150310062852.GA4124@norris-Latitude-E6410>

On Tue, Mar 10, 2015 at 7:28 AM, Brian Norris
<computersforpeace@gmail.com> wrote:
> On Tue, Mar 03, 2015 at 10:40:14PM +0100, Frans Klaver wrote:
>> Fix a bug where devices aren't shown in sysfs.
>>
>> While at it, make use of the default owner value set by mtdcore.
>>
>> Signed-off-by: Frans Klaver <fransklaver@gmail.com>
>> ---
>>  drivers/mtd/nand/fsl_elbc_nand.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
>> index 04b22fd..0cd94a1 100644
>> --- a/drivers/mtd/nand/fsl_elbc_nand.c
>> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
>> @@ -747,7 +747,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv)
>>
>>       /* Fill in fsl_elbc_mtd structure */
>>       priv->mtd.priv = chip;
>> -     priv->mtd.owner = THIS_MODULE;
>> +     priv->mtd.dev.parent = &chip->dev;
>
> drivers/mtd/nand/fsl_elbc_nand.c: In function 'fsl_elbc_chip_init':
> drivers/mtd/nand/fsl_elbc_nand.c:750:30: error: 'struct nand_chip' has no member named 'dev'
> make[4]: *** [drivers/mtd/nand/fsl_elbc_nand.o] Error 1

Thanks for building this. I thought this might happen even though I
spent quite some time trying to prevent it. This should probably have
been

+ priv->mtd.dev.parent = priv->dev;

Off to go find out what other configs & targets to build for.

Thanks,
Frans

  reply	other threads:[~2015-03-10  7:42 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 21:39 [PATCH 00/60] Fix mtds not showing up " Frans Klaver
2015-03-03 21:39 ` [PATCH 01/60] mtd: core: tone down suggestion that dev.parent should be set Frans Klaver
2015-03-09 23:14   ` Brian Norris
2015-03-10  7:47     ` Frans Klaver
2015-03-10 17:39       ` Brian Norris
2015-03-11  8:03         ` Frans Klaver
2015-04-10  4:30           ` Brian Norris
2015-04-10  5:31             ` Frans Klaver
2015-03-03 21:39 ` [PATCH 02/60] mtd: core: set some defaults when dev.parent is set Frans Klaver
2015-05-08 10:01   ` Frans Klaver
2015-03-03 21:39 ` [PATCH 03/60] mtd: devices: bcm47xxflash: show device in sysfs Frans Klaver
2015-03-03 21:39 ` [PATCH 04/60] mtd: devices: docg3: " Frans Klaver
2015-03-03 21:39 ` [PATCH 05/60] mtd: devices: m25p80: " Frans Klaver
2015-03-03 21:39 ` [PATCH 06/60] mtd: devices: mtd_dataflash: drop owner assignment Frans Klaver
2015-03-03 21:39 ` [PATCH 07/60] mtd: devices: spear_smi: show device in sysfs Frans Klaver
2015-03-03 21:39 ` [PATCH 08/60] mtd: devices: sst251: " Frans Klaver
2015-03-03 21:39 ` [PATCH 09/60] mtd: lpddr: " Frans Klaver
2015-03-03 21:39 ` [PATCH 10/60] mtd: maps: bfin-async-flash: " Frans Klaver
2015-03-03 21:39 ` [PATCH 11/60] mtd: maps: gpio-addr-flash: " Frans Klaver
2015-03-03 21:39 ` [PATCH 12/60] mtd: maps: intel_vr_nor: " Frans Klaver
2015-03-03 21:39 ` [PATCH 13/60] mtd: maps: ixp4xx: " Frans Klaver
2015-03-03 21:39 ` [PATCH 14/60] mtd: maps: lantiq-flash: " Frans Klaver
2015-03-03 21:39 ` [PATCH 15/60] mtd: maps: latch-addr-flash: " Frans Klaver
2015-03-03 21:40 ` [PATCH 16/60] mtd: maps: physmap: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 17/60] mtd: maps: physmap_of: " Frans Klaver
2015-03-03 21:40 ` [PATCH 18/60] mtd: maps: plat_ram: " Frans Klaver
2015-03-03 21:40 ` [PATCH 19/60] mtd: maps: pxa2xx-flash: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 20/60] mtd: maps: rbtx4939-flash: " Frans Klaver
2015-03-03 21:40 ` [PATCH 21/60] mtd: maps: sa1100-flash: " Frans Klaver
2015-03-03 21:40 ` [PATCH 22/60] mtd: nand: atmel_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 23/60] mtd: nand: au1550nd: " Frans Klaver
2015-03-03 21:40 ` [PATCH 24/60] mtd: nand: bcm47xxnflash: " Frans Klaver
2015-03-03 21:40 ` [PATCH 25/60] mtd: nand: bf5xx_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 26/60] mtd: nand: cafe_nand: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 27/60] mtd: nand: davinci_nand: drop owner and name assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 28/60] mtd: nand: denali: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 29/60] mtd: nand: docg4: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 30/60] mtd: nand: fsl_elbc_nand: " Frans Klaver
2015-03-10  6:28   ` Brian Norris
2015-03-10  7:42     ` Frans Klaver [this message]
2015-03-03 21:40 ` [PATCH 31/60] mtd: nand: fsl_ifc_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 32/60] mtd: nand: fsl_upm: " Frans Klaver
2015-03-03 21:40 ` [PATCH 33/60] mtd: nand: fsmc_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 34/60] mtd: nand: gpio: " Frans Klaver
2015-03-03 21:40 ` [PATCH 35/60] mtd: nand: gpmi-nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 36/60] mtd: nand: hisi504_nand: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 37/60] mtd: nand: jz4740_nand: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 38/60] mtd: nand: lpc32xx_mlc: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 39/60] mtd: nand: mpc5121_nfc: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 40/60] mtd: nand: mxc_nand: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 41/60] mtd: nand: ndfc: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 42/60] mtd: nand: nuc900_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 43/60] mtd: nand: omap2: show device structure " Frans Klaver
2015-03-03 21:40 ` [PATCH 44/60] mtd: nand: orion_nand: show device " Frans Klaver
2015-03-03 21:40 ` [PATCH 45/60] mtd: nand: pasemi_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 46/60] mtd: nand: plat_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 47/60] mtd: nand: pxa3xx_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 48/60] mtd: nand: r852: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 49/60] mtd: nand: s3c2410: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 50/60] mtd: nand: sh_flctl: " Frans Klaver
2015-03-03 21:40 ` [PATCH 51/60] mtd: nand: sharpsl: " Frans Klaver
2015-03-03 21:40 ` [PATCH 52/60] mtd: nand: socrates_nand: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 53/60] mtd: nand: sunxi_nand: " Frans Klaver
2015-03-03 21:40 ` [PATCH 54/60] mtd: nand: tmio_nand: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 55/60] mtd: nand: txx9ndfmc: " Frans Klaver
2015-03-03 21:40 ` [PATCH 56/60] mtd: onenand: generic: " Frans Klaver
2015-03-03 21:40 ` [PATCH 57/60] mtd: onenand: omap2: drop owner and name assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 58/60] mtd: onenand: samsung: drop owner assignment Frans Klaver
2015-03-03 21:40 ` [PATCH 59/60] mtd: spi-nor: fsl-quadspi: show device in sysfs Frans Klaver
2015-03-03 21:40 ` [PATCH 60/60] staging: mt29f_spinand: " Frans Klaver
2015-03-06 23:59   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH6sp9OOVNev47i_3zXQ8Oznj-TVPgA-+E93Uok=acCnnMzTuA@mail.gmail.com' \
    --to=fransklaver@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --subject='Re: [PATCH 30/60] mtd: nand: fsl_elbc_nand: show device in sysfs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).