From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbbCJHmq (ORCPT ); Tue, 10 Mar 2015 03:42:46 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:43257 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbbCJHmo (ORCPT ); Tue, 10 Mar 2015 03:42:44 -0400 MIME-Version: 1.0 In-Reply-To: <20150310062852.GA4124@norris-Latitude-E6410> References: <1425418844-25177-1-git-send-email-fransklaver@gmail.com> <1425418844-25177-31-git-send-email-fransklaver@gmail.com> <20150310062852.GA4124@norris-Latitude-E6410> Date: Tue, 10 Mar 2015 08:42:43 +0100 Message-ID: Subject: Re: [PATCH 30/60] mtd: nand: fsl_elbc_nand: show device in sysfs From: Frans Klaver To: Brian Norris Cc: David Woodhouse , "linux-kernel@vger.kernel.org" , linux-mtd@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 7:28 AM, Brian Norris wrote: > On Tue, Mar 03, 2015 at 10:40:14PM +0100, Frans Klaver wrote: >> Fix a bug where devices aren't shown in sysfs. >> >> While at it, make use of the default owner value set by mtdcore. >> >> Signed-off-by: Frans Klaver >> --- >> drivers/mtd/nand/fsl_elbc_nand.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c >> index 04b22fd..0cd94a1 100644 >> --- a/drivers/mtd/nand/fsl_elbc_nand.c >> +++ b/drivers/mtd/nand/fsl_elbc_nand.c >> @@ -747,7 +747,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv) >> >> /* Fill in fsl_elbc_mtd structure */ >> priv->mtd.priv = chip; >> - priv->mtd.owner = THIS_MODULE; >> + priv->mtd.dev.parent = &chip->dev; > > drivers/mtd/nand/fsl_elbc_nand.c: In function 'fsl_elbc_chip_init': > drivers/mtd/nand/fsl_elbc_nand.c:750:30: error: 'struct nand_chip' has no member named 'dev' > make[4]: *** [drivers/mtd/nand/fsl_elbc_nand.o] Error 1 Thanks for building this. I thought this might happen even though I spent quite some time trying to prevent it. This should probably have been + priv->mtd.dev.parent = priv->dev; Off to go find out what other configs & targets to build for. Thanks, Frans