LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* linux-next: Fixes tag needs some work in the risc-v-fixes tree
@ 2020-03-19  8:06 Stephen Rothwell
  2020-03-19 10:04 ` Greentime Hu
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-03-19  8:06 UTC (permalink / raw)
  To: Palmer Dabbelt, Paul Walmsley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Greentime Hu

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

In commit

  3384b043ea15 ("riscv: fix the IPI missing issue in nommu mode")

Fixes tag

  Fixes: b2d36b5668f6 ("riscv: provide native clint access for M-mode")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: fcdc65375186 ("riscv: provide native clint access for M-mode")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Fixes tag needs some work in the risc-v-fixes tree
  2020-03-19  8:06 linux-next: Fixes tag needs some work in the risc-v-fixes tree Stephen Rothwell
@ 2020-03-19 10:04 ` Greentime Hu
  0 siblings, 0 replies; 4+ messages in thread
From: Greentime Hu @ 2020-03-19 10:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Palmer Dabbelt, Paul Walmsley, Linux Next Mailing List,
	Linux Kernel Mailing List

Stephen Rothwell <sfr@canb.auug.org.au> 於 2020年3月19日 週四 下午4:06寫道:
>
> Hi all,
>
> In commit
>
>   3384b043ea15 ("riscv: fix the IPI missing issue in nommu mode")
>
> Fixes tag
>
>   Fixes: b2d36b5668f6 ("riscv: provide native clint access for M-mode")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: fcdc65375186 ("riscv: provide native clint access for M-mode")
>

Sorry. That's my bad.
Yes, I meant Fixes: fcdc65375186 ("riscv: provide native clint access
for M-mode")

^ permalink raw reply	[flat|nested] 4+ messages in thread

* linux-next: Fixes tag needs some work in the risc-v-fixes tree
@ 2022-04-25 22:01 Stephen Rothwell
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2022-04-25 22:01 UTC (permalink / raw)
  To: Palmer Dabbelt, Paul Walmsley
  Cc: Arnaud Pouliquen, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi all,

In commit

  760d10a5b792 ("RISC-V: configs: Configs that had RPMSG_CHAR now get RPMSG_CTRL")

Fixes tag

  Fixes: 617d32938d1b ("rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl", 2022-01-24)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Please do not add the date field, it doesn't add anything.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* linux-next: Fixes tag needs some work in the risc-v-fixes tree
@ 2020-09-30 12:41 Stephen Rothwell
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2020-09-30 12:41 UTC (permalink / raw)
  To: Palmer Dabbelt, Paul Walmsley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Anup Patel

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi all,

In commit

  1e555ccc72e0 ("RISC-V: Check clint_time_val before use")

Fixes tag

  Fixes: d5be89a8d118 ("RISC-V: Resurrect the MMIO timer implementation

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not break Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-25 22:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19  8:06 linux-next: Fixes tag needs some work in the risc-v-fixes tree Stephen Rothwell
2020-03-19 10:04 ` Greentime Hu
2020-09-30 12:41 Stephen Rothwell
2022-04-25 22:01 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).