LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	linux-media@vger.kernel.org,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-gpio@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;
Date: Wed, 11 Mar 2020 10:53:03 +0530	[thread overview]
Message-ID: <CAHLCerPFWFoUpt6Soc1awDiCy6aBn=qTbQ8G5vjhmX-g2=8znA@mail.gmail.com> (raw)
In-Reply-To: <2e6818291503f032e7662f1fa45fb64c7751a7ae.1583896348.git.joe@perches.com>

On Wed, Mar 11, 2020 at 10:37 AM Joe Perches <joe@perches.com> wrote:
>
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/


Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/media/platform/qcom/venus/vdec.c |  2 +-
>  drivers/phy/qualcomm/phy-qcom-usb-hs.c   |  2 +-
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c |  4 ++--
>  drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c |  2 +-
>  drivers/rpmsg/qcom_glink_native.c        |  4 ++--
>  drivers/soc/qcom/socinfo.c               | 16 ++++++++--------
>  drivers/thermal/qcom/tsens-v0_1.c        |  8 ++++----
>  drivers/thermal/qcom/tsens-v1.c          |  4 ++--
>  8 files changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index f34920..9e0451 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -983,7 +983,7 @@ static int vdec_stop_capture(struct venus_inst *inst)
>         switch (inst->codec_state) {
>         case VENUS_DEC_STATE_DECODING:
>                 ret = hfi_session_flush(inst, HFI_FLUSH_ALL);
> -               /* fallthrough */
> +               fallthrough;
>         case VENUS_DEC_STATE_DRAIN:
>                 vdec_cancel_dst_buffers(inst);
>                 inst->codec_state = VENUS_DEC_STATE_STOPPED;
> diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hs.c b/drivers/phy/qualcomm/phy-qcom-usb-hs.c
> index 610542..327df1a 100644
> --- a/drivers/phy/qualcomm/phy-qcom-usb-hs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-usb-hs.c
> @@ -53,7 +53,7 @@ static int qcom_usb_hs_phy_set_mode(struct phy *phy,
>                 case PHY_MODE_USB_OTG:
>                 case PHY_MODE_USB_HOST:
>                         val |= ULPI_INT_IDGRD;
> -                       /* fall through */
> +                       fallthrough;
>                 case PHY_MODE_USB_DEVICE:
>                         val |= ULPI_INT_SESS_VALID;
>                 default:
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index fe0be8..3b0ab0e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -793,13 +793,13 @@ static int pmic_gpio_populate(struct pmic_gpio_state *state,
>         switch (subtype) {
>         case PMIC_GPIO_SUBTYPE_GPIO_4CH:
>                 pad->have_buffer = true;
> -               /* Fall through */
> +               fallthrough;
>         case PMIC_GPIO_SUBTYPE_GPIOC_4CH:
>                 pad->num_sources = 4;
>                 break;
>         case PMIC_GPIO_SUBTYPE_GPIO_8CH:
>                 pad->have_buffer = true;
> -               /* Fall through */
> +               fallthrough;
>         case PMIC_GPIO_SUBTYPE_GPIOC_8CH:
>                 pad->num_sources = 8;
>                 break;
> diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> index 338a15..b5949f7 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> @@ -346,7 +346,7 @@ static int pm8xxx_pin_config_set(struct pinctrl_dev *pctldev,
>                                 return -EINVAL;
>                         }
>                         pin->pull_up_strength = arg;
> -                       /* FALLTHROUGH */
> +                       fallthrough;
>                 case PIN_CONFIG_BIAS_PULL_UP:
>                         pin->bias = pin->pull_up_strength;
>                         banks |= BIT(2);
> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
> index 1995f5b..f40312 100644
> --- a/drivers/rpmsg/qcom_glink_native.c
> +++ b/drivers/rpmsg/qcom_glink_native.c
> @@ -553,7 +553,7 @@ static void qcom_glink_receive_version(struct qcom_glink *glink,
>                 break;
>         case GLINK_VERSION_1:
>                 glink->features &= features;
> -               /* FALLTHROUGH */
> +               fallthrough;
>         default:
>                 qcom_glink_send_version_ack(glink);
>                 break;
> @@ -584,7 +584,7 @@ static void qcom_glink_receive_version_ack(struct qcom_glink *glink,
>                         break;
>
>                 glink->features &= features;
> -               /* FALLTHROUGH */
> +               fallthrough;
>         default:
>                 qcom_glink_send_version(glink);
>                 break;
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 7864b7..8ae5646 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -325,7 +325,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>                 debugfs_create_x32("raw_device_number", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.raw_device_num);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 11):
>         case SOCINFO_VERSION(0, 10):
>         case SOCINFO_VERSION(0, 9):
> @@ -333,12 +333,12 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>
>                 debugfs_create_u32("foundry_id", 0400, qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.foundry_id);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 8):
>         case SOCINFO_VERSION(0, 7):
>                 DEBUGFS_ADD(info, pmic_model);
>                 DEBUGFS_ADD(info, pmic_die_rev);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 6):
>                 qcom_socinfo->info.hw_plat_subtype =
>                         __le32_to_cpu(info->hw_plat_subtype);
> @@ -346,7 +346,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>                 debugfs_create_u32("hardware_platform_subtype", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.hw_plat_subtype);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 5):
>                 qcom_socinfo->info.accessory_chip =
>                         __le32_to_cpu(info->accessory_chip);
> @@ -354,27 +354,27 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>                 debugfs_create_u32("accessory_chip", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.accessory_chip);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 4):
>                 qcom_socinfo->info.plat_ver = __le32_to_cpu(info->plat_ver);
>
>                 debugfs_create_u32("platform_version", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.plat_ver);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 3):
>                 qcom_socinfo->info.hw_plat = __le32_to_cpu(info->hw_plat);
>
>                 debugfs_create_u32("hardware_platform", 0400,
>                                    qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.hw_plat);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 2):
>                 qcom_socinfo->info.raw_ver  = __le32_to_cpu(info->raw_ver);
>
>                 debugfs_create_u32("raw_version", 0400, qcom_socinfo->dbg_root,
>                                    &qcom_socinfo->info.raw_ver);
> -               /* Fall through */
> +               fallthrough;
>         case SOCINFO_VERSION(0, 1):
>                 DEBUGFS_ADD(info, build_id);
>                 break;
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index 4b8dd6..893ce1 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -163,7 +163,7 @@ static int calibrate_8916(struct tsens_priv *priv)
>                 p2[4] = (qfprom_cdata[1] & MSM8916_S4_P2_MASK) >> MSM8916_S4_P2_SHIFT;
>                 for (i = 0; i < priv->num_sensors; i++)
>                         p2[i] = ((base1 + p2[i]) << 3);
> -               /* Fall through */
> +               fallthrough;
>         case ONE_PT_CALIB2:
>                 base0 = (qfprom_cdata[0] & MSM8916_BASE0_MASK);
>                 p1[0] = (qfprom_cdata[0] & MSM8916_S0_P1_MASK) >> MSM8916_S0_P1_SHIFT;
> @@ -228,7 +228,7 @@ static int calibrate_8974(struct tsens_priv *priv)
>                         p2[8] = (calib[5] & S8_P2_BKP_MASK) >> S8_P2_BKP_SHIFT;
>                         p2[9] = (calib[5] & S9_P2_BKP_MASK) >> S9_P2_BKP_SHIFT;
>                         p2[10] = (calib[5] & S10_P2_BKP_MASK) >> S10_P2_BKP_SHIFT;
> -                       /* Fall through */
> +                       fallthrough;
>                 case ONE_PT_CALIB:
>                 case ONE_PT_CALIB2:
>                         base1 = bkp[0] & BASE1_MASK;
> @@ -263,7 +263,7 @@ static int calibrate_8974(struct tsens_priv *priv)
>                         p2[8] = (calib[4] & S8_P2_MASK) >> S8_P2_SHIFT;
>                         p2[9] = (calib[4] & S9_P2_MASK) >> S9_P2_SHIFT;
>                         p2[10] = (calib[4] & S10_P2_MASK) >> S10_P2_SHIFT;
> -                       /* Fall through */
> +                       fallthrough;
>                 case ONE_PT_CALIB:
>                 case ONE_PT_CALIB2:
>                         base1 = calib[0] & BASE1_MASK;
> @@ -293,7 +293,7 @@ static int calibrate_8974(struct tsens_priv *priv)
>                         p2[i] <<= 2;
>                         p2[i] |= BIT_APPEND;
>                 }
> -               /* Fall through */
> +               fallthrough;
>         case ONE_PT_CALIB2:
>                 for (i = 0; i < priv->num_sensors; i++) {
>                         p1[i] += base1;
> diff --git a/drivers/thermal/qcom/tsens-v1.c b/drivers/thermal/qcom/tsens-v1.c
> index bd2ddb..d096d3 100644
> --- a/drivers/thermal/qcom/tsens-v1.c
> +++ b/drivers/thermal/qcom/tsens-v1.c
> @@ -202,7 +202,7 @@ static int calibrate_v1(struct tsens_priv *priv)
>                 p2[9] = (qfprom_cdata[3] & S9_P2_MASK) >> S9_P2_SHIFT;
>                 for (i = 0; i < priv->num_sensors; i++)
>                         p2[i] = ((base1 + p2[i]) << 2);
> -               /* Fall through */
> +               fallthrough;
>         case ONE_PT_CALIB2:
>                 base0 = (qfprom_cdata[4] & BASE0_MASK) >> BASE0_SHIFT;
>                 p1[0] = (qfprom_cdata[0] & S0_P1_MASK) >> S0_P1_SHIFT;
> @@ -263,7 +263,7 @@ static int calibrate_8976(struct tsens_priv *priv)
>
>                 for (i = 0; i < priv->num_sensors; i++)
>                         p2[i] = ((base1 + p2[i]) << 2);
> -               /* Fall through */
> +               fallthrough;
>         case ONE_PT_CALIB2:
>                 base0 = qfprom_cdata[0] & MSM8976_BASE0_MASK;
>                 p1[0] = (qfprom_cdata[0] & MSM8976_S0_P1_MASK) >> MSM8976_S0_P1_SHIFT;
> --
> 2.24.0
>

  reply	other threads:[~2020-03-11  5:23 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 17:24 [PATCH -next 000/491] treewide: use fallthrough; Joe Perches
2020-03-11  4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches
2020-03-11  7:01   ` Leon Romanovsky
2020-03-12  6:23   ` David Miller
2020-03-12  6:26     ` Joe Perches
2020-03-12  8:03       ` David Miller
2020-03-12 19:45       ` Jakub Kicinski
2020-03-12 19:52         ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 002/491] MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches
2020-03-11  7:00   ` Leon Romanovsky
2020-03-11  4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: " Joe Perches
2020-03-11 15:30   ` Peter Zijlstra
2020-03-12  6:15     ` Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: " Joe Perches
2020-03-11  5:15   ` Masahiro Yamada
2020-03-11 14:31     ` Joe Perches
2020-03-12  8:56       ` Greg Kroah-Hartman
2020-03-12  9:02         ` Masahiro Yamada
2020-03-12  9:36           ` Greg Kroah-Hartman
2020-03-12  9:37           ` Joe Perches
2020-03-12 13:47             ` Theodore Y. Ts'o
2020-03-12 14:15               ` Joe Perches
2020-03-12  9:03         ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
2020-03-12 10:11   ` Russell King - ARM Linux admin
2020-03-12 10:19     ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches
2020-03-11  4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
2020-03-13 19:26   ` Alexander Sverdlin
2020-03-11  4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
2020-03-13 14:26   ` Wolfram Sang
2020-03-14  1:17   ` Stephen Boyd
2020-05-13 11:59     ` Sylwester Nawrocki
2020-03-11  4:51 ` [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: " Joe Perches
2020-03-11  5:23   ` Amit Kucheria [this message]
2020-03-11  8:46   ` Marc Gonzalez
2020-03-11 14:30     ` Joe Perches
2020-03-13 12:04   ` Stanimir Varbanov
2020-03-11  4:51 ` [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 013/491] INGENIC JZ47xx SoCs: " Joe Perches
2020-03-11  7:40   ` Miquel Raynal
2020-03-11 14:20     ` Ulf Hansson
2020-03-11 14:29       ` Miquel Raynal
2020-03-12  6:26     ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches
2020-03-11 19:19   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): " Joe Perches
2020-03-19  1:18   ` Paul Mackerras
2020-03-19  1:22     ` Joe Perches
2020-03-19 23:33       ` Paul Mackerras
2020-03-11  4:51 ` [PATCH -next 017/491] CELL BROADBAND ENGINE ARCHITECTURE: " Joe Perches
2020-03-11  8:08   ` Arnd Bergmann
2020-03-26 12:06   ` Michael Ellerman
2020-03-11  4:51 ` [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): " Joe Perches
2020-03-11 11:33   ` Christian Borntraeger
2020-03-13 12:04   ` Christian Borntraeger
2020-03-11  4:51 ` [PATCH -next 019/491] Hyper-V CORE AND DRIVERS: " Joe Perches
2020-03-11 11:00   ` Wei Liu
2020-03-11  4:51 ` [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: " Joe Perches
2020-03-11  6:47   ` Jürgen Groß
2020-03-11  4:51 ` [PATCH -next 021/491] KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): " Joe Perches
2020-03-11  9:43   ` Paolo Bonzini
2020-03-11  4:51 ` [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: " Joe Perches
2020-03-11 17:14   ` Borislav Petkov
2020-03-11  4:51 ` [PATCH -next 023/491] AMD KFD: " Joe Perches
2020-03-11 21:50   ` Felix Kuehling
2020-03-11 22:09     ` Joe Perches
2020-03-12 14:12       ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 024/491] AMD DISPLAY CORE: " Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 025/491] AMD POWERPLAY: " Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 026/491] INTEL GVT-g DRIVERS (Intel GPU Virtualization): " Joe Perches
2020-03-11  4:51 ` [PATCH -next 027/491] AMD XGBE DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 028/491] BROADCOM BNX2X 10 GIGABIT ETHERNET " Joe Perches
2020-03-11  4:51 ` [PATCH -next 029/491] BROADCOM BNXT_EN 50 " Joe Perches
2020-03-11  4:51 ` [PATCH -next 030/491] BROADCOM GENET " Joe Perches
2020-03-11 16:35   ` Florian Fainelli
2020-03-11  4:51 ` [PATCH -next 031/491] BROCADE BNA 10 GIGABIT " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHLCerPFWFoUpt6Soc1awDiCy6aBn=qTbQ8G5vjhmX-g2=8znA@mail.gmail.com' \
    --to=amit.kucheria@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=joe@perches.com \
    --cc=kishon@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ohad@wizery.com \
    --cc=rui.zhang@intel.com \
    --cc=stanimir.varbanov@linaro.org \
    --subject='Re: [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: Use fallthrough;' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).