LKML Archive on
help / color / mirror / Atom feed
From: Nick Crews <>
To: Enric Balletbo i Serra <>,
	Dmitry Torokhov <>
Cc: Benson Leung <>,
	linux-kernel <>,
	Duncan Laurie <>,
	Daniel Kurtz <>,
	Simon Glass <>,, Oleh Lamzin <>,
	Jason Wong <>
Subject: Re: [PATCH v5] platform/chrome: wilco_ec: Add telemetry char device interface
Date: Fri, 24 May 2019 08:47:51 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hey Enric, thanks for the review!

On Fri, May 24, 2019 at 3:51 AM Enric Balletbo i Serra
<> wrote:
> Hi Nick,
> I'm mostly fine with it but ...
> On 21/5/19 21:20, Nick Crews wrote:
> > The Wilco Embedded Controller is able to send telemetry data
> > which is useful for enterprise applications. A daemon running on
> > the OS sends a command to the EC via a write() to a char device,
> > and can read the response with a read(). The write() request is
> > verified by the driver to ensure that it is performing only one
> > of the whitelisted commands, and that no extraneous data is
> > being transmitted to the EC. The response is passed directly
> > back to the reader with no modification.
> >
> > The character device will appear as /dev/wilco_telemN, where N
> > is some small non-negative integer, starting with 0. Only one
> Still remains my question in the previous version.
> We will really have more than one /dev/wilco_telemN devices handled by this
> driver? Why not use a Miscellaneous Character Device Driver that will simplify
> the code?

We probably will not have more than one device handled by the driver,
but I did this
at the request of Dmitry. He wanted to just do it right the first time so no one
would have to fix it if in the future a second device was needed. FYI,
I did the same
thing for the events driver at

I just tried to find the email thread and/or the review on the
Chromium Gerrit that
documents this, but I couldn't find it. It must have been a private
message, so sorry I
can't link you to it.

Dmitry, am I interpreting your reasoning correctly?


  reply	other threads:[~2019-05-24 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 19:20 Nick Crews
2019-05-24  9:51 ` Enric Balletbo i Serra
2019-05-24 14:47   ` Nick Crews [this message]
2019-06-06 10:22 ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v5] platform/chrome: wilco_ec: Add telemetry char device interface' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).