LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] printk: Monitor change of console loglevel.
Date: Fri, 24 May 2019 10:17:34 -0700	[thread overview]
Message-ID: <CAHk-=wi35ezFsFuHHJ-MbrUAUj0ohQJM4iHHw8n1vyqXMYbVcg@mail.gmail.com> (raw)
In-Reply-To: <1557501546-10263-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On Fri, May 10, 2019 at 8:19 AM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
>
> This patch is intended for testing on linux-next.git only, and
> will be removed after we found what is wrong.

Honestly, wouldn't it be much better to try to come up with a patch
that might be acceptable in general.

For example, how about a config option that just hardcodes
console_loglevel as a compile-time constant, and where you can't
change it at all? There are not that many paths that set the console
log-level, and the few that do could be made to use

    set_console_log_level(x);

instead of

    console_loglevel = x;

like they do.

We already have a number of loglevel config options, adding another
that says "fix log levels at compile time" doesn't sound too bad, and
I suspect a patch that introduces that set_console_log_level() kind of
model and just makes "console_loglevel" a constant #define wouldn't be
too ugly.

A config option or two that help syzbot doesn't sound like a bad idea to me.

Hmm?

                   Linus

  parent reply	other threads:[~2019-05-24 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 15:19 Tetsuo Handa
2019-05-14  9:19 ` Sergey Senozhatsky
2019-05-15 14:32   ` Tetsuo Handa
2019-05-23  9:56     ` Tetsuo Handa
2019-05-24  7:55       ` Dmitry Vyukov
2019-05-24 10:35         ` Tetsuo Handa
2019-05-24 17:17 ` Linus Torvalds [this message]
2019-05-24 17:40   ` Joe Perches
2019-05-24 17:55     ` Linus Torvalds
2019-05-25  0:14   ` Tetsuo Handa
2019-05-25  0:56     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wi35ezFsFuHHJ-MbrUAUj0ohQJM4iHHw8n1vyqXMYbVcg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --subject='Re: [PATCH] printk: Monitor change of console loglevel.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).