LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780
Date: Tue, 20 Jul 2021 17:07:31 +0300	[thread overview]
Message-ID: <CAHp75VcN2fjVDMfkpgyE2tqu=21ku4KBowNDKJxvpbKzwuEPew@mail.gmail.com> (raw)
In-Reply-To: <CY4PR03MB3399083DDE3A03C55D3153FE9BE29@CY4PR03MB3399.namprd03.prod.outlook.com>

On Tue, Jul 20, 2021 at 4:17 PM Miclaus, Antoniu
<Antoniu.Miclaus@analog.com> wrote:
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Friday, July 16, 2021 5:53 PM
> > On Fri, Jul 16, 2021 at 2:43 PM Antoniu Miclaus
> > <antoniu.miclaus@analog.com> wrote:

...

> > First question is why not to use the regmap API (I have heard it has
> > gained support of 17 bit)?
>
> Initially that was the plan, but after this patch:
> https://github.com/torvalds/linux/commit/4191f19792bf91267835eb090d970e9cd6277a65
> the custom write formats for regmap allow the read only via cached registers.
>
> Therefore, I preferred using spi transfers for write/read to/from the device.

Not sure I follow you. That patch is upstream. Does it prevent you
from switching to regmap SPI API?

...

> > > +        depends on COMMON_CLK
> >
> > Is it mandatory for any function inside the device?
>
> Yes. It will serve as LO input to the device.

But can the device work without it (with limited functionality)?

--
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-07-20 14:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 11:42 Antoniu Miclaus
2021-07-16 11:42 ` [PATCH v6 2/2] dt-bindings: iio: frequency: add adrf6780 doc Antoniu Miclaus
2021-07-17 14:21   ` Jonathan Cameron
2021-07-20 14:05     ` Miclaus, Antoniu
2021-07-16 14:53 ` [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780 Andy Shevchenko
2021-07-20 13:17   ` Miclaus, Antoniu
2021-07-20 14:07     ` Andy Shevchenko [this message]
2021-07-20 14:33       ` Miclaus, Antoniu
2021-07-20 14:52         ` Andy Shevchenko
2021-07-17 13:26 ` Jonathan Cameron
2021-07-20 13:34   ` Miclaus, Antoniu
2021-07-24 16:26     ` Jonathan Cameron
2021-07-17 13:58 ` Jonathan Cameron
2021-07-19  0:35 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VcN2fjVDMfkpgyE2tqu=21ku4KBowNDKJxvpbKzwuEPew@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=Antoniu.Miclaus@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).