LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lucas Stankus <lucas.p.stankus@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
	Darius <Darius.Berghe@analog.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: accel: Add driver support for ADXL313
Date: Sun, 29 Aug 2021 17:19:19 +0300	[thread overview]
Message-ID: <CAHp75Vcmg91+cC6st41yTezhV_xQgDkSCprGirEARhETJT=LOQ@mail.gmail.com> (raw)
In-Reply-To: <CACKVXZDpBXK-RRQy4OJ=i+mCFxP=LVBZe0GjAkg_GXZ8hCiSng@mail.gmail.com>

On Wed, Aug 18, 2021 at 11:02 PM Lucas Stankus
<lucas.p.stankus@gmail.com> wrote:
> On Thu, Aug 12, 2021 at 8:06 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Aug 12, 2021 at 12:19 AM Lucas Stankus
> > <lucas.p.stankus@gmail.com> wrote:

...

> > > +       return regmap_update_bits(data->regmap, ADXL313_REG_BW_RATE,
> > > +                                 ADXL313_RATE_MSK,
> >
> > > +                                 FIELD_PREP(ADXL313_RATE_MSK,
> > > +                                            ADXL313_RATE_BASE + i));
> >
> > One line?
> >
>
> Line to long, 87 chars =/

I think it's fine in this case. It will keep the entire FIELD_PREP()
on one line.

-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2021-08-29 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 21:16 [PATCH v3 0/2] iio: accel: Add support for ADXL313 accelerometer Lucas Stankus
2021-08-11 21:17 ` [PATCH v3 1/2] dt-bindings: iio: accel: Add binding documentation for ADXL313 Lucas Stankus
2021-08-17 21:22   ` Rob Herring
2021-08-11 21:18 ` [PATCH v3 2/2] iio: accel: Add driver support " Lucas Stankus
2021-08-12 11:05   ` Andy Shevchenko
2021-08-18 20:01     ` Lucas Stankus
2021-08-29 14:12       ` Jonathan Cameron
2021-08-29 14:19       ` Andy Shevchenko [this message]
2021-08-15 15:26   ` Jonathan Cameron
2021-08-18 20:07     ` Lucas Stankus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vcmg91+cC6st41yTezhV_xQgDkSCprGirEARhETJT=LOQ@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=Darius.Berghe@analog.com \
    --cc=Dragos.Bogdan@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.p.stankus@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).