LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Felix Fietkau <nbd@nbd.name>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	John Crispin <john@phrozen.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v4 12/12] gpio: Add support for Airoha EN7523 GPIO controller
Date: Fri, 26 Nov 2021 18:57:47 +0200	[thread overview]
Message-ID: <CAHp75VcofiOE4LKqTjnXco26Yd5a4VWYkQE3gNU8Z3zr70woVA@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=MfEO-kvOq2aELO6LMSTTHykG8DxdJOf_zUdJSaz8tB8wA@mail.gmail.com>

On Fri, Nov 26, 2021 at 6:40 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Thu, Nov 25, 2021 at 12:24 PM Felix Fietkau <nbd@nbd.name> wrote:
> >
> > From: John Crispin <john@phrozen.org>
> >
> > Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32
> > GPIOs. Each instance in DT is for an single bank.

a single

...

> > +       err = bgpio_init(&ctrl->gc, dev, 4, ctrl->data, NULL,
> > +                        NULL, NULL, NULL, 0);
> > +       if (err) {
> > +               dev_err(dev, "unable to init generic GPIO");
> > +               return err;
> > +       }

Since it will be a new version you may have a chance to replace this with

  return dev_err_probe(dev, err, ...);

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-11-26 17:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211125110738.41028-1-nbd@nbd.name>
2021-11-25 11:07 ` [PATCH v4 01/12] dt-bindings: Add vendor prefix for Airoha Felix Fietkau
2021-11-28 23:28   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 02/12] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB Felix Fietkau
2021-11-28 23:29   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 03/12] ARM: dts: Add basic support for Airoha EN7523 Felix Fietkau
2021-11-25 11:07 ` [PATCH v4 04/12] ARM: Add basic support for Airoha EN7523 SoC Felix Fietkau
2021-11-25 13:21   ` Robin Murphy
2021-11-25 11:07 ` [PATCH v4 05/12] ARM: multi_v7_defconfig: Add " Felix Fietkau
2021-11-25 11:07 ` [PATCH v4 06/12] dt-bindings: Add en7523-scu device tree binding documentation Felix Fietkau
2021-11-28 23:31   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 07/12] clk: en7523: Add clock driver for Airoha EN7523 SoC Felix Fietkau
2021-11-27 11:23   ` kernel test robot
2021-11-25 11:07 ` [PATCH v4 08/12] dt-bindings: PCI: Add support for Airoha EN7532 Felix Fietkau
2021-11-28 23:32   ` Rob Herring
2021-11-25 11:07 ` [PATCH v4 09/12] PCI: mediatek: allow selecting controller driver for airoha arch Felix Fietkau
2021-11-25 11:07 ` [PATCH v4 10/12] ARM: dts: Add PCIe support for Airoha EN7523 Felix Fietkau
2021-11-25 12:15   ` Jianjun Wang
2021-11-25 11:07 ` [PATCH v4 11/12] dt-bindings: arm: airoha: Add binding for Airoha GPIO controller Felix Fietkau
2021-11-26  1:19   ` Linus Walleij
2021-11-25 11:07 ` [PATCH v4 12/12] gpio: Add support for Airoha EN7523 " Felix Fietkau
2021-11-25 12:59   ` Bartosz Golaszewski
2021-11-26 16:57     ` Andy Shevchenko [this message]
2021-11-26 17:19   ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VcofiOE4LKqTjnXco26Yd5a4VWYkQE3gNU8Z3zr70woVA@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=john@phrozen.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v4 12/12] gpio: Add support for Airoha EN7523 GPIO controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).