LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v2 1/2] clk: fractional-divider: switch to rational best approximation
Date: Tue, 31 Mar 2015 10:42:53 +0300	[thread overview]
Message-ID: <CAHp75Vd=t=szZ0eXiGYVVVTv4hWAu35tV53wEq6LB0vx2dCsJw@mail.gmail.com> (raw)
In-Reply-To: <5519EB1D.6070200@codeaurora.org>

On Tue, Mar 31, 2015 at 3:32 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 03/30/15 11:57, Andy Shevchenko wrote:
>> This patch converts the code to use rational best approximation algorithm which
>> is more precise.

>> --- a/drivers/clk/Kconfig
>> +++ b/drivers/clk/Kconfig
>> @@ -14,6 +14,7 @@ config COMMON_CLK
>>       select HAVE_CLK_PREPARE
>>       select CLKDEV_LOOKUP
>>       select SRCU
>> +     select RATIONAL
>>       ---help---
>>         The common clock framework is a single definition of struct
>>         clk, useful across many platforms, as well as an
>> @@ -63,7 +64,6 @@ config COMMON_CLK_SI5351
>>       tristate "Clock driver for SiLabs 5351A/B/C"
>>       depends on I2C
>>       select REGMAP_I2C
>> -     select RATIONAL
>>       ---help---
>>         This driver supports Silicon Labs 5351A/B/C programmable clock
>>         generators.
>> @@ -139,7 +139,6 @@ config COMMON_CLK_CDCE706
>>       tristate "Clock driver for TI CDCE706 clock synthesizer"
>>       depends on I2C
>>       select REGMAP_I2C
>> -     select RATIONAL
>>       ---help---
>>         This driver supports TI CDCE706 programmable 3-PLL clock synthesizer.
>
> Will some kernel janitor find us if we leave the selects here? I know
> you removed it because COMMON_CLK must be Y here and we'd always select
> RATIONAL, but it feels better to leave it alone and actually split off
> the basic clock types into individual configs so that the tiny kernel
> users don't have unused code lying around. That could be future work
> someday and then we might forget to select RATIONAL again.

I'm fine with that as well. So, do I need to resend or you apply
modified version?

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2015-03-31  7:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 18:57 [PATCH v2 0/2] clk: fractional-divider: do a clean up Andy Shevchenko
2015-03-30 18:57 ` [PATCH v2 1/2] clk: fractional-divider: switch to rational best approximation Andy Shevchenko
2015-03-31  0:32   ` Stephen Boyd
2015-03-31  7:42     ` Andy Shevchenko [this message]
2015-03-31  9:33       ` Andy Shevchenko
2015-03-30 18:57 ` [PATCH v2 2/2] clk: fractional-divider: fix sparse warnings Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vd=t=szZ0eXiGYVVVTv4hWAu35tV53wEq6LB0vx2dCsJw@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    --subject='Re: [PATCH v2 1/2] clk: fractional-divider: switch to rational best approximation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).