LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Gianfranco Costamagna <locutusofborg@debian.org>,
	Chris Chiu <chiu@endlessm.com>, Daniel Drake <drake@endlessm.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode
Date: Mon, 7 May 2018 17:08:38 +0300	[thread overview]
Message-ID: <CAHp75VdQegkRceJ10_QLoHvj++FUOYTnmOD2WAYEDRUG2iL4bQ@mail.gmail.com> (raw)
In-Reply-To: <20180427215021.2120-1-antonio.intilisano@gmail.com>

On Sat, Apr 28, 2018 at 12:50 AM, Antonio Rosario Intilisano
<antonio.intilisano@gmail.com> wrote:
>     Now that we have informed the firmware that the Power Button driver is
>     active, laptops such as the Acer Swift 3 will generate
>     a WMI key event with code 0x87 when the power button key is
>     pressed.
>
>     Add this keycode to the table so that it is converted to an appropriate
>     input event.

I pushed it to my review and testing queue, thanks!

Though, see below.

>
> Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
> Tested-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Cc: Chris Chiu <chiu@endlessm.com>
> Cc: Daniel Drake <drake@endlessm.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> ---
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f956d5c..8952173dd380 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {     {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },

This is malformed patch. It states 6 lines for context, though only 4
provided. Please, fix your tools.

>         {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>         {KE_KEY, 0x86, {KEY_WLAN} },
> +       {KE_KEY, 0x87, {KEY_POWER} },
>         {KE_END, 0}
>  };
>
> --
> 2.15.1
>



-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2018-05-07 14:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 21:50 Antonio Rosario Intilisano
2018-05-07 14:08 ` Andy Shevchenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-04-20 21:32 Antonio Rosario Intilisano
2018-04-20 21:26 Antonio Rosario Intilisano
2018-04-21 18:40 ` Gianfranco Costamagna
2018-04-23 14:06   ` Andy Shevchenko
2018-04-23 14:48     ` Gianfranco Costamagna
2018-04-24 16:15       ` Andy Shevchenko
2018-04-24 17:02         ` Andy Shevchenko
2018-04-24 18:23           ` Gianfranco Costamagna
2018-04-24 18:33             ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VdQegkRceJ10_QLoHvj++FUOYTnmOD2WAYEDRUG2iL4bQ@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@infradead.org \
    --cc=antonio.intilisano@gmail.com \
    --cc=chiu@endlessm.com \
    --cc=drake@endlessm.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=locutusofborg@debian.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --subject='Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).