From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A8C6C432BE for ; Wed, 4 Aug 2021 07:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC91760EBC for ; Wed, 4 Aug 2021 07:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235889AbhHDHjN (ORCPT ); Wed, 4 Aug 2021 03:39:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235619AbhHDHjM (ORCPT ); Wed, 4 Aug 2021 03:39:12 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0762EC0613D5; Wed, 4 Aug 2021 00:38:59 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id z3so2073084plg.8; Wed, 04 Aug 2021 00:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/1fnGxDd0u/KO3OYmBt1hqVEy3ZVm3ezsLmdUm+AT1k=; b=t2al545lGWXDE+IrBUj6kjABFhNlXPKjpi56OsfM7nDToutk0x/+13Lf3lB9dk921F NgunzaL3NJsp0ssYMW3cYYlTgmkvmPbi7yuUDgvMXpxMCR22qHZWp+5AXHJm8UHDEEdO mmpSwMxWuTn8qexitJAZLwt6O71r6tX1Froe+sCz4tVhTPTUaRH1KQ6qn5JN6aGf0aJ6 DTAPDpmZE83qkcV+ELy/p3jZao1eb7RovcdF8KxC1QZkcSqvVC84A7uN0gPY7RGVcuiZ nm8+X2tmEjWwYJQ2AChm0AvKiEVfkAyNsCquLqeP88hVZA44cOIpnxNNlcTXVlZy5C/w KEDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/1fnGxDd0u/KO3OYmBt1hqVEy3ZVm3ezsLmdUm+AT1k=; b=sqV875GEEtTkMfaTqV5/W4DsfUxBxvv1TBUO6Ko2cHxmkNzoFlUSFvjy7rpTJNo6EF wQ89zS/fx/ezgIICqe7Ux4pcCJedTT/rYIFGrrwxYNWLBl9jUZZFNA8Havzg8/aXEFl+ 8v2L9VVN/4Hmodn6w/n2nEbPI6242Skos8m7HF2ZBc+Y2mCO44gBp0gzYXKOHk+h/gXS 9AkBFGhODi6bwUa7VXqgIq/oJrERX3hUGmUavo/sK006xuYujr3lDJ37YVoT6R9KStky NIy77e3q16pgdls4HCO4is5Dkc3tZrAYAqCrKnlWXq3YVT+yRg6+4tL6c3X+0O1UOf1R CuCg== X-Gm-Message-State: AOAM531l7FMvK2fTIQt0Kx+J+3QJLxFKlovonIHJcrMBE+21XboN/BiU yIaUa2yx6RjDKAfUO4olYOFpvOprmBrV80rxFjU= X-Google-Smtp-Source: ABdhPJyo6k11qe9mgZUkeiX2Z9vHXhC8pf9bZuDidjcgojlx9+1dWKRxa087OehLD6AqCLTzmoD9XaA+RTZC00T0z20= X-Received: by 2002:a17:902:b713:b029:12b:b249:693f with SMTP id d19-20020a170902b713b029012bb249693fmr5415074pls.17.1628062738544; Wed, 04 Aug 2021 00:38:58 -0700 (PDT) MIME-Version: 1.0 References: <20210729053937.20281-1-shruthi.sanil@intel.com> <20210729053937.20281-2-shruthi.sanil@intel.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 4 Aug 2021 10:38:22 +0300 Message-ID: Subject: Re: [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer To: "Sanil, Shruthi" Cc: Rob Herring , "daniel.lezcano@linaro.org" , "tglx@linutronix.de" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "andriy.shevchenko@linux.intel.com" , "kris.pan@linux.intel.com" , "mgross@linux.intel.com" , "Thokala, Srikanth" , "Raja Subramanian, Lakshmi Bai" , "Sangannavar, Mallikarjunappa" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 4, 2021 at 8:35 AM Sanil, Shruthi wro= te: > > From: Rob Herring > > Sent: Tuesday, August 3, 2021 4:14 AM ... > > > +properties: > > > > You need a 'compatible' here. Otherwise, how does one know what 'reg' > > contains. Also, without it, this schema will never be applied. > > > > This is a parent block that has the common configuration register address= defined which we would need during the initialization of the child nodes. = This block in itself is not doing anything. We have this because, we have a= common register that is required to be accessed during all the timers and = counter initialization. > The child nodes have the compatible string, which is used in the driver. = I have validated this on the Keem Bay HW and see that the timer probes are = being called and the timers are functional as expected. I think I understand now. The problem is that the current state of affairs with this block is incorrect software representation. What you need is to create an MFD device driver (for which the compatible will exactly the one Rob is telling about) and from it you register the rest of your drivers. The existing drivers for this block should be converted to MFD schema. --=20 With Best Regards, Andy Shevchenko