LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Gayatri Kammela <gayatri.kammela@intel.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
	Mark Gross <mgross@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	You-Sheng Yang <vicamo.yang@canonical.com>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"Box, David E" <david.e.box@intel.com>,
	chao.qin@intel.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Tamar Mashiah <tamar.mashiah@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rajat Jain <rajatja@google.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Alex Deucher <Alexander.Deucher@amd.com>,
	mlimonci@amd.com
Subject: Re: [PATCH v6 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder
Date: Sat, 31 Jul 2021 11:41:45 +0300	[thread overview]
Message-ID: <CAHp75VeAu2fs5zesQE0YqsOSTVO8zPacpW9e89adYBoZnGToOg@mail.gmail.com> (raw)
In-Reply-To: <fa72dfad9282e2c24b99327d08cbe032d7034bbf.1627710766.git.gayatri.kammela@intel.com>

On Sat, Jul 31, 2021 at 9:10 AM Gayatri Kammela
<gayatri.kammela@intel.com> wrote:
>
> As part of collecting Intel x86 specific drivers in their own
> folder, move intel_pmc_core* files to its own subfolder there.

...

>  .../pmc/pltdrv.c}                             |  0

I would go further and spell it as platform.c.

...

> -F:     drivers/platform/x86/intel_pmc_core*
> +F:     drivers/platform/x86/intel/pmc/core*

This seems incorrect.

...

> +         Supported features:
> +               - SLP_S0_RESIDENCY counter
> +               - PCH IP Power Gating status
> +               - LTR Ignore / LTR Show

> +               - MPHY/PLL gating status (Sunrisepoint PCH only)
> +               - SLPS0 Debug registers (Cannonlake/Icelake PCH)
> +               - Low Power Mode registers (Tigerlake and beyond)

Perhaps you may use the opportunity to spell codenames in a better way, i.e.
Sunrise Point
Cannon Lake
Ice Lake
Tiger Lake

as it's done almost everywhere else in the kernel.

...

> +obj-$(CONFIG_INTEL_PMC_CORE)   += intel_pmc_core.o
> +intel_pmc_core-objs            += core.o

objs suffix is not for kernel modules.
Moreover, := has a difference to +=. Why is the latter in use?

> +obj-$(CONFIG_INTEL_PMC_CORE)   += pltdrv.o

This will have the very same issue as with the core module. On top of
that, do you need a separate module for it? If so, why?

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-07-31  8:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31  6:07 [PATCH v6 0/5] Add Alder Lake PCH-S support to PMC core driver Gayatri Kammela
2021-07-31  6:07 ` [PATCH v6 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder Gayatri Kammela
2021-07-31  8:41   ` Andy Shevchenko [this message]
2021-08-16 16:59     ` Kammela, Gayatri
2021-07-31  6:07 ` [PATCH v6 2/5] platform/x86/intel: pmc/core: Add Alderlake support to pmc core driver Gayatri Kammela
2021-07-31  6:07 ` [PATCH v6 3/5] platform/x86/intel: pmc/core: Add Latency Tolerance Reporting (LTR) support to Alder Lake Gayatri Kammela
2021-07-31  6:07 ` [PATCH v6 4/5] platform/x86/intel: pmc/core: Add Alder Lake low power mode support for pmc core Gayatri Kammela
2021-07-31  6:07 ` [PATCH v6 5/5] platform/x86/intel: pmc/core: Add GBE Package C10 fix for Alder Lake PCH Gayatri Kammela
2021-07-31  8:43   ` Andy Shevchenko
2021-08-03 12:19 ` [PATCH v6 0/5] Add Alder Lake PCH-S support to PMC core driver Hans de Goede
2021-08-16 17:03   ` Kammela, Gayatri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VeAu2fs5zesQE0YqsOSTVO8zPacpW9e89adYBoZnGToOg@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=chao.qin@intel.com \
    --cc=david.e.box@intel.com \
    --cc=gayatri.kammela@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=mlimonci@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rajatja@google.com \
    --cc=srinivas.pandruvada@intel.com \
    --cc=tamar.mashiah@intel.com \
    --cc=vicamo.yang@canonical.com \
    --subject='Re: [PATCH v6 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).