LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: peng.hao2@zte.com.cn
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andy Shevchenko <andy@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	hutao@cn.fujitsu.com,
	Linux Documentation List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT
Date: Wed, 31 Oct 2018 14:53:38 +0200	[thread overview]
Message-ID: <CAHp75VeQD7xEUyR=Vwk78R3Ld2OfBzL=mkKQF9YLO0nKJyJ6zA@mail.gmail.com> (raw)
In-Reply-To: <1540993041-25611-4-git-send-email-peng.hao2@zte.com.cn>

On Wed, Oct 31, 2018 at 7:27 AM Peng Hao <peng.hao2@zte.com.cn> wrote:
>
> By default, when ACPI tables and FDT coexist for ARM64,
> current kernel takes precedence over FDT to get device information.
> Virt machine in qemu provides both FDT and ACPI table. This patch
> increases the way to get information through FDT.

> @@ -3,15 +3,18 @@

>   *  Copyright (C) 2013 Fujitsu.
> + *  Copyright (C) 2018 ZTE.

> +#include <linux/acpi.h>
...
> -#include <linux/acpi.h>

> -       { "", 0 },
> +       { "", 0 }

These changes regarding to style should go in a separate patch.

>  #include <linux/module.h>
> -#include <linux/init.h>

This one also in a separate patch.

So, the one should be split to three AFAICS.

-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2018-10-31 12:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 13:37 [PATCH V4 1/5] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-10-31  7:05 ` Mark Rutland
2018-10-31 12:45 ` Andy Shevchenko
2018-10-31 13:37 ` [PATCH V4 2/5] misc/pvpanic : convert to SPDX license tags Peng Hao
2018-10-31 12:46   ` Andy Shevchenko
2018-10-31 13:37 ` [PATCH V4 3/5] misc/pvpanic: add MMIO support Peng Hao
2018-10-31 12:49   ` Andy Shevchenko
2018-10-31 13:37 ` [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-10-31 12:50   ` Andy Shevchenko
2018-10-31 12:53   ` Andy Shevchenko [this message]
2018-10-31 13:37 ` [PATCH V4 5/5] dt-bindings/misc/pvpanic :add document for pvpanic-mmio Peng Hao
  -- strict thread matches above, loose matches on Subject: below --
2018-10-29 11:32 [PATCH V3 1/5] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-10-29 11:32 ` [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT Peng Hao
2018-10-29 11:37   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VeQD7xEUyR=Vwk78R3Ld2OfBzL=mkKQF9YLO0nKJyJ6zA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=arnd@arndb.de \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hutao@cn.fujitsu.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peng.hao2@zte.com.cn \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).