LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matt Ranostay <matt.ranostay@konsulko.com>
To: Julia.Lawall@lip6.fr
Cc: kernel-janitors@vger.kernel.org, mchehab@kernel.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] media: video-i2c: hwmon: constify vb2_ops structure
Date: Tue, 30 Oct 2018 09:43:10 -0700	[thread overview]
Message-ID: <CAJCx=gmixee=j_y9v__40x1StZXrtaK0wWrWDibMbYb3HAfnbA@mail.gmail.com> (raw)
In-Reply-To: <1540913482-22130-3-git-send-email-Julia.Lawall@lip6.fr>

On Tue, Oct 30, 2018 at 9:06 AM Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> The vb2_ops structure can be const as it is only stored in the ops
> field of a vb2_queue structure and this field is const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>

>
> ---
>  drivers/media/i2c/video-i2c.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
> index 4d49af86c15e..cb89cda6553d 100644
> --- a/drivers/media/i2c/video-i2c.c
> +++ b/drivers/media/i2c/video-i2c.c
> @@ -336,7 +336,7 @@ static void stop_streaming(struct vb2_queue *vq)
>         video_i2c_del_list(vq, VB2_BUF_STATE_ERROR);
>  }
>
> -static struct vb2_ops video_i2c_video_qops = {
> +static const struct vb2_ops video_i2c_video_qops = {
>         .queue_setup            = queue_setup,
>         .buf_prepare            = buffer_prepare,
>         .buf_queue              = buffer_queue,
>

      reply	other threads:[~2018-10-30 16:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 15:31 [PATCH 0/2] constify vb2_ops structures Julia Lawall
2018-10-30 15:31 ` [PATCH 1/2] usb: gadget: uvc: constify vb2_ops structure Julia Lawall
2018-10-30 18:54   ` Laurent Pinchart
2018-10-30 15:31 ` [PATCH 2/2] media: video-i2c: hwmon: " Julia Lawall
2018-10-30 16:43   ` Matt Ranostay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJCx=gmixee=j_y9v__40x1StZXrtaK0wWrWDibMbYb3HAfnbA@mail.gmail.com' \
    --to=matt.ranostay@konsulko.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --subject='Re: [PATCH 2/2] media: video-i2c: hwmon: constify vb2_ops structure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).