LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Lucas Stach <dev@lynxeye.de>
Subject: Re: [PATCH v2] ARM: dts: tegra: Add support for 256 MB Colibri-T20 (plus such board on Iris)
Date: Fri, 4 May 2018 12:03:36 +0200	[thread overview]
Message-ID: <CAJKOXPeb+DmKVQ1uXkBOjaGMpxtPVFp54SBWm6h=+o30z9K3aQ@mail.gmail.com> (raw)
In-Reply-To: <c47c07b2c112219093b668c0b4d46ac8@agner.ch>

On Fri, May 4, 2018 at 11:19 AM, Stefan Agner <stefan@agner.ch> wrote:
> On 03.05.2018 17:08, Krzysztof Kozlowski wrote:
>> Colibri-T20 can come in 256 MB RAM (with 512 MB NAND) or 512 MB RAM
>> (with 1024 MB NAND) flavors.  Add support for the 256 MB version on Iris
>> evaluation board.
>
> To we really need to specify memory size these days? I think all common
> boot loaders fill the memory node anyway.
>
> arch/arm/boot/dts/imx6qdl-apalis.dtsi:
>         /* Will be filled by the bootloader */
>         memory@10000000 {
>                 reg = <0x10000000 0>;
>         };
>
>
> I think we should just rename tegra20-colibri-512.dtsi =>
> tegra20-colibri.dtsi and tegra20-iris-512.dts => tegra20-iris.dts to
> avoid confusion and add such an empty node.

Having memory node is requirement of DeviceTree specification (at
least one cpu and memory node). Of course if bootloader fills it, then
we could assume that specification is satisfied... but what if some
bootloader skips it? This creates quite specific dependency between
kernel's DTS and bootloader.

One safe solution would be to specify 256 MB memory node for both
boards and assume that bootloader will bump it to 512 MB for specific
module.

>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> ---
>>
>> Changes since v1:
>> 1. Fix memory size in tegra20-colibri-256.dtsi (was working fine because
>>    my bootloader uses mem= argument).
>
> What boot loader are you using? You even can omit mem= if your boot
> loader fills the memory node properly.

I use the one provided by vendor - Toradex. By default it passes both
mem= and few other mem-like arguments (for FB and video processor) to
command line. I believe it does not adjust the DTB itself because
Toradex prepared this bootloader for... 3.1 kernel without DTB. 7
years old kernel. :)

Best regards,
Krzysztof

  parent reply	other threads:[~2018-05-04 10:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 15:08 Krzysztof Kozlowski
2018-05-04  9:19 ` Stefan Agner
2018-05-04  9:37   ` Marcel Ziswiler
2018-05-04 10:03   ` Krzysztof Kozlowski [this message]
2018-05-04 10:14     ` Marcel Ziswiler
2018-05-08 12:35       ` Krzysztof Kozlowski
2018-05-08 13:03         ` Marcel Ziswiler
2018-05-07 16:58 ` Rob Herring
2018-05-08  7:26   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPeb+DmKVQ1uXkBOjaGMpxtPVFp54SBWm6h=+o30z9K3aQ@mail.gmail.com' \
    --to=krzk@kernel.org \
    --cc=dev@lynxeye.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    --cc=thierry.reding@gmail.com \
    --subject='Re: [PATCH v2] ARM: dts: tegra: Add support for 256 MB Colibri-T20 (plus such board on Iris)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).