LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id
Date: Thu, 2 Apr 2015 12:16:58 +0200	[thread overview]
Message-ID: <CAJKOXPf=aia+aeud-7V1YrDA1rhG3eyJrH_tcY-aEKTbVTTUGQ@mail.gmail.com> (raw)
In-Reply-To: <064c01d06b7f$aed30cf0$0c7926d0$@kernel.org>

2015-03-31 8:55 GMT+02:00 Kukjin Kim <kgene@kernel.org>:
> Javier Martinez Canillas wrote:
>>
>> On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> > Hi,
>> >
>> > On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> >> Use a define instead of raw number as a ID for "rtc_src" clock.
>> >>
>> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> >>
>> >> ---
>> >>
>> >> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> >> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
>> >> ---
>> >>  arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>> >>  1 file changed, 2 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> index 3905824cac58..d2cbc95364de 100644
>> >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> >> @@ -16,6 +16,7 @@
>> >>  #include "exynos3250.dtsi"
>> >>  #include <dt-bindings/input/input.h>
>> >>  #include <dt-bindings/gpio/gpio.h>
>> >> +#include <dt-bindings/clock/samsung,s2mps11.h>
>> >>
>> >>  / {
>> >>       model = "Samsung Rinato board";
>> >> @@ -605,7 +606,7 @@
>> >>  };
>> >>
>> >>  &rtc {
>> >> -     clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> >> +     clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>> >>       clock-names = "rtc", "rtc_src";
>> >>       status = "okay";
>> >>  };
>> >>
>> >
>> > Looks good to me.
>> >
>> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>> >
>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>
> Thanks for you guys' review. Applied.

Thanks Kukjin! I forgot to do this also for exynos3250-monk board.
I'll send another patch for it but you may squash them if you want.

Best regards,
Krzysztof

      reply	other threads:[~2015-04-02 10:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 15:21 Krzysztof Kozlowski
2015-03-31  4:05 ` Chanwoo Choi
2015-03-31  6:37   ` Javier Martinez Canillas
2015-03-31  6:55     ` Kukjin Kim
2015-04-02 10:16       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPf=aia+aeud-7V1YrDA1rhG3eyJrH_tcY-aEKTbVTTUGQ@mail.gmail.com' \
    --to=k.kozlowski@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.reichl@fivetechno.de \
    --cc=m.szyprowski@samsung.com \
    --subject='Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).