Re: [PATCH v1 1/2] tracing: Improve design of preemptirq tracepoints and its users

[Joel Fernandes <joelaf@google.com>]

Hello,

On Thu, Mar 15, 2018 at 12:51 PM, kbuild test robot <lkp@intel.com> wrote:
>
> Hi Joel,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.16-rc5 next-20180315]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes/tracing-Improve-design-of-preemptirq-tracepoints-and-its-users/20180316-012211
> config: i386-randconfig-x006-201810 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>    kernel//locking/lockdep.c: In function 'lockdep_init':
> >> kernel//locking/lockdep.c:4325:2: error: implicit declaration of function 'register_trace_irq_disable'; did you mean 'trace_irq_disable'? [-Werror=implicit-function-declaration]
>      register_trace_irq_disable(lockdep_hardirqs_off, NULL);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~

The reason for this is PREEMPTIRQ_TRACEPOINTS depends on FTRACE which
is turned off in the config. Its a combination I hadn't tested in my
matrix. It causes build errors in in lockdep code that tries to
register the lockdep hooks. I'll fix it in the next rev. Thanks.

- Joel