LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()
@ 2018-04-26 16:12 Moritz Fischer
  2018-04-26 16:12 ` [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
  2018-04-26 16:26 ` [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Lars-Peter Clausen
  0 siblings, 2 replies; 5+ messages in thread
From: Moritz Fischer @ 2018-04-26 16:12 UTC (permalink / raw)
  To: linux-kernel; +Cc: dmaengine, vinod.koul, dan.j.williams, lars, Moritz Fischer

Use devm_request_irq() instead of request_irq() to request the IRQ.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---

Hi Lars,

was there a specific reason not to use devm_request_irq() ?

Cheers,

Moritz

---
 drivers/dma/dma-axi-dmac.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 2419fe524daa..75ccedaa96d2 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -687,8 +687,9 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unregister_device;
 
-	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
-		dev_name(&pdev->dev), dmac);
+	ret = devm_request_irq(&pdev->dev, dmac->irq,
+			       axi_dmac_interrupt_handler, 0,
+			       dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;
 
@@ -711,7 +712,6 @@ static int axi_dmac_remove(struct platform_device *pdev)
 	struct axi_dmac *dmac = platform_get_drvdata(pdev);
 
 	of_dma_controller_free(pdev->dev.of_node);
-	free_irq(dmac->irq, dmac);
 	tasklet_kill(&dmac->chan.vchan.task);
 	dma_async_device_unregister(&dmac->dma_dev);
 	clk_disable_unprepare(dmac->clk);
-- 
2.17.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-26 16:12 [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Moritz Fischer
@ 2018-04-26 16:12 ` Moritz Fischer
  2018-04-26 16:27   ` Lars-Peter Clausen
  2018-04-26 16:26 ` [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Lars-Peter Clausen
  1 sibling, 1 reply; 5+ messages in thread
From: Moritz Fischer @ 2018-04-26 16:12 UTC (permalink / raw)
  To: linux-kernel; +Cc: dmaengine, vinod.koul, dan.j.williams, lars, Moritz Fischer

Request IRQ with IRQF_SHARED flag. This works since the interrupt
handler already checks if there is an actual IRQ pending and returns
IRQ_NONE otherwise.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
 drivers/dma/dma-axi-dmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 75ccedaa96d2..2bd195532882 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -688,7 +688,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
 		goto err_unregister_device;
 
 	ret = devm_request_irq(&pdev->dev, dmac->irq,
-			       axi_dmac_interrupt_handler, 0,
+			       axi_dmac_interrupt_handler, IRQF_SHARED,
 			       dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()
  2018-04-26 16:12 [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Moritz Fischer
  2018-04-26 16:12 ` [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
@ 2018-04-26 16:26 ` Lars-Peter Clausen
  2018-04-26 16:43   ` Moritz Fischer
  1 sibling, 1 reply; 5+ messages in thread
From: Lars-Peter Clausen @ 2018-04-26 16:26 UTC (permalink / raw)
  To: Moritz Fischer, linux-kernel; +Cc: dmaengine, vinod.koul, dan.j.williams

On 04/26/2018 06:12 PM, Moritz Fischer wrote:
> Use devm_request_irq() instead of request_irq() to request the IRQ.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> 
> Hi Lars,
> 
> was there a specific reason not to use devm_request_irq() ?

Yes, it is wrong :)

This reorders the sequence in the remove() function. We really need to free
the IRQ at the point in the sequence where it is at the moment. We need to
call tasklet_kill() after the free_irq() function has been called, otherwise
the tasklet can be re-scheduled and we might end up with a use after free.

But also if we disable the clock to the core before the IRQ is freed we
might end up trying to access the register map while the clock is off and
then never get a response and block the AXI bus.

This is all very very unlikely to ever happen, but still I'd like to have
correct code.

> 
> Cheers,
> 
> Moritz
> 
> ---
>  drivers/dma/dma-axi-dmac.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 2419fe524daa..75ccedaa96d2 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -687,8 +687,9 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_unregister_device;
>  
> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
> -		dev_name(&pdev->dev), dmac);
> +	ret = devm_request_irq(&pdev->dev, dmac->irq,
> +			       axi_dmac_interrupt_handler, 0,
> +			       dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
>  
> @@ -711,7 +712,6 @@ static int axi_dmac_remove(struct platform_device *pdev)
>  	struct axi_dmac *dmac = platform_get_drvdata(pdev);
>  
>  	of_dma_controller_free(pdev->dev.of_node);
> -	free_irq(dmac->irq, dmac);
>  	tasklet_kill(&dmac->chan.vchan.task);
>  	dma_async_device_unregister(&dmac->dma_dev);
>  	clk_disable_unprepare(dmac->clk);
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-26 16:12 ` [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
@ 2018-04-26 16:27   ` Lars-Peter Clausen
  0 siblings, 0 replies; 5+ messages in thread
From: Lars-Peter Clausen @ 2018-04-26 16:27 UTC (permalink / raw)
  To: Moritz Fischer, linux-kernel; +Cc: dmaengine, vinod.koul, dan.j.williams

On 04/26/2018 06:12 PM, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

> ---
>  drivers/dma/dma-axi-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 75ccedaa96d2..2bd195532882 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -688,7 +688,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  		goto err_unregister_device;
>  
>  	ret = devm_request_irq(&pdev->dev, dmac->irq,
> -			       axi_dmac_interrupt_handler, 0,
> +			       axi_dmac_interrupt_handler, IRQF_SHARED,
>  			       dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()
  2018-04-26 16:26 ` [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Lars-Peter Clausen
@ 2018-04-26 16:43   ` Moritz Fischer
  0 siblings, 0 replies; 5+ messages in thread
From: Moritz Fischer @ 2018-04-26 16:43 UTC (permalink / raw)
  To: Lars-Peter Clausen
  Cc: Linux Kernel Mailing List, dmaengine, vinod.koul, dan.j.williams

Hi Lars,

On Thu, Apr 26, 2018 at 9:26 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 04/26/2018 06:12 PM, Moritz Fischer wrote:
>> Use devm_request_irq() instead of request_irq() to request the IRQ.
>>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> ---
>>
>> Hi Lars,
>>
>> was there a specific reason not to use devm_request_irq() ?
>
> Yes, it is wrong :)
>
> This reorders the sequence in the remove() function. We really need to free
> the IRQ at the point in the sequence where it is at the moment. We need to
> call tasklet_kill() after the free_irq() function has been called, otherwise
> the tasklet can be re-scheduled and we might end up with a use after free.
>
> But also if we disable the clock to the core before the IRQ is freed we
> might end up trying to access the register map while the clock is off and
> then never get a response and block the AXI bus.
>
> This is all very very unlikely to ever happen, but still I'd like to have
> correct code.

Thanks for the explanation. I'll drop this and resubmit [2/2] without
this change.

- Moritz

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-04-26 16:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 16:12 [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Moritz Fischer
2018-04-26 16:12 ` [PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
2018-04-26 16:27   ` Lars-Peter Clausen
2018-04-26 16:26 ` [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq() Lars-Peter Clausen
2018-04-26 16:43   ` Moritz Fischer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).