LKML Archive on
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <>
To: Bjorn Helgaas <>
Cc: "Rafael J. Wysocki" <>,
	Linux PCI <>,
	Linux PM <>,
	LKML <>,
	Bjorn Helgaas <>,
	Mika Westerberg <>
Subject: Re: [PATCH] PCI / PM: Do not clear state_saved for devices that remain suspended
Date: Wed, 23 May 2018 10:11:38 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, May 23, 2018 at 12:01 AM, Bjorn Helgaas <> wrote:
> On Fri, May 18, 2018 at 10:17:42AM +0200, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <>
>> The state_saved flag should not be cleared in pci_pm_suspend() if the
>> given device is going to remain suspended, or the device's config
>> space will not be restored properly during the subsequent resume.
>> Namely, if the device is going to stay in suspend, both the late
>> and noirq callbacks return early for it, so if its state_saved flag
>> is cleared in pci_pm_suspend(), it will remain unset throughout the
>> remaining part of suspend and resume and pci_restore_state() called
>> for the device going forward will return without doing anything.
>> For this reason, change pci_pm_suspend() to only clear state_saved
>> if the given device is not going to remain suspended.  [This is
>> analogous to what commit ae860a19f37c (PCI / PM: Do not clear
>> state_saved in pci_pm_freeze() when smart suspend is set) did for
>> hibernation.]
>> Fixes: c4b65157aeef (PCI / PM: Take SMART_SUSPEND driver flag into account)
>> Signed-off-by: Rafael J. Wysocki <>
> Acked-by: Bjorn Helgaas <>
> I assume you'll take this one, too.

Yes, I will, thank you!

      reply	other threads:[~2018-05-23  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  8:17 Rafael J. Wysocki
2018-05-18 10:53 ` Mika Westerberg
2018-05-22 22:01 ` Bjorn Helgaas
2018-05-23  8:11   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] PCI / PM: Do not clear state_saved for devices that remain suspended' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).