LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
	linux-media@vger.kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/10] dt-bindings: media: sunxi-ir: Add A64 compatible
Date: Sun, 26 May 2019 21:15:49 +0200	[thread overview]
Message-ID: <CAJiuCceHhxYt=BY0Jvfv6+80ekKcMLUSv5UWBorYuvtO-DkOtg@mail.gmail.com> (raw)
In-Reply-To: <20190526190410.ngrvrclp5ge5rdqy@flea>

Hi Maxime,

On Sun, 26 May 2019 at 21:04, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Sat, May 25, 2019 at 08:09:17PM +0200, Clément Péron wrote:
> > There is some minor differences between A31 and A64 driver.
> >
> > But A31 IR driver is compatible with A64.
> >
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/media/sunxi-ir.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/sunxi-ir.txt b/Documentation/devicetree/bindings/media/sunxi-ir.txt
> > index 53e88ebb53fe..da5aeba843de 100644
> > --- a/Documentation/devicetree/bindings/media/sunxi-ir.txt
> > +++ b/Documentation/devicetree/bindings/media/sunxi-ir.txt
> > @@ -5,6 +5,7 @@ Required properties:
> >       "allwinner,sun4i-a10-ir"
> >       "allwinner,sun5i-a13-ir"
> >       "allwinner,sun6i-a31-ir"
> > +     "allwinner,sun50i-a64-ir", "allwinner,sun6i-a31-ir"
>
> I guess resets is mandatory for the A31 onwards too, right?

Indeed, I will add this information in the device-tree bindings.
Ideally, we should also introduce a quirks with a "has_reset" property.

Thanks for your review,
Clément

>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

  reply	other threads:[~2019-05-26 19:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-25 18:09 [PATCH 00/10] Allwiner A64/H6 IR support Clément Péron
2019-05-25 18:09 ` [PATCH 01/10] dt-bindings: media: A31 compatible Clément Péron
2019-05-26 19:02   ` Maxime Ripard
2019-05-26 19:08     ` Clément Péron
2019-05-25 18:09 ` [PATCH 02/10] media: rc: sunxi: Add " Clément Péron
2019-05-25 18:09 ` [PATCH 03/10] ARM: dts: sunxi: prefer A31 instead of A13 for ir Clément Péron
2019-05-25 18:09 ` [PATCH 04/10] dt-bindings: media: sunxi-ir: Add A64 compatible Clément Péron
2019-05-26 19:04   ` Maxime Ripard
2019-05-26 19:15     ` Clément Péron [this message]
2019-05-25 18:09 ` [PATCH 05/10] arm64: dts: allwinner: a64: Add IR node Clément Péron
2019-05-25 18:09 ` [PATCH 06/10] arm64: dts: allwinner: a64: Enable IR on Orange Pi Win Clément Péron
2019-05-25 18:09 ` [PATCH 07/10] dt-bindings: media: sunxi-ir: Add H6 compatible Clément Péron
2019-05-25 18:09 ` [PATCH 08/10] arm64: dts: allwiner: h6: Add IR receiver node Clément Péron
2019-05-25 18:09 ` [PATCH 09/10] arm64: dts: allwinner: h6: Enable IR on H6 boards Clément Péron
2019-05-25 18:09 ` [PATCH 10/10] arm64: defconfig: enable IR SUNXI option Clément Péron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJiuCceHhxYt=BY0Jvfv6+80ekKcMLUSv5UWBorYuvtO-DkOtg@mail.gmail.com' \
    --to=peron.clem@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH 04/10] dt-bindings: media: sunxi-ir: Add A64 compatible' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).