From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53279C282E5 for ; Sun, 26 May 2019 19:16:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28EFB216FD for ; Sun, 26 May 2019 19:16:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D8JnONzv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727140AbfEZTQG (ORCPT ); Sun, 26 May 2019 15:16:06 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:37312 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbfEZTQF (ORCPT ); Sun, 26 May 2019 15:16:05 -0400 Received: by mail-yw1-f66.google.com with SMTP id 186so5815849ywo.4; Sun, 26 May 2019 12:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=noskaXJB+lKStgYLNqjD43scq/LOmprbRcl7XPqZyEI=; b=D8JnONzvJVlbSq818NlO2tEUyWIfBoSFmPsh5zvcDyBHWIlsg/7WbzUDiBGXDGAa7t t7q/y9nPrbUqqkKlGdqnb0djhVmy6zqH1f47Z4PDzhqU1x2w7hZNelCNTCOpD13xVL1O ZXbpqJTWIhIkHYxjvmoGoEFYcUfZ7ezMF2AkwVJlNHt4HR36YZKr2zCpBrXoR3LnYP1K PXKJcdeEEjMtuWmQN0LmMdGXR4WGYNss6d30qaK4MmrC9KOQmgn6/n9ZxVEiEa787Ywe ZHeqUNq1DmIrBF1UNo7bLY4/n1OEYs7At07Uz5vFO5lZL7KPf6H57qHjmR7U1zykp5tQ Qptg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=noskaXJB+lKStgYLNqjD43scq/LOmprbRcl7XPqZyEI=; b=q3OMvuAI+N1vAgBgWFO9dEkDsdTyyRGG4Md5LtGzjhdI7xR4gMIKzhQV3rmx9RNUIq HwKyTo1fGjrMeWYlOC0M79JO5nGKzw3zWX8pBF7PRse3V9sqNZvCd/yLT8DPvADnIwus jKqyIG08VZLJz+mbzdSHbepoEYDHoI0YiUYzT3Ni8UUvegLqhwHH7L5/x4DCGMwFDo+L BJ48zxpBHg2Wk0P0QJKHVAW9bG86KwGkk3aEa3ignIQARtajVSu3Ud/H11Dj+Oejds1B 9YyGZP03RT6b3Yf9AMOVRjatSw+GQeNe1AjSCKXKoighZMUzRQxukDDb43abaM2y7rC2 bp/g== X-Gm-Message-State: APjAAAXGskhURqx+xSrHo+W8SVkGg8cGtIsvUh+C+m0gArds2eisH+Og pWoVypFGMIwq8+B9pbZAm7wMxOuL0fIR6jS7ip8= X-Google-Smtp-Source: APXvYqz+VzNt0oKUMWNius14IRSdTfbNvnD/DEiP9e5FvjbEQtR2ABEeJ+6nuk7ooQZFFcE+eOm26NaadqAoXgSQSww= X-Received: by 2002:a81:9a4b:: with SMTP id r72mr30838628ywg.422.1558898160019; Sun, 26 May 2019 12:16:00 -0700 (PDT) MIME-Version: 1.0 References: <20190525180923.6105-1-peron.clem@gmail.com> <20190525180923.6105-5-peron.clem@gmail.com> <20190526190410.ngrvrclp5ge5rdqy@flea> In-Reply-To: <20190526190410.ngrvrclp5ge5rdqy@flea> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Sun, 26 May 2019 21:15:49 +0200 Message-ID: Subject: Re: [PATCH 04/10] dt-bindings: media: sunxi-ir: Add A64 compatible To: Maxime Ripard Cc: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , linux-media@vger.kernel.org, devicetree , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Sun, 26 May 2019 at 21:04, Maxime Ripard wro= te: > > On Sat, May 25, 2019 at 08:09:17PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > > There is some minor differences between A31 and A64 driver. > > > > But A31 IR driver is compatible with A64. > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > --- > > Documentation/devicetree/bindings/media/sunxi-ir.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/sunxi-ir.txt b/Doc= umentation/devicetree/bindings/media/sunxi-ir.txt > > index 53e88ebb53fe..da5aeba843de 100644 > > --- a/Documentation/devicetree/bindings/media/sunxi-ir.txt > > +++ b/Documentation/devicetree/bindings/media/sunxi-ir.txt > > @@ -5,6 +5,7 @@ Required properties: > > "allwinner,sun4i-a10-ir" > > "allwinner,sun5i-a13-ir" > > "allwinner,sun6i-a31-ir" > > + "allwinner,sun50i-a64-ir", "allwinner,sun6i-a31-ir" > > I guess resets is mandatory for the A31 onwards too, right? Indeed, I will add this information in the device-tree bindings. Ideally, we should also introduce a quirks with a "has_reset" property. Thanks for your review, Cl=C3=A9ment > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com