LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Clément Péron" <peron.clem@gmail.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: "Colin Didier" <colin.didier@devialet.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Fabio Estevam" <fabio.estevam@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Clément Peron" <clement.peron@devialet.com>
Subject: Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT
Date: Mon, 4 Jun 2018 11:10:28 +0200	[thread overview]
Message-ID: <CAJiuCcfUq-aBL9WMmEzDpU5KKCnO0v0O_07BQnAvmkHKptcMLw@mail.gmail.com> (raw)
In-Reply-To: <f71fe02d-23a7-a475-52df-62c17089549b@mentor.com>

Hi Vladimir,

On Thu, 31 May 2018 at 10:54, Vladimir Zapolskiy
<vladimir_zapolskiy@mentor.com> wrote:
>
> Hi Clément,
>
> On 05/31/2018 11:41 AM, Clément Péron wrote:
> > Hi Vladimir,
> >
> > On Thu, 31 May 2018 at 10:33, Vladimir Zapolskiy
> > <vladimir_zapolskiy@mentor.com> wrote:
> >>
> >> On 05/30/2018 03:03 PM, Clément Péron wrote:
> >>> From: Colin Didier <colin.didier@devialet.com>
> >>>
> >>> Add missing compatible and clock properties for EPIT node.
> >>>
> >>> Signed-off-by: Colin Didier <colin.didier@devialet.com>
> >>> Signed-off-by: Clément Peron <clement.peron@devialet.com>
> >>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> >>> ---
> >>>  arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++
> >>>  1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> >>> index c003e62bf290..0feec516847a 100644
> >>> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> >>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> >>> @@ -844,13 +844,23 @@
> >>>                       };
> >>>
> >>>                       epit1: epit@20d0000 { /* EPIT1 */
> >>
> >> epit1: timer@20d0000 { ...
> >>
> >> And /* EPIT1 */ comment can be removed, it is quite clear from the same
> >> line context.
> >>
> >> Formally it is a subject to another patch, but I think this can be
> >> accepted as a part of this one.
> >
> > Should I also update other boards ?
> > I only did it for imx6qdl.dtsi, but the EPIT is present in other boards
> > but i can't test it myself.
> >
>
> Sure, please do it, why not, it is quite a safe modification.
>
> One change per one dtsi file will suffice, and I see that imx25.dtsi
> already contains the requested change, however probably you may
> want to update its compatible = "fsl,imx25-epit" line.
>
> Regarding compatibles for other imx6* SoCs, I think all of them should
> be documented in fsl,imxepit.txt and then added to the correspondent
> dtsi files one per SoC.

Nvidia UART doc did this :
        - For other Tegra, must contain '"nvidia,<chip>-uart",
          "nvidia,tegra20-uart"' where <chip> is tegra30, tegra114, tegra124,

I will follow this.

>
> And I forgot the outcome of one former discussion with Uwe Kleine-König,
> but if my bad memory serves me, we agreed that i.MX25 was released later
> than i.MX31, so the most generic (the last value in the list) compatible
> should be a compatible with i.MX31 like in
>
>         imx25.dtsi:367: compatible = "fsl,imx25-gpt", "fsl,imx31-gpt";
>
> --
> With best wishes,
> Vladimir

Regards,
Clement

      reply	other threads:[~2018-06-04  9:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 12:03 [PATCH v4 0/5] Reintroduce i.MX EPIT Timer Clément Péron
2018-05-30 12:03 ` [PATCH v4 1/5] ARM: imx: remove inexistant EPIT timer init Clément Péron
2018-05-30 12:03 ` [PATCH v4 2/5] clk: imx6: add EPIT clock support Clément Péron
2018-05-31  3:07   ` Rob Herring
2018-05-30 12:03 ` [PATCH v4 3/5] Documentation: DT: add i.MX EPIT timer binding Clément Péron
2018-05-31  3:10   ` Rob Herring
2018-05-31  8:26   ` Vladimir Zapolskiy
2018-05-30 12:03 ` [PATCH v4 4/5] clocksource: add driver for i.MX EPIT timer Clément Péron
2018-05-31  8:36   ` Vladimir Zapolskiy
2018-06-04  9:21     ` Clément Péron
2018-05-30 12:03 ` [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT Clément Péron
2018-05-31  8:33   ` Vladimir Zapolskiy
2018-05-31  8:41     ` Clément Péron
2018-05-31  8:54       ` Vladimir Zapolskiy
2018-06-04  9:10         ` Clément Péron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJiuCcfUq-aBL9WMmEzDpU5KKCnO0v0O_07BQnAvmkHKptcMLw@mail.gmail.com \
    --to=peron.clem@gmail.com \
    --cc=clement.peron@devialet.com \
    --cc=colin.didier@devialet.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=tglx@linutronix.de \
    --cc=vladimir_zapolskiy@mentor.com \
    --subject='Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).