From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbeFDJKn (ORCPT ); Mon, 4 Jun 2018 05:10:43 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:37038 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbeFDJKl (ORCPT ); Mon, 4 Jun 2018 05:10:41 -0400 X-Google-Smtp-Source: ADUXVKIuCLbrclcB1M4WjzGd7f+9ZNk3OmWvzhjUut++sRvFZCfYw6/oBMvtdA/mkeQESuU6CPnLmumitLnrM3+0NzU= MIME-Version: 1.0 References: <20180530120327.27681-1-peron.clem@gmail.com> <20180530120327.27681-6-peron.clem@gmail.com> In-Reply-To: From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 4 Jun 2018 11:10:28 +0200 Message-ID: Subject: Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT To: Vladimir Zapolskiy Cc: Colin Didier , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Lezcano , Thomas Gleixner , Fabio Estevam , Sascha Hauer , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , =?UTF-8?Q?Cl=C3=A9ment_Peron?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w549AnKL032393 Hi Vladimir, On Thu, 31 May 2018 at 10:54, Vladimir Zapolskiy wrote: > > Hi Clément, > > On 05/31/2018 11:41 AM, Clément Péron wrote: > > Hi Vladimir, > > > > On Thu, 31 May 2018 at 10:33, Vladimir Zapolskiy > > wrote: > >> > >> On 05/30/2018 03:03 PM, Clément Péron wrote: > >>> From: Colin Didier > >>> > >>> Add missing compatible and clock properties for EPIT node. > >>> > >>> Signed-off-by: Colin Didier > >>> Signed-off-by: Clément Peron > >>> Reviewed-by: Fabio Estevam > >>> --- > >>> arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++ > >>> 1 file changed, 10 insertions(+) > >>> > >>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > >>> index c003e62bf290..0feec516847a 100644 > >>> --- a/arch/arm/boot/dts/imx6qdl.dtsi > >>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi > >>> @@ -844,13 +844,23 @@ > >>> }; > >>> > >>> epit1: epit@20d0000 { /* EPIT1 */ > >> > >> epit1: timer@20d0000 { ... > >> > >> And /* EPIT1 */ comment can be removed, it is quite clear from the same > >> line context. > >> > >> Formally it is a subject to another patch, but I think this can be > >> accepted as a part of this one. > > > > Should I also update other boards ? > > I only did it for imx6qdl.dtsi, but the EPIT is present in other boards > > but i can't test it myself. > > > > Sure, please do it, why not, it is quite a safe modification. > > One change per one dtsi file will suffice, and I see that imx25.dtsi > already contains the requested change, however probably you may > want to update its compatible = "fsl,imx25-epit" line. > > Regarding compatibles for other imx6* SoCs, I think all of them should > be documented in fsl,imxepit.txt and then added to the correspondent > dtsi files one per SoC. Nvidia UART doc did this : - For other Tegra, must contain '"nvidia,-uart", "nvidia,tegra20-uart"' where is tegra30, tegra114, tegra124, I will follow this. > > And I forgot the outcome of one former discussion with Uwe Kleine-König, > but if my bad memory serves me, we agreed that i.MX25 was released later > than i.MX31, so the most generic (the last value in the list) compatible > should be a compatible with i.MX31 like in > > imx25.dtsi:367: compatible = "fsl,imx25-gpt", "fsl,imx31-gpt"; > > -- > With best wishes, > Vladimir Regards, Clement