LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Safonov <0x7f454c46@gmail.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Dmitry Safonov <dima@arista.com>,
	open list <linux-kernel@vger.kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	iommu@lists.linux-foundation.org
Subject: Re: [PATCHv3] iommu/intel: Ratelimit each dmar fault printing
Date: Thu, 29 Mar 2018 14:52:41 +0100	[thread overview]
Message-ID: <CAJwJo6aav1Ggsat2o9H8HL0bjTzTcjtwKPL5EU0iJQo6v5-WQA@mail.gmail.com> (raw)
In-Reply-To: <20180329085017.tkdtx77u4khiuqhw@8bytes.org>

2018-03-29 9:50 GMT+01:00 Joerg Roedel <joro@8bytes.org>:
> On Tue, Mar 20, 2018 at 08:50:13PM +0000, Dmitry Safonov wrote:
>> Hmm, but this fixes my softlockup issue, because it's about time spent
>> in printk() inside irq-disabled section, rather about exiting the dmar-
>> clearing loop.
>> And on my hw doesn't make any difference to limit loop or not because
>> clearing a fault is much faster than hw could generate a new fault.
>> ITOW, it fixes the softlockup for me and the loop-related lockup can't
>> happen on hw I have (so it's the other issue, [possible?] on other hw).
>
> It might solve your issue, but someone else might still run into it with
> a different setup. An upstream fix needs to solve it for everyone.

Ok, I'll resend v4 with an additional patch to limit the loop.

Thanks,
             Dmitry

      reply	other threads:[~2018-03-29 13:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 19:17 Dmitry Safonov
2018-03-05 15:00 ` Dmitry Safonov
2018-03-13 16:21   ` Dmitry Safonov
2018-03-15 13:46 ` Joerg Roedel
2018-03-15 14:13   ` Dmitry Safonov
2018-03-15 14:22     ` Joerg Roedel
2018-03-15 14:34       ` Dmitry Safonov
2018-03-15 14:42         ` Dmitry Safonov
2018-03-15 15:28           ` Joerg Roedel
2018-03-15 15:54             ` Dmitry Safonov
2018-03-20 20:50             ` Dmitry Safonov
2018-03-29  8:50               ` Joerg Roedel
2018-03-29 13:52                 ` Dmitry Safonov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJwJo6aav1Ggsat2o9H8HL0bjTzTcjtwKPL5EU0iJQo6v5-WQA@mail.gmail.com \
    --to=0x7f454c46@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dima@arista.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --subject='Re: [PATCHv3] iommu/intel: Ratelimit each dmar fault printing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).