LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vaishali Thakkar <vthakkar1994@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Daniel Vetter" <daniel@ffwll.ch>,
	alexander.deucher@amd.com, linux-renesas-soc@vger.kernel.org,
	alexandre.belloni@bootlin.com, "Heiko Stuebner" <heiko@sntech.de>,
	airlied@linux.ie, "Linus Walleij" <linus.walleij@linaro.org>,
	stefan@agner.ch, hjc@rock-chips.com, kraxel@redhat.com,
	"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	nouveau@lists.freedesktop.org, "Marek Vašut" <marex@denx.de>,
	David1.Zhou@amd.com, linux-samsung-soc@vger.kernel.org,
	jy0922.shim@samsung.com, linux-rockchip@lists.infradead.org,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	linux@armlinux.org.uk, krzk@kernel.org, jonathanh@nvidia.com,
	z.liuxinliang@hisilicon.com, maxime.ripard@bootlin.com,
	kong.kongxinwei@hisilicon.com, "Kukjin Kim" <kgene@kernel.org>,
	bskeggs@redhat.com, linux-arm-msm@vger.kernel.org,
	"CK HU" <ck.hu@mediatek.com>,
	airlied@redhat.com, virtualization@lists.linux-foundation.org,
	linux-tegra@vger.kernel.org, puck.chen@hisilicon.com,
	intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org,
	brodkin@synopsys.com, dri-devel@lists.freedesktop.org,
	rodrigo.vivi@intel.com,
	"Matthias Brugger" <matthias.bgg@gmail.com>, wen <s@csie.org>,
	vincent.abriou@st.com, linux-arm-kernel@lists.infradead.org,
	inki.dae@samsung.com, amd-gfx@lists.freedesktop.org,
	alison.wang@freescale.com, freedreno@lists.freedesktop.org,
	sw0312.kim@samsung.com, nicolas.ferre@microchip.com,
	"Philippe Cornu" <philippe.cornu@st.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	yannick.fertre@st.com,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	p.zabel@pengutronix.de, "Zou Rongrong" <zourongrong@gmail.com>,
	linux-mediatek@lists.infradead.org, shawnguo@kernel.org,
	christian.koenig@amd.com, l.stach@pengutronix.de
Subject: Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses
Date: Thu, 26 Apr 2018 18:27:18 +0530	[thread overview]
Message-ID: <CAK-LDbKxTS-13yC4CQH+fQxTM6_Dw85ftyj7sLHf3yooJwPXOA@mail.gmail.com> (raw)
In-Reply-To: <1556510.Xu6NnhyFGZ@avalon>

On Thu, Apr 26, 2018 at 6:15 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Daniel,
>
> On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote:
>> On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote:
>> > It's been a while since we introduced drm_dev{get/put} functions
>> > to replace reference/unreference in drm subsystem for the
>> > consistency purpose. So, with this patch, let's just replace
>> > all current use cases of drm_dev_unref() with drm_dev_put and remove
>> > the function itself.
>> >
>> > Coccinelle was used for mass-patching.
>> >
>> > Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
>>
>> Thanks for doing this. Unfortunately drm moves pretty fast, so already a
>> conflict when I tried to apply this. Some drivers are also in their own
>> trees, so this might lead to more fun :-/
>>
>> Can you pls split it up per-driver (just the directories under
>> drivers/gpu/drm/ is enough)? Final patch to remove the function might then
>> get stalled a bit ofc.
>
> I requested a single patch instead of splitting it per driver, you might want
> to blame me for that.
>
>> Also can you pls update ./scripts/coccinelle/api/drm-get-put.cocci and
>> remove that spatch hunk in the final patch, since we no longer need it?
>
> How about just rerunning the coccinelle patch when it's time to apply this ?
> There's precedent for performing such automated changes, and it would ensure
> that no driver is left out.

I was planning to send patches to remove all remaining reference/unreference
functions by the weekend [as there aren't much remaining now and I see that
new drivers keeps adding them instead of new API]. So, wanted to delete whole
cocci file after that. I thought of dividing a patch per function because
Laurent requested to send a single patch for all files.

But if we are going to split it per driver under gpu/drm, would it work if per
driver patch contains all function cases? Also, would you be fine with taking a
patch for removal of coccinelle file via your tree? Then I can include that in
the same patchset as well.

Thanks!

>> > ---
>> >
>> >  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c            |  4 ++--
>> >  drivers/gpu/drm/arc/arcpgu_drv.c                   |  4 ++--
>> >  drivers/gpu/drm/armada/armada_drv.c                |  6 +++---
>> >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c       |  4 ++--
>> >  drivers/gpu/drm/drm_drv.c                          | 13 -------------
>> >  drivers/gpu/drm/etnaviv/etnaviv_drv.c              |  4 ++--
>> >  drivers/gpu/drm/exynos/exynos_drm_drv.c            |  4 ++--
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c          |  4 ++--
>> >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c    |  4 ++--
>> >  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c    |  8 ++++----
>> >  drivers/gpu/drm/i915/selftests/huge_pages.c        |  2 +-
>> >  drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c   |  2 +-
>> >  drivers/gpu/drm/i915/selftests/i915_gem_evict.c    |  2 +-
>> >  drivers/gpu/drm/i915/selftests/i915_gem_gtt.c      |  2 +-
>> >  drivers/gpu/drm/i915/selftests/i915_gem_object.c   |  2 +-
>> >  drivers/gpu/drm/i915/selftests/i915_request.c      |  2 +-
>> >  drivers/gpu/drm/i915/selftests/i915_vma.c          |  2 +-
>> >  drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c |  2 +-
>> >  drivers/gpu/drm/imx/imx-drm-core.c                 |  4 ++--
>> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c             |  6 +++---
>> >  drivers/gpu/drm/msm/msm_drv.c                      |  8 ++++----
>> >  drivers/gpu/drm/mxsfb/mxsfb_drv.c                  |  4 ++--
>> >  drivers/gpu/drm/nouveau/nouveau_platform.c         |  2 +-
>> >  drivers/gpu/drm/omapdrm/omap_drv.c                 |  4 ++--
>> >  drivers/gpu/drm/pl111/pl111_drv.c                  |  4 ++--
>> >  drivers/gpu/drm/qxl/qxl_drv.c                      |  2 +-
>> >  drivers/gpu/drm/rcar-du/rcar_du_drv.c              |  2 +-
>> >  drivers/gpu/drm/rockchip/rockchip_drm_drv.c        |  4 ++--
>> >  drivers/gpu/drm/shmobile/shmob_drm_drv.c           |  4 ++--
>> >  drivers/gpu/drm/sti/sti_drv.c                      |  8 ++++----
>> >  drivers/gpu/drm/stm/drv.c                          |  4 ++--
>> >  drivers/gpu/drm/sun4i/sun4i_drv.c                  |  4 ++--
>> >  drivers/gpu/drm/tegra/drm.c                        |  4 ++--
>> >  drivers/gpu/drm/tinydrm/core/tinydrm-core.c        |  6 +++---
>> >  drivers/gpu/drm/tve200/tve200_drv.c                |  4 ++--
>> >  drivers/gpu/drm/udl/udl_drv.c                      |  2 +-
>> >  drivers/gpu/drm/vc4/vc4_drv.c                      |  4 ++--
>> >  drivers/gpu/drm/vgem/vgem_drv.c                    |  2 +-
>> >  drivers/gpu/drm/virtio/virtgpu_drm_bus.c           |  2 +-
>> >  drivers/gpu/drm/zte/zx_drm_drv.c                   |  4 ++--
>> >  include/drm/drm_drv.h                              |  1 -
>> >  41 files changed, 73 insertions(+), 87 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>



-- 
Vaishali
http://vaishalithakkar.in/

  parent reply	other threads:[~2018-04-26 12:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 10:28 Vaishali Thakkar
2018-04-26 10:43 ` Laurent Pinchart
2018-04-26 12:06 ` Thierry Reding
2018-04-26 12:15 ` Boris Brezillon
2018-04-26 12:36 ` [Intel-gfx] " Daniel Vetter
     [not found]   ` <1556510.Xu6NnhyFGZ@avalon>
2018-04-26 12:57     ` Vaishali Thakkar [this message]
2018-04-26 13:14     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK-LDbKxTS-13yC4CQH+fQxTM6_Dw85ftyj7sLHf3yooJwPXOA@mail.gmail.com \
    --to=vthakkar1994@gmail.com \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alison.wang@freescale.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=benjamin.gaignard@linaro.org \
    --cc=brodkin@synopsys.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=inki.dae@samsung.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=kraxel@redhat.com \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=l.stach@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marex@denx.de \
    --cc=matthias.bgg@gmail.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=noralf@tronnes.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=p.zabel@pengutronix.de \
    --cc=philippe.cornu@st.com \
    --cc=puck.chen@hisilicon.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=s@csie.org \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    --cc=sw0312.kim@samsung.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=vincent.abriou@st.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yannick.fertre@st.com \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    --subject='Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it'\''s uses' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).