From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754432AbbANSnW (ORCPT ); Wed, 14 Jan 2015 13:43:22 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:33902 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753988AbbANSnU (ORCPT ); Wed, 14 Jan 2015 13:43:20 -0500 MIME-Version: 1.0 In-Reply-To: <1421243519-6257-3-git-send-email-geert+renesas@glider.be> References: <1421243519-6257-1-git-send-email-geert+renesas@glider.be> <1421243519-6257-3-git-send-email-geert+renesas@glider.be> From: Bryan Wu Date: Wed, 14 Jan 2015 10:42:59 -0800 Message-ID: Subject: Re: [PATCH 2/3] leds: leds-mc13783: Use of_get_child_by_name() instead of refcount hack To: Geert Uytterhoeven Cc: Benjamin Herrenschmidt , Richard Purdie , Jingoo Han , Lee Jones , "devicetree@vger.kernel.org" , lkml , Linux LED Subsystem Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 14, 2015 at 5:51 AM, Geert Uytterhoeven wrote: > of_find_node_by_name() calls of_node_put() on its "from" parameter. > To counter this, mc13xxx_led_probe_dt() calls of_node_get() first. > > Use of_get_child_by_name() instead to get rid of the refcount hack. > > Signed-off-by: Geert Uytterhoeven > Cc: linux-leds@vger.kernel.org Looks good, applied to my tree. Thanks, -Bryan > --- > Compile-tested only > --- > drivers/leds/leds-mc13783.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c > index 85c3714e1b5aabba..e2b847fe22a1c934 100644 > --- a/drivers/leds/leds-mc13783.c > +++ b/drivers/leds/leds-mc13783.c > @@ -134,9 +134,7 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt( > if (!pdata) > return ERR_PTR(-ENOMEM); > > - of_node_get(dev->parent->of_node); > - > - parent = of_find_node_by_name(dev->parent->of_node, "leds"); > + parent = of_get_child_by_name(dev->parent->of_node, "leds"); > if (!parent) > goto out_node_put; > > -- > 1.9.1 >