LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	"open list:SIFIVE DRIVERS" <linux-riscv@lists.infradead.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Tobias Klauser <tklauser@distanz.ch>,
	vitaly.wool@konsulko.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: move the (z)install rules to arch/riscv/Makefile
Date: Sun, 15 Aug 2021 08:49:14 +0900	[thread overview]
Message-ID: <CAK7LNARVjdVf5QRFduKrxb-TJyiCdUPkpSSMtYiS7yN2yAZhEQ@mail.gmail.com> (raw)
In-Reply-To: <mhng-fe558e10-6cee-4e55-b975-8c525c2bcb02@palmerdabbelt-glaptop>

On Sat, Aug 14, 2021 at 2:00 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Thu, 29 Jul 2021 07:21:47 PDT (-0700), masahiroy@kernel.org wrote:
> > Currently, the (z)install targets in arch/riscv/Makefile descend into
> > arch/riscv/boot/Makefile to invoke the shell script, but there is no
> > good reason to do so.
> >
> > arch/riscv/Makefile can run the shell script directly.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  arch/riscv/Makefile      | 7 +++++--
> >  arch/riscv/boot/Makefile | 8 --------
> >  2 files changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> > index bc74afdbf31e..3c437fb09a07 100644
> > --- a/arch/riscv/Makefile
> > +++ b/arch/riscv/Makefile
> > @@ -126,8 +126,11 @@ $(BOOT_TARGETS): vmlinux
> >  Image.%: Image
> >       $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
> >
> > -zinstall install:
> > -     $(Q)$(MAKE) $(build)=$(boot) $@
> > +install: install-image = Image
> > +zinstall: install-image = Image.gz
> > +install zinstall:
> > +     $(CONFIG_SHELL) $(srctree)/$(boot)/install.sh $(KERNELRELEASE) \
> > +     $(boot)/$(install-image) System.map "$(INSTALL_PATH)"
> >
> >  archclean:
> >       $(Q)$(MAKE) $(clean)=$(boot)
> > diff --git a/arch/riscv/boot/Makefile b/arch/riscv/boot/Makefile
> > index 6bf299f70c27..becd0621071c 100644
> > --- a/arch/riscv/boot/Makefile
> > +++ b/arch/riscv/boot/Makefile
> > @@ -58,11 +58,3 @@ $(obj)/Image.lzo: $(obj)/Image FORCE
> >
> >  $(obj)/loader.bin: $(obj)/loader FORCE
> >       $(call if_changed,objcopy)
> > -
> > -install:
> > -     $(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
> > -     $(obj)/Image System.map "$(INSTALL_PATH)"
> > -
> > -zinstall:
> > -     $(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
> > -     $(obj)/Image.gz System.map "$(INSTALL_PATH)"
>
> Admittidly I don't see a reason to do it this way either, but it looks
> like the other common ports (I checked arm64 and x86) are doing things
> this way.  I don't really care that much about which way we do it, but
> it'd be better to keep everyone aligned.
>
> Are you converting the other ports over as well?

Yes.


-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2021-08-14 23:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 14:21 Masahiro Yamada
2021-08-14  5:00 ` Palmer Dabbelt
2021-08-14 23:49   ` Masahiro Yamada [this message]
2021-09-11  6:46     ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNARVjdVf5QRFduKrxb-TJyiCdUPkpSSMtYiS7yN2yAZhEQ@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=tklauser@distanz.ch \
    --cc=vitaly.wool@konsulko.com \
    --cc=wangkefeng.wang@huawei.com \
    --subject='Re: [PATCH] riscv: move the (z)install rules to arch/riscv/Makefile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).