LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: Joel Stanley <joel@jms.id.au>,
	Michal Marek <michal.lkml@markovi.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: terminate Kconfig when $(CC) or $(LD) is missing
Date: Mon, 13 May 2019 11:27:26 +0900	[thread overview]
Message-ID: <CAK7LNARotATDnShT-80Ect9XvSM98wYEbQRKHdUTuQBtvxG8aw@mail.gmail.com> (raw)
In-Reply-To: <20190509073555.15545-1-yamada.masahiro@socionext.com>

On Thu, May 9, 2019 at 4:36 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> If the compiler specified by $(CC) is not present, the Kconfig stage
> sprinkles 'not found' messages, then succeeds.
>
>   $ make CROSS_COMPILE=foo defconfig
>   /bin/sh: 1: foogcc: not found
>   /bin/sh: 1: foogcc: not found
>   *** Default configuration is based on 'x86_64_defconfig'
>   ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found
>   ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found
>   ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found
>   ./scripts/gcc-version.sh: 17: ./scripts/gcc-version.sh: foogcc: not found
>   ./scripts/gcc-version.sh: 18: ./scripts/gcc-version.sh: foogcc: not found
>   ./scripts/gcc-version.sh: 19: ./scripts/gcc-version.sh: foogcc: not found
>   ./scripts/clang-version.sh: 11: ./scripts/clang-version.sh: foogcc: not found
>   ./scripts/gcc-plugin.sh: 11: ./scripts/gcc-plugin.sh: foogcc: not found
>   init/Kconfig:16:warning: 'GCC_VERSION': number is invalid
>   #
>   # configuration written to .config
>   #
>
> Terminate parsing files immediately if $(CC) or $(LD) is not found.
> "make *config" will fail more nicely.
>
>   $ make CROSS_COMPILE=foo defconfig
>   *** Default configuration is based on 'x86_64_defconfig'
>   scripts/Kconfig.include:34: compiler 'foogcc' not found
>   make[1]: *** [scripts/kconfig/Makefile;82: defconfig] Error 1
>   make: *** [Makefile;557: defconfig] Error 2
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Applied to linux-kbuild.


>  Makefile                | 2 +-
>  scripts/Kconfig.include | 8 ++++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 28965187c528..bd7ae11947cb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -537,7 +537,7 @@ endif
>  # Some architectures define CROSS_COMPILE in arch/$(SRCARCH)/Makefile.
>  # CC_VERSION_TEXT is referenced from Kconfig (so it needs export),
>  # and from include/config/auto.conf.cmd to detect the compiler upgrade.
> -CC_VERSION_TEXT = $(shell $(CC) --version | head -n 1)
> +CC_VERSION_TEXT = $(shell $(CC) --version 2>/dev/null | head -n 1)
>
>  ifeq ($(config-targets),1)
>  # ===========================================================================
> diff --git a/scripts/Kconfig.include b/scripts/Kconfig.include
> index 87ff1dcc6bd5..0b267fb27f07 100644
> --- a/scripts/Kconfig.include
> +++ b/scripts/Kconfig.include
> @@ -18,6 +18,10 @@ if-success = $(shell,{ $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)")
>  # Return y if <command> exits with 0, n otherwise
>  success = $(if-success,$(1),y,n)
>
> +# $(failure,<command>)
> +# Return n if <command> exits with 0, y otherwise
> +failure = $(if-success,$(1),n,y)
> +
>  # $(cc-option,<flag>)
>  # Return y if the compiler supports <flag>, n otherwise
>  cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null)
> @@ -26,5 +30,9 @@ cc-option = $(success,$(CC) -Werror $(1) -E -x c /dev/null -o /dev/null)
>  # Return y if the linker supports <flag>, n otherwise
>  ld-option = $(success,$(LD) -v $(1))
>
> +# check if $(CC) and $(LD) exist
> +$(error-if,$(failure,command -v $(CC)),compiler '$(CC)' not found)
> +$(error-if,$(failure,command -v $(LD)),linker '$(LD)' not found)
> +
>  # gcc version including patch level
>  gcc-version := $(shell,$(srctree)/scripts/gcc-version.sh $(CC))
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada

  reply	other threads:[~2019-05-13  2:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  7:35 Masahiro Yamada
2019-05-13  2:27 ` Masahiro Yamada [this message]
2019-05-13  2:35   ` Joel Stanley
2019-05-13  2:49     ` Masahiro Yamada
2019-05-13  4:07       ` Joel Stanley
2019-05-13  4:47 ` Nathan Chancellor
2019-05-14  2:54   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNARotATDnShT-80Ect9XvSM98wYEbQRKHdUTuQBtvxG8aw@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=joel@jms.id.au \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --subject='Re: [PATCH] kbuild: terminate Kconfig when $(CC) or $(LD) is missing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).