LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH] kbuild: remove unused cc-fullversion variable
Date: Wed, 31 Oct 2018 01:00:55 +0900	[thread overview]
Message-ID: <CAK7LNASEogAqYTZHdtPWk4xZPXKkJPuWX9BF3o_Cy5s0jCB2cg@mail.gmail.com> (raw)
In-Reply-To: <1540829034-17725-1-git-send-email-yamada.masahiro@socionext.com>

On Tue, Oct 30, 2018 at 1:05 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> The last user of cc-fullversion was removed by commit f2910f0e6835
> ("powerpc: remove old GCC version checks").
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Applied to linux-kbuild.




>  Documentation/kbuild/makefiles.txt | 15 ---------------
>  scripts/Kbuild.include             |  4 ----
>  2 files changed, 19 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
> index 7b6a2b2..8da26c6 100644
> --- a/Documentation/kbuild/makefiles.txt
> +++ b/Documentation/kbuild/makefiles.txt
> @@ -537,21 +537,6 @@ more details, with real examples.
>         The third parameter may be a text as in this example, but it may also
>         be an expanded variable or a macro.
>
> -    cc-fullversion
> -       cc-fullversion is useful when the exact version of gcc is needed.
> -       One typical use-case is when a specific GCC version is broken.
> -       cc-fullversion points out a more specific version than cc-version does.
> -
> -       Example:
> -               #arch/powerpc/Makefile
> -               $(Q)if test "$(cc-fullversion)" = "040200" ; then \
> -                       echo -n '*** GCC-4.2.0 cannot compile the 64-bit powerpc ' ; \
> -                       false ; \
> -               fi
> -
> -       In this example for a specific GCC version the build will error out
> -       explaining to the user why it stops.
> -
>      cc-cross-prefix
>         cc-cross-prefix is used to check if there exists a $(CC) in path with
>         one of the listed prefixes. The first prefix where there exist a
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index ca21a35..19a63db 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -147,10 +147,6 @@ cc-name = $(shell $(CC) -v 2>&1 | grep -q "clang version" && echo clang || echo
>  # cc-version
>  cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh $(CC))
>
> -# cc-fullversion
> -cc-fullversion = $(shell $(CONFIG_SHELL) \
> -       $(srctree)/scripts/gcc-version.sh -p $(CC))
> -
>  # cc-ifversion
>  # Usage:  EXTRA_CFLAGS += $(call cc-ifversion, -lt, 0402, -O1)
>  cc-ifversion = $(shell [ $(cc-version) $(1) $(2) ] && echo $(3) || echo $(4))
> --
> 2.7.4
>


-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2018-10-30 16:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 16:03 Masahiro Yamada
2018-10-30 16:00 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNASEogAqYTZHdtPWk4xZPXKkJPuWX9BF3o_Cy5s0jCB2cg@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --subject='Re: [PATCH] kbuild: remove unused cc-fullversion variable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).