LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sh: require --Wl,--hash-style=sysv
@ 2019-04-23 20:29 Nick Desaulniers
  2019-04-24  6:27 ` Geert Uytterhoeven
  0 siblings, 1 reply; 13+ messages in thread
From: Nick Desaulniers @ 2019-04-23 20:29 UTC (permalink / raw)
  To: ysato, dalias
  Cc: Nick Desaulniers, Andy Lutomirsky, clang-built-linux,
	Masahiro Yamada, linux-sh, linux-kernel

Towards the goal of removing cc-ldoption, prefer ld-option, or better
yet, require --Wl,--hash-style=sysv since the selftest for vdso's
requires DT_HASH.

Cc: Andy Lutomirsky <luto@kernel.org>
Cc: clang-built-linux@googlegroups.com
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 arch/sh/kernel/vsyscall/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
index 5db6579bc44c..6e8664448048 100644
--- a/arch/sh/kernel/vsyscall/Makefile
+++ b/arch/sh/kernel/vsyscall/Makefile
@@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
 
 export CPPFLAGS_vsyscall.lds += -P -C -Ush
 
-vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
-		$(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
+vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
 
 SYSCFLAGS_vsyscall-trapa.so	= $(vsyscall-flags)
 
-- 
2.21.0.593.g511ec345e18-goog


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] sh: require --Wl,--hash-style=sysv
  2019-04-23 20:29 [PATCH] sh: require --Wl,--hash-style=sysv Nick Desaulniers
@ 2019-04-24  6:27 ` Geert Uytterhoeven
  2019-04-24  6:37   ` Masahiro Yamada
  0 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2019-04-24  6:27 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: Yoshinori Sato, Rich Felker, Andy Lutomirsky, clang-built-linux,
	Masahiro Yamada, Linux-sh list, Linux Kernel Mailing List

Hi Nick,

On Tue, Apr 23, 2019 at 10:31 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
> Towards the goal of removing cc-ldoption, prefer ld-option, or better
> yet, require --Wl,--hash-style=sysv since the selftest for vdso's
> requires DT_HASH.
>
> Cc: Andy Lutomirsky <luto@kernel.org>
> Cc: clang-built-linux@googlegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks for your patch!

> --- a/arch/sh/kernel/vsyscall/Makefile
> +++ b/arch/sh/kernel/vsyscall/Makefile
> @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
>
>  export CPPFLAGS_vsyscall.lds += -P -C -Ush
>
> -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
>
>  SYSCFLAGS_vsyscall-trapa.so    = $(vsyscall-flags)

What impact does this have on the minimum binutils version needed to
compile the kernel?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] sh: require --Wl,--hash-style=sysv
  2019-04-24  6:27 ` Geert Uytterhoeven
@ 2019-04-24  6:37   ` Masahiro Yamada
  2019-04-24  6:39     ` Masahiro Yamada
  0 siblings, 1 reply; 13+ messages in thread
From: Masahiro Yamada @ 2019-04-24  6:37 UTC (permalink / raw)
  To: Geert Uytterhoeven, Nick Desaulniers
  Cc: Yoshinori Sato, Rich Felker, Andy Lutomirsky, clang-built-linux,
	Linux-sh list, Linux Kernel Mailing List

On Wed, Apr 24, 2019 at 3:29 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Nick,
>
> On Tue, Apr 23, 2019 at 10:31 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> > Towards the goal of removing cc-ldoption, prefer ld-option, or better
> > yet, require --Wl,--hash-style=sysv since the selftest for vdso's
> > requires DT_HASH.
> >
> > Cc: Andy Lutomirsky <luto@kernel.org>
> > Cc: clang-built-linux@googlegroups.com
> > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Thanks for your patch!
>
> > --- a/arch/sh/kernel/vsyscall/Makefile
> > +++ b/arch/sh/kernel/vsyscall/Makefile
> > @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
> >
> >  export CPPFLAGS_vsyscall.lds += -P -C -Ush
> >
> > -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> > -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> > +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
> >
> >  SYSCFLAGS_vsyscall-trapa.so    = $(vsyscall-flags)
>
> What impact does this have on the minimum binutils version needed to
> compile the kernel?
>


See his ia64 variant:
https://lore.kernel.org/patchwork/patch/1065347/


He commented a stronger reason
"it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006.
The minimal required version of binutils for the kernel according to
Documentation/process/changes.rst is 2.20"


Nick,
Why don't you rephrase the commit log like your ia64 one?
It will clarify this change has no impact.


BTW, I think the subject should be
"-Wl,--hash-style=sysv" instead of
"--Wl,--hash-style=sysv"

(single hash before "Wl")




--
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] sh: require --Wl,--hash-style=sysv
  2019-04-24  6:37   ` Masahiro Yamada
@ 2019-04-24  6:39     ` Masahiro Yamada
  2019-04-24 18:02       ` [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption Nick Desaulniers
  0 siblings, 1 reply; 13+ messages in thread
From: Masahiro Yamada @ 2019-04-24  6:39 UTC (permalink / raw)
  To: Geert Uytterhoeven, Nick Desaulniers
  Cc: Yoshinori Sato, Rich Felker, Andy Lutomirsky, clang-built-linux,
	Linux-sh list, Linux Kernel Mailing List

On Wed, Apr 24, 2019 at 3:37 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> On Wed, Apr 24, 2019 at 3:29 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Nick,
> >
> > On Tue, Apr 23, 2019 at 10:31 PM Nick Desaulniers
> > <ndesaulniers@google.com> wrote:
> > > Towards the goal of removing cc-ldoption, prefer ld-option, or better
> > > yet, require --Wl,--hash-style=sysv since the selftest for vdso's
> > > requires DT_HASH.
> > >
> > > Cc: Andy Lutomirsky <luto@kernel.org>
> > > Cc: clang-built-linux@googlegroups.com
> > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/sh/kernel/vsyscall/Makefile
> > > +++ b/arch/sh/kernel/vsyscall/Makefile
> > > @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
> > >
> > >  export CPPFLAGS_vsyscall.lds += -P -C -Ush
> > >
> > > -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> > > -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> > > +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
> > >
> > >  SYSCFLAGS_vsyscall-trapa.so    = $(vsyscall-flags)
> >
> > What impact does this have on the minimum binutils version needed to
> > compile the kernel?
> >
>
>
> See his ia64 variant:
> https://lore.kernel.org/patchwork/patch/1065347/
>
>
> He commented a stronger reason
> "it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006.
> The minimal required version of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20"
>
>
> Nick,
> Why don't you rephrase the commit log like your ia64 one?
> It will clarify this change has no impact.
>
>
> BTW, I think the subject should be
> "-Wl,--hash-style=sysv" instead of
> "--Wl,--hash-style=sysv"
>
> (single hash before "Wl")

I mean "single dash"
just in case.  :)




-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-04-24  6:39     ` Masahiro Yamada
@ 2019-04-24 18:02       ` Nick Desaulniers
  2019-04-30 20:26         ` Nick Desaulniers
  2019-05-12  4:29         ` Yoshinori Sato
  0 siblings, 2 replies; 13+ messages in thread
From: Nick Desaulniers @ 2019-04-24 18:02 UTC (permalink / raw)
  To: ysato, dalias
  Cc: geert, luto, Nick Desaulniers, clang-built-linux,
	Masahiro Yamada, linux-sh, linux-kernel

Towards the goal of removing cc-ldoption, it seems that --hash-style=
was added to binutils 2.17.50.0.2 in 2006. The minimal required version
of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.

Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
Cc: clang-built-linux@googlegroups.com
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
Changes V1 -> V2:
* update commit subject and message as per Masahiro/Geert.

To Geert's question about minimum binutils versions; no change needed to
binutils.


 arch/sh/kernel/vsyscall/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
index 5db6579bc44c..6e8664448048 100644
--- a/arch/sh/kernel/vsyscall/Makefile
+++ b/arch/sh/kernel/vsyscall/Makefile
@@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
 
 export CPPFLAGS_vsyscall.lds += -P -C -Ush
 
-vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
-		$(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
+vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
 
 SYSCFLAGS_vsyscall-trapa.so	= $(vsyscall-flags)
 
-- 
2.21.0.593.g511ec345e18-goog


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-04-24 18:02       ` [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption Nick Desaulniers
@ 2019-04-30 20:26         ` Nick Desaulniers
  2019-05-08 19:22           ` Nick Desaulniers
  2019-05-12  4:29         ` Yoshinori Sato
  1 sibling, 1 reply; 13+ messages in thread
From: Nick Desaulniers @ 2019-04-30 20:26 UTC (permalink / raw)
  To: Yoshinori Sato, dalias
  Cc: Geert Uytterhoeven, Andy Lutomirski, clang-built-linux,
	Masahiro Yamada, linux-sh, LKML

On Wed, Apr 24, 2019 at 11:02 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> Towards the goal of removing cc-ldoption, it seems that --hash-style=
> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
>
> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> Cc: clang-built-linux@googlegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> Changes V1 -> V2:
> * update commit subject and message as per Masahiro/Geert.
>
> To Geert's question about minimum binutils versions; no change needed to
> binutils.
>
>
>  arch/sh/kernel/vsyscall/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
> index 5db6579bc44c..6e8664448048 100644
> --- a/arch/sh/kernel/vsyscall/Makefile
> +++ b/arch/sh/kernel/vsyscall/Makefile
> @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
>
>  export CPPFLAGS_vsyscall.lds += -P -C -Ush
>
> -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
>
>  SYSCFLAGS_vsyscall-trapa.so    = $(vsyscall-flags)
>
> --
> 2.21.0.593.g511ec345e18-goog
>

bumping for review
-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-04-30 20:26         ` Nick Desaulniers
@ 2019-05-08 19:22           ` Nick Desaulniers
  2019-05-09  0:44             ` Masahiro Yamada
  0 siblings, 1 reply; 13+ messages in thread
From: Nick Desaulniers @ 2019-05-08 19:22 UTC (permalink / raw)
  To: Yoshinori Sato, dalias
  Cc: Geert Uytterhoeven, Andy Lutomirski, clang-built-linux,
	Masahiro Yamada, linux-sh, LKML

bumping for review, as the merge window is now open.

On Tue, Apr 30, 2019 at 1:26 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Wed, Apr 24, 2019 at 11:02 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > Towards the goal of removing cc-ldoption, it seems that --hash-style=
> > was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> > of binutils for the kernel according to
> > Documentation/process/changes.rst is 2.20.
> >
> > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> > Cc: clang-built-linux@googlegroups.com
> > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > ---
> > Changes V1 -> V2:
> > * update commit subject and message as per Masahiro/Geert.
> >
> > To Geert's question about minimum binutils versions; no change needed to
> > binutils.
> >
> >
> >  arch/sh/kernel/vsyscall/Makefile | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
> > index 5db6579bc44c..6e8664448048 100644
> > --- a/arch/sh/kernel/vsyscall/Makefile
> > +++ b/arch/sh/kernel/vsyscall/Makefile
> > @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
> >
> >  export CPPFLAGS_vsyscall.lds += -P -C -Ush
> >
> > -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> > -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> > +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
> >
> >  SYSCFLAGS_vsyscall-trapa.so    = $(vsyscall-flags)
> >
> > --
> > 2.21.0.593.g511ec345e18-goog
> >
>
> bumping for review
> --
> Thanks,
> ~Nick Desaulniers



-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-05-08 19:22           ` Nick Desaulniers
@ 2019-05-09  0:44             ` Masahiro Yamada
  2019-05-09  6:09               ` John Paul Adrian Glaubitz
  0 siblings, 1 reply; 13+ messages in thread
From: Masahiro Yamada @ 2019-05-09  0:44 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: Yoshinori Sato, Rich Felker, Geert Uytterhoeven, Andy Lutomirski,
	clang-built-linux, Linux-sh list, LKML

On Thu, May 9, 2019 at 5:13 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> bumping for review, as the merge window is now open.


sh is not very active these days.

I applied this to my kbuild tree.
I will send PR for this in the current MW.

Thanks.



> On Tue, Apr 30, 2019 at 1:26 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > On Wed, Apr 24, 2019 at 11:02 AM Nick Desaulniers
> > <ndesaulniers@google.com> wrote:
> > >
> > > Towards the goal of removing cc-ldoption, it seems that --hash-style=
> > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> > > of binutils for the kernel according to
> > > Documentation/process/changes.rst is 2.20.
> > >
> > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> > > Cc: clang-built-linux@googlegroups.com
> > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > > ---
> > > Changes V1 -> V2:
> > > * update commit subject and message as per Masahiro/Geert.
> > >
> > > To Geert's question about minimum binutils versions; no change needed to
> > > binutils.
> > >
> > >
> > >  arch/sh/kernel/vsyscall/Makefile | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
> > > index 5db6579bc44c..6e8664448048 100644
> > > --- a/arch/sh/kernel/vsyscall/Makefile
> > > +++ b/arch/sh/kernel/vsyscall/Makefile
> > > @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
> > >
> > >  export CPPFLAGS_vsyscall.lds += -P -C -Ush
> > >
> > > -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> > > -               $(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> > > +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
> > >
> > >  SYSCFLAGS_vsyscall-trapa.so    = $(vsyscall-flags)
> > >
> > > --
> > > 2.21.0.593.g511ec345e18-goog
> > >
> >
> > bumping for review
> > --
> > Thanks,
> > ~Nick Desaulniers
>
>
>
> --
> Thanks,
> ~Nick Desaulniers



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-05-09  0:44             ` Masahiro Yamada
@ 2019-05-09  6:09               ` John Paul Adrian Glaubitz
  2019-05-09  7:07                 ` Masahiro Yamada
  0 siblings, 1 reply; 13+ messages in thread
From: John Paul Adrian Glaubitz @ 2019-05-09  6:09 UTC (permalink / raw)
  To: Masahiro Yamada, Nick Desaulniers
  Cc: Yoshinori Sato, Rich Felker, Geert Uytterhoeven, Andy Lutomirski,
	clang-built-linux, Linux-sh list, LKML

On 5/9/19 2:44 AM, Masahiro Yamada wrote:
> On Thu, May 9, 2019 at 5:13 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>>
>> bumping for review, as the merge window is now open.
> 
> 
> sh is not very active these days.

We're still supporting SH with an up-to-date kernel and userland in Debian, so
if your patch broke something, we will notice that soonish. This also applies
to ia64 and many other architectures.

So, if in doubt, there are folks in Debian which can test your kernel patch
if you fear that it breaks something.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-05-09  6:09               ` John Paul Adrian Glaubitz
@ 2019-05-09  7:07                 ` Masahiro Yamada
  2019-05-09  8:44                   ` John Paul Adrian Glaubitz
  0 siblings, 1 reply; 13+ messages in thread
From: Masahiro Yamada @ 2019-05-09  7:07 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz
  Cc: Nick Desaulniers, Yoshinori Sato, Rich Felker,
	Geert Uytterhoeven, Andy Lutomirski, clang-built-linux,
	Linux-sh list, LKML

On Thu, May 9, 2019 at 3:11 PM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> On 5/9/19 2:44 AM, Masahiro Yamada wrote:
> > On Thu, May 9, 2019 at 5:13 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
> >>
> >> bumping for review, as the merge window is now open.
> >
> >
> > sh is not very active these days.
>
> We're still supporting SH with an up-to-date kernel and userland in Debian, so
> if your patch broke something, we will notice that soonish. This also applies
> to ia64 and many other architectures.
>
> So, if in doubt, there are folks in Debian which can test your kernel patch
> if you fear that it breaks something.

Thanks for taking care of them in Debian.

I am talking about the sh sub-system in the kernel here.

SH patches occasionally fly around in LKML, but
the SH maintainers are not picking up them these days.

This one is trivial from the build system point of view.
So, I offer to apply it to my tree.

Thanks.




> Adrian
>
> --
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz@debian.org
> `. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-05-09  7:07                 ` Masahiro Yamada
@ 2019-05-09  8:44                   ` John Paul Adrian Glaubitz
  2019-05-12  4:31                     ` Yoshinori Sato
  0 siblings, 1 reply; 13+ messages in thread
From: John Paul Adrian Glaubitz @ 2019-05-09  8:44 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Nick Desaulniers, Yoshinori Sato, Rich Felker,
	Geert Uytterhoeven, Andy Lutomirski, clang-built-linux,
	Linux-sh list, LKML

Hi Masahiro!

On 5/9/19 9:07 AM, Masahiro Yamada wrote:
>> So, if in doubt, there are folks in Debian which can test your kernel patch
>> if you fear that it breaks something.
> 
> Thanks for taking care of them in Debian.
> 
> I am talking about the sh sub-system in the kernel here.

Yes, I'm aware of that :).

> SH patches occasionally fly around in LKML, but
> the SH maintainers are not picking up them these days.

Rich was normally the one maintaining the SH tree and collecting the patches,
not sure whether he is still active. It's been a while since he sent Linus
a pull request.

Sato-san was recently a patch himself, but I think he doesn't have a tree
himself.

@Sato: Could you have a look at the patch and ack it if it's okay?

> This one is trivial from the build system point of view.
> So, I offer to apply it to my tree.

I'm fine with that. If you need to test build the kernel for SH, Debian
has an easily installable cross-compiler for SH and every other architecture
except ia64 (working on fixing that) available.

In any case, thanks for taking care of SH in this case.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-04-24 18:02       ` [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption Nick Desaulniers
  2019-04-30 20:26         ` Nick Desaulniers
@ 2019-05-12  4:29         ` Yoshinori Sato
  1 sibling, 0 replies; 13+ messages in thread
From: Yoshinori Sato @ 2019-05-12  4:29 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: dalias, geert, luto, clang-built-linux, Masahiro Yamada,
	linux-sh, linux-kernel

On Thu, 25 Apr 2019 03:02:21 +0900,
Nick Desaulniers wrote:
> 
> Towards the goal of removing cc-ldoption, it seems that --hash-style=
> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
> 
> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
> Cc: clang-built-linux@googlegroups.com
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>

> ---
> Changes V1 -> V2:
> * update commit subject and message as per Masahiro/Geert.
> 
> To Geert's question about minimum binutils versions; no change needed to
> binutils.
> 
> 
>  arch/sh/kernel/vsyscall/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/sh/kernel/vsyscall/Makefile b/arch/sh/kernel/vsyscall/Makefile
> index 5db6579bc44c..6e8664448048 100644
> --- a/arch/sh/kernel/vsyscall/Makefile
> +++ b/arch/sh/kernel/vsyscall/Makefile
> @@ -15,8 +15,7 @@ quiet_cmd_syscall = SYSCALL $@
>  
>  export CPPFLAGS_vsyscall.lds += -P -C -Ush
>  
> -vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 \
> -		$(call cc-ldoption, -Wl$(comma)--hash-style=sysv)
> +vsyscall-flags = -shared -s -Wl,-soname=linux-gate.so.1 -Wl,--hash-style=sysv
>  
>  SYSCFLAGS_vsyscall-trapa.so	= $(vsyscall-flags)
>  
> -- 
> 2.21.0.593.g511ec345e18-goog
> 

-- 
Yosinori Sato

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption
  2019-05-09  8:44                   ` John Paul Adrian Glaubitz
@ 2019-05-12  4:31                     ` Yoshinori Sato
  0 siblings, 0 replies; 13+ messages in thread
From: Yoshinori Sato @ 2019-05-12  4:31 UTC (permalink / raw)
  To: John Paul Adrian Glaubitz
  Cc: Masahiro Yamada, Nick Desaulniers, Rich Felker,
	Geert Uytterhoeven, Andy Lutomirski, clang-built-linux,
	Linux-sh list, LKML

On Thu, 09 May 2019 17:44:45 +0900,
John Paul Adrian Glaubitz wrote:
> 
> Hi Masahiro!
> 
> On 5/9/19 9:07 AM, Masahiro Yamada wrote:
> >> So, if in doubt, there are folks in Debian which can test your kernel patch
> >> if you fear that it breaks something.
> > 
> > Thanks for taking care of them in Debian.
> > 
> > I am talking about the sh sub-system in the kernel here.
> 
> Yes, I'm aware of that :).
> 
> > SH patches occasionally fly around in LKML, but
> > the SH maintainers are not picking up them these days.
> 
> Rich was normally the one maintaining the SH tree and collecting the patches,
> not sure whether he is still active. It's been a while since he sent Linus
> a pull request.
> 
> Sato-san was recently a patch himself, but I think he doesn't have a tree
> himself.
> 
> @Sato: Could you have a look at the patch and ack it if it's okay?

I sent ack now.
Sorry too late reply.

> > This one is trivial from the build system point of view.
> > So, I offer to apply it to my tree.
> 
> I'm fine with that. If you need to test build the kernel for SH, Debian
> has an easily installable cross-compiler for SH and every other architecture
> except ia64 (working on fixing that) available.
> 
> In any case, thanks for taking care of SH in this case.
> 
> Adrian
> 
> -- 
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz@debian.org
> `. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

-- 
Yosinori Sato

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-05-12  4:31 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 20:29 [PATCH] sh: require --Wl,--hash-style=sysv Nick Desaulniers
2019-04-24  6:27 ` Geert Uytterhoeven
2019-04-24  6:37   ` Masahiro Yamada
2019-04-24  6:39     ` Masahiro Yamada
2019-04-24 18:02       ` [PATCH v2] sh: vsyscall: drop unnecessary cc-ldoption Nick Desaulniers
2019-04-30 20:26         ` Nick Desaulniers
2019-05-08 19:22           ` Nick Desaulniers
2019-05-09  0:44             ` Masahiro Yamada
2019-05-09  6:09               ` John Paul Adrian Glaubitz
2019-05-09  7:07                 ` Masahiro Yamada
2019-05-09  8:44                   ` John Paul Adrian Glaubitz
2019-05-12  4:31                     ` Yoshinori Sato
2019-05-12  4:29         ` Yoshinori Sato

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).