LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Changbin Du <changbin.du@gmail.com>
Subject: Re: linux-next: Tree for Oct 31 (vboxguest)
Date: Thu, 1 Nov 2018 12:32:48 +0900	[thread overview]
Message-ID: <CAK7LNATirQwke8tqk5XukhkwKra6mWEXZ3AHcywNcwGFD2-voA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3aygFrD3PyZ8P==JzeYamE-x--MWCL54xzXDE_8u_R6Q@mail.gmail.com>

Hi Arnd,


On Thu, Nov 1, 2018 at 6:42 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On 10/31/18, Randy Dunlap <rdunlap@infradead.org> wrote:
> > On 10/30/18 8:59 PM, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Please do not add any v4.21/v5.1 code to your linux-next included trees
> >> until after the merge window closes.
> >>
> >> Changes since 20181030:
> >>
> >
> >
> > on i386:
> >
> > ld: drivers/virt/vboxguest/vboxguest_core.o: in function
> > `vbg_ioctl_hgcm_call':
> > vboxguest_core.c:(.text+0x212b): undefined reference to `vbg_hgcm_call32'
> >
> >
> > Full randconfig file is attached.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
>
> I ran into the same thing, and lots of others like it; they all go back to
> the -Og compiler option introduced in commit 94c7dfd01652 ("kernel
> hacking: support building kernel with -Og optimization level").
>
>
> I have patches for most of these, but I'd prefer if we could leave
> that patch out of 4.20 for now, and have it in linux-next for merging
> into the next merge window, to give us more time to fix up all the
> regressions. This particular instance is fixed by the patch below.


Hmm, I was considering the -Og support for the current MW,
but it might be better to postpone it for 4.21-rc1...



> Other symptoms caused by the change are tons of 'section mismatch'
> warnings for functions that are no longer automatically inlined, and
> sprintf format string overflow warnings when gcc fails to propagate
> an upper bound on an integer argument that is printed into a fixed
> length string.
>
>      Arnd
> ---
> From 8172e650c6797b9cc64c6f7b1c9e5433156290cc Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Wed, 31 Oct 2018 16:24:35 +0100
> Subject: [PATCH] vbox: fix link error with 'gcc -Og'
>
> With the new CONFIG_CC_OPTIMIZE_FOR_DEBUGGING option, we get a link
> error in the vboxguest driver, when that fails to optimize out the
> call to the compat handler:
>
> drivers/virt/vboxguest/vboxguest_core.o: In function `vbg_ioctl_hgcm_call':
> vboxguest_core.c:(.text+0x1f6e): undefined reference to `vbg_hgcm_call32'
>
> Another compile-time check documents better what we want and avoids
> the error.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/virt/vboxguest/vboxguest_core.c
> b/drivers/virt/vboxguest/vboxguest_core.c
> index 3093655c7b92..1475ed5ffcde 100644
> --- a/drivers/virt/vboxguest/vboxguest_core.c
> +++ b/drivers/virt/vboxguest/vboxguest_core.c
> @@ -1312,7 +1312,7 @@ static int vbg_ioctl_hgcm_call(struct vbg_dev *gdev,
>                 return -EINVAL;
>         }
>
> -       if (f32bit)
> +       if (IS_ENABLED(CONFIG_COMPAT) && f32bit)
>                 ret = vbg_hgcm_call32(gdev, client_id,
>                                       call->function, call->timeout_ms,
>                                       VBG_IOCTL_HGCM_CALL_PARMS32(call),

Right, but adding the CONFIG_COMPAT guard to both the caller and the callee
looks a bit redundant...


I think most cases causing this kind of problem
rely on the assumption that 'static' functions are inlined.

We can force the compiler to do so
by replacing 'static' with 'static __always_inline'


-- 
Best Regards
Masahiro Yamada

  parent reply	other threads:[~2018-11-01  3:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31  3:59 linux-next: Tree for Oct 31 Stephen Rothwell
2018-10-31 15:51 ` linux-next: Tree for Oct 31 (vboxguest) Randy Dunlap
2018-10-31 16:50   ` Hans de Goede
2018-10-31 19:06     ` Randy Dunlap
2018-10-31 21:41   ` Arnd Bergmann
2018-10-31 21:45     ` Randy Dunlap
2018-11-01  3:32     ` Masahiro Yamada [this message]
2018-11-01 14:29       ` Changbin Du
2018-11-02  8:25         ` Masahiro Yamada
2018-11-02 15:54           ` Arnd Bergmann
2018-11-02 23:59             ` Changbin Du
2018-11-04  2:43             ` Masahiro Yamada
2018-11-04 23:38               ` Changbin Du
2018-11-05  3:00                 ` Masahiro Yamada
2018-11-02 23:59           ` Changbin Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNATirQwke8tqk5XukhkwKra6mWEXZ3AHcywNcwGFD2-voA@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=arnd@arndb.de \
    --cc=changbin.du@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: linux-next: Tree for Oct 31 (vboxguest)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).