LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Carlos Bilbao <bilbao@vt.edu>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	jianyong.wu@arm.com, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] include: linux: Reorganize timekeeping and ktime headers
Date: Thu, 15 Jul 2021 20:57:55 +0200	[thread overview]
Message-ID: <CAK8P3a0LCZmHjwTjr6bWQ+uuO_3MentMfnHy2M_6iysyN9fP1g@mail.gmail.com> (raw)
In-Reply-To: <4331271.LvFx2qVVIh@iron-maiden>

On Thu, Jul 15, 2021 at 6:12 PM Carlos Bilbao <bilbao@vt.edu> wrote:
>
> Reorganize and separate the headers by making ktime.h take care of the
> ktime_get() family of functions, and reserve timekeeping.h for the actual
> timekeeping. This also helps to avoid implicit function errors and strengthens
> the header dependencies, since timekeeping.h was using ktime_to_ns(), a static
> function defined in a header it does no include, ktime.h. This patch also
> includes the header timekeeping.h wherever it is necessary for a successful
> compilation after the header code reorganization.
>
> Signed-off-by: Carlos Bilbao <bilbao@vt.edu>
> ---
>  arch/x86/kernel/tsc.c       |   1 +
>  include/linux/ktime.h       | 196 +++++++++++++++++++++++++++++++++++-
>  include/linux/sched_clock.h |   2 +
>  include/linux/timekeeping.h | 196 +-----------------------------------
>  init/main.c                 |   1 +
>  kernel/time/ntp.c           |   1 +
>  kernel/time/time.c          |   1 +
>  kernel/time/timekeeping.c   |   1 +
>  8 files changed, 202 insertions(+), 197 deletions(-)

This looks reasonable overall. I'm not sure if Thomas has other plans for this
header, as he created the timekeeping.h one originally. There is also the
potential for build regressions when additional files depend on timekeeping.h
but don't include it directly. Hopefully the kbuild bot will warn us about
any of those.

       Arnd

  reply	other threads:[~2021-07-15 19:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5729424.lOV4Wx5bFT@iron-maiden>
     [not found] ` <2591466.mvXUDI8C0e@iron-maiden>
     [not found]   ` <5481808.DvuYhMxLoT@iron-maiden>
2021-07-15 16:12     ` Carlos Bilbao
2021-07-15 18:57       ` Arnd Bergmann [this message]
2021-07-19 15:16         ` Carlos Bilbao
2021-07-19 15:19           ` [PATCH v2] " Carlos Bilbao
2021-07-21 21:09             ` Thomas Gleixner
2021-07-22 11:54               ` Carlos Bilbao
2021-07-22 15:31                 ` [PATCH v3] " Carlos Bilbao
2021-07-22 18:19                   ` kernel test robot
2021-07-22 18:41                   ` kernel test robot
2021-07-22 19:19                   ` kernel test robot
2021-07-31 16:29                     ` [PATCH v4] " Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a0LCZmHjwTjr6bWQ+uuO_3MentMfnHy2M_6iysyN9fP1g@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=bilbao@vt.edu \
    --cc=geert@linux-m68k.org \
    --cc=jianyong.wu@arm.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH] include: linux: Reorganize timekeeping and ktime headers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).