From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21446C433EF for ; Wed, 13 Oct 2021 10:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F07B160F21 for ; Wed, 13 Oct 2021 10:55:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230265AbhJMK5L (ORCPT ); Wed, 13 Oct 2021 06:57:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:55694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbhJMK5H (ORCPT ); Wed, 13 Oct 2021 06:57:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B3886610D1; Wed, 13 Oct 2021 10:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634122504; bh=cHJwlE/4hKjsg8N9PIPkUgBxfg4CYIeT2a/7mtQ0gV4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gvd6nNUOzZ1UK/F83pyQaR5TauDo53BnYMnJejta47hA700Gc4nEjGIFnHwmjOADo AKNy+aONpGH/0IsqLm0Dcpm6wjEJavnew940SDLuN/5a6FYUw3ELyYcU0A3Q/NRQek QfoThQlCQv7p+iOVnXWOAHkCznwBtAwOy+ujza96o7WAaFxFjrC8XZ1wckA/fZVTbk VwI4mJWJKdlfyh1Lt6ftM0G3FhFyxA8FUoE+m7e14+8RRL2PlJvv9hf7Oz7NJ/FAwC wgr7gidywOLH4DV+TxM46MeGP/by3gM7M3FjX3pF1U7UjvwkkKAPLPGpJwUDxBDIsM sv3E+u1PeyN3A== Received: by mail-wr1-f45.google.com with SMTP id o20so6930614wro.3; Wed, 13 Oct 2021 03:55:04 -0700 (PDT) X-Gm-Message-State: AOAM530iZXvF4GxMweqi4kkfiz7ZUk97vL95SLqNn2ulZn679H1I9FS6 nYyJQLDddw3zeAFg/BNgI5e/wVU24xPXuOhmPUE= X-Google-Smtp-Source: ABdhPJzW6QwF+fpri3xax3BToB6ExyXZ9H+Kw/HXMbby5km4lbFfKsXJq/EA3ZMCLu9RmweZx7YA8FnfMM0PPRf9Pg4= X-Received: by 2002:a05:600c:4f42:: with SMTP id m2mr9273874wmq.82.1634122503094; Wed, 13 Oct 2021 03:55:03 -0700 (PDT) MIME-Version: 1.0 References: <20211006025350.a5PczFZP4%akpm@linux-foundation.org> <58fbf2ff-b367-2137-aa77-fcde6c46bbb7@infradead.org> <20211006182052.6ecc17cf@canb.auug.org.au> In-Reply-To: From: Arnd Bergmann Date: Wed, 13 Oct 2021 12:54:47 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) To: Geert Uytterhoeven Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= , Stephen Rothwell , Randy Dunlap , Andrew Morton , Mark Brown , Linux FS Devel , Linux Kernel Mailing List , Linux MM , Linux-Next , Michal Hocko , mm-commits@vger.kernel.org, Rob Clark , Sean Paul , linux-arm-msm , freedreno , Daniel Vetter , Intel Graphics , DRI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 7, 2021 at 11:51 AM Geert Uytterhoeven w= rote: > On Wed, Oct 6, 2021 at 9:28 AM Christian K=C3=B6nig wrote: > > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap wrote: > > >> on i386: > > >> > > >> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined r= eference to `msm_hdmi_phy_8996_cfg' I ran into the same thing now as well. E_TEST) && COMMON_CLK > > I'd make that: > > - depends on DRM > + depends on COMMON_CLK && DRM && IOMMU_SUPPORT > depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST > - depends on IOMMU_SUPPORT > - depends on (OF && COMMON_CLK) || COMPILE_TEST > + depends on OF || COMPILE_TEST > > to keep a better separation between hard and soft dependencies. > > Note that the "depends on OF || COMPILE_TEST" can even be > deleted, as the dependency on ARCH_QCOM || SOC_IMX5 implies OF. Looks good to me, I would also drop that last line in this case, and maybe add this change as building without COMMON_CLK is no longer possible: diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile index 904535eda0c4..a5d87e03812f 100644 --- a/drivers/gpu/drm/msm/Makefile +++ b/drivers/gpu/drm/msm/Makefile @@ -116,10 +116,10 @@ msm-$(CONFIG_DRM_MSM_DP)+=3D dp/dp_aux.o \ dp/dp_power.o \ dp/dp_audio.o -msm-$(CONFIG_DRM_FBDEV_EMULATION) +=3D msm_fbdev.o -msm-$(CONFIG_COMMON_CLK) +=3D disp/mdp4/mdp4_lvds_pll.o -msm-$(CONFIG_COMMON_CLK) +=3D hdmi/hdmi_pll_8960.o -msm-$(CONFIG_COMMON_CLK) +=3D hdmi/hdmi_phy_8996.o +msm-$(CONFIG_DRM_FBDEV_EMULATION) +=3D msm_fbdev.o \ + disp/mdp4/mdp4_lvds_pll.o \ + hdmi/hdmi_pll_8960.o \ + hdmi/hdmi_phy_8996.o msm-$(CONFIG_DRM_MSM_HDMI_HDCP) +=3D hdmi/hdmi_hdcp.o Has anyone submitted a patch already, or should I send the version that I am using locally now? Arnd