From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC93C4320A for ; Mon, 2 Aug 2021 20:59:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C69A060F93 for ; Mon, 2 Aug 2021 20:59:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232432AbhHBU7t (ORCPT ); Mon, 2 Aug 2021 16:59:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:34728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231194AbhHBU7r (ORCPT ); Mon, 2 Aug 2021 16:59:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D08E6610FE; Mon, 2 Aug 2021 20:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627937977; bh=ME91uzg3uQGioK1v2nnqNunzlz6ItvqqOC1l0uFZutU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kcqiTXREDVH4w9R95j5w4WOfLMxOStmOouND1gl916CZScJNJtCl2GB4/lgbDDdn8 5xkB3lwOkmI/t0GPSl79DjQj1otssX56UVlrFBidXX0eJEU7lwU6lqO+HpUUVo+xwt wZP28qF50h2MzZPUTIjMkv3Sb/lJw411baVC855CoXg5JOnKlfrBcuQRQ8x6ES6xdq zFCzAefIOUF+18rwisc0W6HOai8EG1W8b4IGfxgleFUhILKu8JwqiHgdLSfApZLAYU Lp0niOb4VUP4OS+u1avOiALt5h0fI0ogqg/qGz7k0ir8YhtBk5ozkl2l+0SXqQqnAb ttkQRLrNH58eQ== Received: by mail-wm1-f54.google.com with SMTP id b128so11175416wmb.4; Mon, 02 Aug 2021 13:59:37 -0700 (PDT) X-Gm-Message-State: AOAM531NKwDwu+K9LxegWducEHEamu9J3Omo4MKS/ZEuchieD0ApjeGw uMfWq+16Iv74YJMvJ6s9ZRp/0PZnDsvWQrX8cKw= X-Google-Smtp-Source: ABdhPJy4NlTUHsygtWM7DW5cko6rUy0afbh+TXAP+SRYo4CljudxoDYG2Dg3SfR+K53fmjTEY+MfH6F9UpMtn2dxoOY= X-Received: by 2002:a7b:ce10:: with SMTP id m16mr705834wmc.75.1627937976496; Mon, 02 Aug 2021 13:59:36 -0700 (PDT) MIME-Version: 1.0 References: <20210802145937.1155571-1-arnd@kernel.org> <20210802164907.GA9832@hoboy.vegasvil.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 2 Aug 2021 22:59:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies To: "Keller, Jacob E" Cc: Richard Cochran , Nicolas Pitre , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "David S. Miller" , Jakub Kicinski , Arnd Bergmann , Kurt Kanzenbach , "Saleem, Shiraz" , "Ertman, David M" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 2, 2021 at 10:46 PM Keller, Jacob E wrote: > > You can do something like it for a particular symbol though, such as > > > > config MAY_USE_PTP_1588_CLOCK > > def_tristate PTP_1588_CLOCK || !PTP_1588_CLOCK > > > > config E1000E > > tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support" > > depends on PCI && (!SPARC32 || BROKEN) > > + depends on MAY_USE_PTP_1588_CLOCK > > select CRC32 > > - imply PTP_1588_CLOCK > > What about "integrates"? Maybe, we'd need to look at whether that fits for the other users of the "A || !A" trick. > Or.. what if we just changed "implies" to also include the dependencies > automatically? i.e. "implies PTP_1588_CLOCK" also means the depends > trick which ensures that you can't have it as module if this is built-in. > > I.e. we still get the nice "this will turn on automatically in the menu if you > enable this" and we enforce that you can't have it as a module since it > would be a dependency if it's on"? I don't want to mess with the semantics of the keyword any further. The original meaning was meant to avoid circular dependencies by making it a softer version of 'select' that would not try to select anything that has unmet dependencies. The current version made it even softer by only having an effect during 'make defconfig' and 'make oldconfig' but not preventing it from being soft-disabled any more. Changing it yet again is guarantee to break lots of the existing users, while probably also bringing back the original problem of the circular dependencies. Arnd