From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759003AbbA2WSo (ORCPT ); Thu, 29 Jan 2015 17:18:44 -0500 Received: from mail-ie0-f175.google.com ([209.85.223.175]:64275 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757411AbbA2WSf (ORCPT ); Thu, 29 Jan 2015 17:18:35 -0500 MIME-Version: 1.0 In-Reply-To: <54CA463C.9090804@mev.co.uk> References: <1422484584-9164-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <54CA463C.9090804@mev.co.uk> Date: Thu, 29 Jan 2015 23:18:34 +0100 Message-ID: Subject: Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used From: Rickard Strandqvist To: Ian Abbott Cc: H Hartley Sweeten , Greg Kroah-Hartman , Julia Lawall , Heena Sirwani , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-01-29 15:39 GMT+01:00 Ian Abbott : > On 28/01/15 22:36, Rickard Strandqvist wrote: >> >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist >> >> --- >> drivers/staging/comedi/drivers/mite.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/mite.c >> b/drivers/staging/comedi/drivers/mite.c >> index ffc9e61..8d2903b 100644 >> --- a/drivers/staging/comedi/drivers/mite.c >> +++ b/drivers/staging/comedi/drivers/mite.c >> @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub); >> unsigned mite_dma_tcr(struct mite_channel *mite_chan) >> { >> struct mite_struct *mite = mite_chan->mite; >> - int lkar; >> >> - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel)); >> + readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel)); >> return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel)); >> } >> EXPORT_SYMBOL_GPL(mite_dma_tcr); >> > > Reading the MITE_LKAR(channel) register won't have any side-effects, so that > call to readl() can be removed altogether. In previous versions of the > driver, the value of lkar was only used in debugging messages. > > -- > -=( Ian Abbott @ MEV Ltd. E-mail: )=- > -=( Web: http://www.mev.co.uk/ )=- Hi Ok good, new patch on the way! Kind regards Rickard Strandqvist