LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used
@ 2015-01-28 22:35 Rickard Strandqvist
  2015-01-29 14:26 ` Ian Abbott
  0 siblings, 1 reply; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-28 22:35 UTC (permalink / raw)
  To: Ian Abbott, H Hartley Sweeten
  Cc: Rickard Strandqvist, Greg Kroah-Hartman, Vladimir A. Nazarenko,
	devel, linux-kernel

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/comedi/drivers/jr3_pci.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
index 81fab2d..5d4cca7 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.c
+++ b/drivers/staging/comedi/drivers/jr3_pci.c
@@ -520,10 +520,9 @@ static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
 			result = poll_delay_min_max(20, 100);
 		} else {
 			/* Set full scale */
-			struct six_axis_t min_full_scale;
 			struct six_axis_t max_full_scale;
 
-			min_full_scale = get_min_full_scales(channel);
+			get_min_full_scales(channel);
 			max_full_scale = get_max_full_scales(channel);
 			set_full_scales(channel, max_full_scale);
 
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used
  2015-01-28 22:35 [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used Rickard Strandqvist
@ 2015-01-29 14:26 ` Ian Abbott
  2015-01-29 22:04   ` Rickard Strandqvist
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Abbott @ 2015-01-29 14:26 UTC (permalink / raw)
  To: Rickard Strandqvist, H Hartley Sweeten
  Cc: Greg Kroah-Hartman, Vladimir A. Nazarenko, devel, linux-kernel

On 28/01/15 22:35, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/jr3_pci.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c
> index 81fab2d..5d4cca7 100644
> --- a/drivers/staging/comedi/drivers/jr3_pci.c
> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> @@ -520,10 +520,9 @@ static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
>   			result = poll_delay_min_max(20, 100);
>   		} else {
>   			/* Set full scale */
> -			struct six_axis_t min_full_scale;
>   			struct six_axis_t max_full_scale;
>
> -			min_full_scale = get_min_full_scales(channel);
> +			get_min_full_scales(channel);
>   			max_full_scale = get_max_full_scales(channel);
>   			set_full_scales(channel, max_full_scale);
>
>

Yes, it doesn't appear to be needed.  The driver used to have some 
kernel logs that output the min and max full scale information, but it 
didn't do anything else with min_full_scale.

The call to get_min_full_scales() and the function itself can also be 
removed.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used
  2015-01-29 14:26 ` Ian Abbott
@ 2015-01-29 22:04   ` Rickard Strandqvist
  0 siblings, 0 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-29 22:04 UTC (permalink / raw)
  To: Ian Abbott
  Cc: H Hartley Sweeten, Greg Kroah-Hartman, Vladimir A. Nazarenko,
	devel, Linux Kernel Mailing List

2015-01-29 15:26 GMT+01:00 Ian Abbott <abbotti@mev.co.uk>:
> On 28/01/15 22:35, Rickard Strandqvist wrote:
>>
>> Variable ar assigned a value that is never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se>
>> ---
>>   drivers/staging/comedi/drivers/jr3_pci.c |    3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
>> b/drivers/staging/comedi/drivers/jr3_pci.c
>> index 81fab2d..5d4cca7 100644
>> --- a/drivers/staging/comedi/drivers/jr3_pci.c
>> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
>> @@ -520,10 +520,9 @@ static struct jr3_pci_poll_delay
>> jr3_pci_poll_subdevice(struct comedi_subdevice
>>                         result = poll_delay_min_max(20, 100);
>>                 } else {
>>                         /* Set full scale */
>> -                       struct six_axis_t min_full_scale;
>>                         struct six_axis_t max_full_scale;
>>
>> -                       min_full_scale = get_min_full_scales(channel);
>> +                       get_min_full_scales(channel);
>>                         max_full_scale = get_max_full_scales(channel);
>>                         set_full_scales(channel, max_full_scale);
>>
>>
>
> Yes, it doesn't appear to be needed.  The driver used to have some kernel
> logs that output the min and max full scale information, but it didn't do
> anything else with min_full_scale.
>
> The call to get_min_full_scales() and the function itself can also be
> removed.
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-


Hi

Ok good, new patch on the way!

Kind regards
Rickard Strandqvist

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-29 22:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 22:35 [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used Rickard Strandqvist
2015-01-29 14:26 ` Ian Abbott
2015-01-29 22:04   ` Rickard Strandqvist

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).