LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH V1] elan_i2c: Increment wakeup count if wake source.
@ 2019-05-13 22:06 Ravi Chandra Sadineni
  2019-05-13 23:29 ` Dmitry Torokhov
  0 siblings, 1 reply; 4+ messages in thread
From: Ravi Chandra Sadineni @ 2019-05-13 22:06 UTC (permalink / raw)
  To: dmitry.torokhov, ravisadineni, kt.liao, benjamin.tissoires,
	abhishekbh, tbroch, linux-kernel, linux-input

Notify the PM core that this dev is the wake source. This helps
userspace daemon tracking the wake source to identify the origin of the
wake.

Signed-off-by: Ravi Chandra Sadineni <ravisadineni@chromium.org>
---
 drivers/input/mouse/elan_i2c_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index f9525d6f0bfe..2c0561e20b7f 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -981,6 +981,8 @@ static irqreturn_t elan_isr(int irq, void *dev_id)
 	if (error)
 		goto out;
 
+	pm_wakeup_event(dev, 0);
+
 	switch (report[ETP_REPORT_ID_OFFSET]) {
 	case ETP_REPORT_ID:
 		elan_report_absolute(data, report);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V1] elan_i2c: Increment wakeup count if wake source.
  2019-05-13 22:06 [PATCH V1] elan_i2c: Increment wakeup count if wake source Ravi Chandra Sadineni
@ 2019-05-13 23:29 ` Dmitry Torokhov
  2019-05-15 16:17   ` Ravi Chandra Sadineni
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2019-05-13 23:29 UTC (permalink / raw)
  To: Ravi Chandra Sadineni
  Cc: 廖崇榮,
	Benjamin Tissoires, Abhishek Bhardwaj, Todd Broch, lkml,
	linux-input

Hi Ravi,

On Mon, May 13, 2019 at 3:06 PM Ravi Chandra Sadineni
<ravisadineni@chromium.org> wrote:
>
> Notify the PM core that this dev is the wake source. This helps
> userspace daemon tracking the wake source to identify the origin of the
> wake.

I wonder if we could do that form the i2c core instead of individual drivers?

>
> Signed-off-by: Ravi Chandra Sadineni <ravisadineni@chromium.org>
> ---
>  drivers/input/mouse/elan_i2c_core.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index f9525d6f0bfe..2c0561e20b7f 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -981,6 +981,8 @@ static irqreturn_t elan_isr(int irq, void *dev_id)
>         if (error)
>                 goto out;
>
> +       pm_wakeup_event(dev, 0);
> +
>         switch (report[ETP_REPORT_ID_OFFSET]) {
>         case ETP_REPORT_ID:
>                 elan_report_absolute(data, report);
> --
> 2.20.1
>

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V1] elan_i2c: Increment wakeup count if wake source.
  2019-05-13 23:29 ` Dmitry Torokhov
@ 2019-05-15 16:17   ` Ravi Chandra Sadineni
  2019-05-15 23:15     ` Dmitry Torokhov
  0 siblings, 1 reply; 4+ messages in thread
From: Ravi Chandra Sadineni @ 2019-05-15 16:17 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: 廖崇榮,
	Benjamin Tissoires, Abhishek Bhardwaj, Todd Broch, lkml,
	linux-input

Hi Dmitry,

On Mon, May 13, 2019 at 4:29 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Ravi,
>
> On Mon, May 13, 2019 at 3:06 PM Ravi Chandra Sadineni
> <ravisadineni@chromium.org> wrote:
> >
> > Notify the PM core that this dev is the wake source. This helps
> > userspace daemon tracking the wake source to identify the origin of the
> > wake.
>
> I wonder if we could do that form the i2c core instead of individual drivers?
I am sorry, I don't see a way how this could be done.
>
> >
> > Signed-off-by: Ravi Chandra Sadineni <ravisadineni@chromium.org>
> > ---
> >  drivers/input/mouse/elan_i2c_core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> > index f9525d6f0bfe..2c0561e20b7f 100644
> > --- a/drivers/input/mouse/elan_i2c_core.c
> > +++ b/drivers/input/mouse/elan_i2c_core.c
> > @@ -981,6 +981,8 @@ static irqreturn_t elan_isr(int irq, void *dev_id)
> >         if (error)
> >                 goto out;
> >
> > +       pm_wakeup_event(dev, 0);
> > +
> >         switch (report[ETP_REPORT_ID_OFFSET]) {
> >         case ETP_REPORT_ID:
> >                 elan_report_absolute(data, report);
> > --
> > 2.20.1
> >
>
> Thanks.
>
> --
> Dmitry

Thanks,
Ravi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V1] elan_i2c: Increment wakeup count if wake source.
  2019-05-15 16:17   ` Ravi Chandra Sadineni
@ 2019-05-15 23:15     ` Dmitry Torokhov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2019-05-15 23:15 UTC (permalink / raw)
  To: Ravi Chandra Sadineni
  Cc: 廖崇榮,
	Benjamin Tissoires, Abhishek Bhardwaj, Todd Broch, lkml,
	linux-input

On Wed, May 15, 2019 at 09:17:59AM -0700, Ravi Chandra Sadineni wrote:
> Hi Dmitry,
> 
> On Mon, May 13, 2019 at 4:29 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > Hi Ravi,
> >
> > On Mon, May 13, 2019 at 3:06 PM Ravi Chandra Sadineni
> > <ravisadineni@chromium.org> wrote:
> > >
> > > Notify the PM core that this dev is the wake source. This helps
> > > userspace daemon tracking the wake source to identify the origin of the
> > > wake.
> >
> > I wonder if we could do that form the i2c core instead of individual drivers?
> I am sorry, I don't see a way how this could be done.

Sorry, brain fart on my part. Applied, thank you.

> >
> > >
> > > Signed-off-by: Ravi Chandra Sadineni <ravisadineni@chromium.org>
> > > ---
> > >  drivers/input/mouse/elan_i2c_core.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> > > index f9525d6f0bfe..2c0561e20b7f 100644
> > > --- a/drivers/input/mouse/elan_i2c_core.c
> > > +++ b/drivers/input/mouse/elan_i2c_core.c
> > > @@ -981,6 +981,8 @@ static irqreturn_t elan_isr(int irq, void *dev_id)
> > >         if (error)
> > >                 goto out;
> > >
> > > +       pm_wakeup_event(dev, 0);
> > > +
> > >         switch (report[ETP_REPORT_ID_OFFSET]) {
> > >         case ETP_REPORT_ID:
> > >                 elan_report_absolute(data, report);
> > > --
> > > 2.20.1
> > >
> >
> > Thanks.
> >
> > --
> > Dmitry
> 
> Thanks,
> Ravi

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-15 23:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 22:06 [PATCH V1] elan_i2c: Increment wakeup count if wake source Ravi Chandra Sadineni
2019-05-13 23:29 ` Dmitry Torokhov
2019-05-15 16:17   ` Ravi Chandra Sadineni
2019-05-15 23:15     ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).