From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987A0C04AAF for ; Thu, 16 May 2019 16:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6705020818 for ; Thu, 16 May 2019 16:15:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="YGLG2XRT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbfEPQP2 (ORCPT ); Thu, 16 May 2019 12:15:28 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:43455 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfEPQP2 (ORCPT ); Thu, 16 May 2019 12:15:28 -0400 Received: by mail-lf1-f66.google.com with SMTP id u27so3076966lfg.10 for ; Thu, 16 May 2019 09:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LBNDRhhKywXBp2MSuZfngBTVHWR97SCmvRB6eI8uLbE=; b=YGLG2XRTx2rzAnfC7U7Pt27EAxYtRFVsHIL2F6MDo4Eb18nu45zjdjHrwS1A9kdPGe 7AIr1yDi9FrkAOD910N+/Gftjemk6VQpdwLEb6WWejY5+Cn6CS2NDKVPjnz4IQ92cu0t 0s8PelXOgvWB0aAfwdmg6nSu5jdC5BtNCXpg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LBNDRhhKywXBp2MSuZfngBTVHWR97SCmvRB6eI8uLbE=; b=qj35NGwLwOrp1zQy3eupsxr3au+BBB1oFmVwYnL9HLmG9iTaMNwhIrRwEiALuq/0lh 5gNG3AwWElgHotceS8dnQJJI/SfMxsOm8ml5K9uSrWW5f8Zk4wxMr2irekFhk1SH+6jC pzUt+iAhpfrt/oOcJr3ulk17Z8i99oBqQlGWLOwGc61+kNneSk6Wr0nH4m+yTNEVS+sd 3SHaoPT2qCyKxB2NneqkhHxi9xL23O8uzx0L6tGdjQ3EU5A7nnlC5P4PCHBUT1Ty2C6D Oqb+fOIpIZ/mj8G7wSBqIs2xhZK4S73QeJ+MPe/UBj5ZZD2N3qvWuFQyWMewXOMGdleW vlVA== X-Gm-Message-State: APjAAAWcL5EiAz6pp3zLTm9F8gM+Kyo/GauhWyIcRehL/0ZCmbiSUNYh zAIE14m/o5E5KirHEdoS2GqUpZK9cjOcZZXpcIpuNOW9 X-Google-Smtp-Source: APXvYqzDx21IaIaK95EwYZHZnuKZ60WB8qRKmhPS4eJD5UoIunNxJ5iVpBl+vhmkGydAw0xGLL0IfTX7yIdjwsn9BZs= X-Received: by 2002:a19:2791:: with SMTP id n139mr16901324lfn.67.1558023326364; Thu, 16 May 2019 09:15:26 -0700 (PDT) MIME-Version: 1.0 References: <1558022399-24863-1-git-send-email-kdasu.kdev@gmail.com> <1558022399-24863-2-git-send-email-kdasu.kdev@gmail.com> In-Reply-To: <1558022399-24863-2-git-send-email-kdasu.kdev@gmail.com> From: Kamal Dasu Date: Thu, 16 May 2019 12:14:49 -0400 Message-ID: Subject: Re: [PATCH v2 2/2] mtd: nand: raw: brcmnand: When oops in progress use pio and interrupt polling To: Kamal Dasu Cc: MTD Maling List , bcm-kernel-feedback-list@broadcom.com, open list , Brian Norris , Miquel Raynal , Richard Weinberger , David Woodhouse , Marek Vasut , Vignesh Raghavendra Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please ignore v2 patch 1/2 and 2/2. The commit ordering is not right. v3 patch on the way Kamal On Thu, May 16, 2019 at 12:01 PM Kamal Dasu wrote: > > If mtd_oops is in progress switch to polling for nand command completion > interrupts and use PIO mode wihtout DMA so that the mtd_oops buffer can > be completely written in the assinged nand partition. > > Signed-off-by: Kamal Dasu > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index a30a7f0..dca8eb8 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -835,7 +835,6 @@ static inline void disable_ctrl_irqs(struct brcmnand_controller *ctrl) > } > > disable_irq(ctrl->irq); > - > ctrl->pio_poll_mode = true; > } > > -- > 1.9.0.138.g2de3478 >