LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] vboxguest: check for private_data before trying to close it.
@ 2019-05-28 12:47 Young Xiao
  2019-05-28 13:19 ` Hans de Goede
  0 siblings, 1 reply; 4+ messages in thread
From: Young Xiao @ 2019-05-28 12:47 UTC (permalink / raw)
  To: hdegoede, arnd, gregkh, linux-kernel; +Cc: Young Xiao

vbg_misc_device_close doesn't check that filp->private_data is non-NULL
before trying to close_session, where vbg_core_close_session uses pointer
session whithout checking, too. That can cause an oops in certain error
conditions that can occur on open or lookup before the private_data is set.

This vulnerability is similar to CVE-2011-1771.

Signed-off-by: Young Xiao <92siuyang@gmail.com>
---
 drivers/virt/vboxguest/vboxguest_linux.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
index 6e8c0f1..b03c16f 100644
--- a/drivers/virt/vboxguest/vboxguest_linux.c
+++ b/drivers/virt/vboxguest/vboxguest_linux.c
@@ -88,8 +88,10 @@ static int vbg_misc_device_user_open(struct inode *inode, struct file *filp)
  */
 static int vbg_misc_device_close(struct inode *inode, struct file *filp)
 {
-	vbg_core_close_session(filp->private_data);
-	filp->private_data = NULL;
+	if (file->private_data != NULL) {
+		vbg_core_close_session(filp->private_data);
+		filp->private_data = NULL;
+	}
 	return 0;
 }
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-28 14:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 12:47 [PATCH] vboxguest: check for private_data before trying to close it Young Xiao
2019-05-28 13:19 ` Hans de Goede
2019-05-28 14:49   ` Yang Xiao
2019-05-28 14:51     ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).