LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
@ 2021-07-06 11:41 Alistair Francis
  2021-07-06 11:41 ` [PATCH 2/2] regulator: sy7636a: Use the parent driver data Alistair Francis
  2021-07-29 11:20 ` [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
  0 siblings, 2 replies; 5+ messages in thread
From: Alistair Francis @ 2021-07-06 11:41 UTC (permalink / raw)
  To: lgirdwood, broonie; +Cc: linux-kernel, alistair23, Alistair Francis

From testing on hardware the poll_enable_time isn't required and
sometimes causes the driver probe to fail so let's remove it.

Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
 drivers/regulator/sy7636a-regulator.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
index e021ae08cbaa..c3b34cac8c7f 100644
--- a/drivers/regulator/sy7636a-regulator.c
+++ b/drivers/regulator/sy7636a-regulator.c
@@ -13,8 +13,6 @@
 #include <linux/gpio/consumer.h>
 #include <linux/mfd/sy7636a.h>
 
-#define SY7636A_POLL_ENABLED_TIME 500
-
 static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
 {
 	int ret;
@@ -61,7 +59,6 @@ static const struct regulator_desc desc = {
 	.owner = THIS_MODULE,
 	.enable_reg = SY7636A_REG_OPERATION_MODE_CRL,
 	.enable_mask = SY7636A_OPERATION_MODE_CRL_ONOFF,
-	.poll_enabled_time = SY7636A_POLL_ENABLED_TIME,
 	.regulators_node = of_match_ptr("regulators"),
 	.of_match = of_match_ptr("vcom"),
 };
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] regulator: sy7636a: Use the parent driver data
  2021-07-06 11:41 [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
@ 2021-07-06 11:41 ` Alistair Francis
  2021-07-29 11:20 ` [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
  1 sibling, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2021-07-06 11:41 UTC (permalink / raw)
  To: lgirdwood, broonie; +Cc: linux-kernel, alistair23, Alistair Francis

Use the parent's MFD data instead of our data.

Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
 drivers/regulator/sy7636a-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
index c3b34cac8c7f..ddd7f8e435ea 100644
--- a/drivers/regulator/sy7636a-regulator.c
+++ b/drivers/regulator/sy7636a-regulator.c
@@ -33,7 +33,7 @@ static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
 
 static int sy7636a_get_status(struct regulator_dev *rdev)
 {
-	struct sy7636a *sy7636a = rdev_get_drvdata(rdev);
+	struct sy7636a *sy7636a = dev_get_drvdata(rdev->dev.parent);
 	int ret = 0;
 
 	ret = gpiod_get_value_cansleep(sy7636a->pgood_gpio);
-- 
2.31.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
  2021-07-06 11:41 [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
  2021-07-06 11:41 ` [PATCH 2/2] regulator: sy7636a: Use the parent driver data Alistair Francis
@ 2021-07-29 11:20 ` Alistair Francis
  2021-07-29 11:22   ` Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: Alistair Francis @ 2021-07-29 11:20 UTC (permalink / raw)
  To: Alistair Francis; +Cc: lgirdwood, Mark Brown, Linux Kernel Mailing List

On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@alistair23.me> wrote:
>
> From testing on hardware the poll_enable_time isn't required and
> sometimes causes the driver probe to fail so let's remove it.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>

Ping

AlistaIr

> ---
>  drivers/regulator/sy7636a-regulator.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index e021ae08cbaa..c3b34cac8c7f 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -13,8 +13,6 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/mfd/sy7636a.h>
>
> -#define SY7636A_POLL_ENABLED_TIME 500
> -
>  static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
>  {
>         int ret;
> @@ -61,7 +59,6 @@ static const struct regulator_desc desc = {
>         .owner = THIS_MODULE,
>         .enable_reg = SY7636A_REG_OPERATION_MODE_CRL,
>         .enable_mask = SY7636A_OPERATION_MODE_CRL_ONOFF,
> -       .poll_enabled_time = SY7636A_POLL_ENABLED_TIME,
>         .regulators_node = of_match_ptr("regulators"),
>         .of_match = of_match_ptr("vcom"),
>  };
> --
> 2.31.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
  2021-07-29 11:20 ` [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
@ 2021-07-29 11:22   ` Mark Brown
  2021-07-30  6:11     ` Alistair Francis
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2021-07-29 11:22 UTC (permalink / raw)
  To: Alistair Francis; +Cc: Alistair Francis, lgirdwood, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Thu, Jul 29, 2021 at 09:20:14PM +1000, Alistair Francis wrote:
> On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@alistair23.me> wrote:
> >
> > From testing on hardware the poll_enable_time isn't required and
> > sometimes causes the driver probe to fail so let's remove it.
> >
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> 
> Ping

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
  2021-07-29 11:22   ` Mark Brown
@ 2021-07-30  6:11     ` Alistair Francis
  0 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2021-07-30  6:11 UTC (permalink / raw)
  To: Mark Brown; +Cc: Alistair Francis, lgirdwood, Linux Kernel Mailing List

On Thu, Jul 29, 2021 at 9:22 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Jul 29, 2021 at 09:20:14PM +1000, Alistair Francis wrote:
> > On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@alistair23.me> wrote:
> > >
> > > From testing on hardware the poll_enable_time isn't required and
> > > sometimes causes the driver probe to fail so let's remove it.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> >
> > Ping
>
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.

Sorry, I was following what happens with some other projects and
pinging after a few weeks.

>
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.

Ok, in future I'll try to follow what others in the subsystem do.

Alistair

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-30  6:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 11:41 [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
2021-07-06 11:41 ` [PATCH 2/2] regulator: sy7636a: Use the parent driver data Alistair Francis
2021-07-29 11:20 ` [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time Alistair Francis
2021-07-29 11:22   ` Mark Brown
2021-07-30  6:11     ` Alistair Francis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).