LKML Archive on
help / color / mirror / Atom feed
From: Viresh Kumar <>
To: "Rafael J. Wysocki" <>
Cc: Thomas Gleixner <>,
	Linaro Kernel Mailman List <>,
	Linux Kernel Mailing List <>,
	Kevin Hilman <>,
	Frederic Weisbecker <>,
	Preeti U Murthy <>,
	Daniel Lezcano <>,
	Linaro Networking <>,
	Peter Zijlstra <>
Subject: Re: [PATCH v2] clockevents: Introduce mode specific callbacks
Date: Fri, 13 Feb 2015 11:01:18 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1911031.mQ9ZbsnC1C@vostro.rjw.lan>

On 13 February 2015 at 10:11, Rafael J. Wysocki <> wrote:
> On Friday, February 13, 2015 08:54:56 AM Viresh Kumar wrote:
>> It is not possible for the clockevents core to know which modes (other than
>> those with a corresponding feature flag) are supported by a particular
>> implementation. And drivers are expected to handle transition to all modes
>> elegantly, as ->set_mode() would be issued for them unconditionally.
>> Now, adding support for a new mode complicates things a bit if we want to use
>> the legacy ->set_mode() callback. We need to closely review all clockevents
>> drivers to see if they would break on addition of a new mode. And after such
>> reviews, it is found that we have to do non-trivial changes to most of the
>> drivers [1].
>> Introduce mode-specific set_mode_*() callbacks, some of which the drivers may or
>> may not implement. A missing callback would clearly convey the message that the
>> corresponding mode isn't supported.
> This is not going to fly AFAICS if you don't say what exacly you need it for.

For this:

  reply	other threads:[~2015-02-13  3:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13  0:54 Viresh Kumar
2015-02-13  2:11 ` Rafael J. Wysocki
2015-02-13  3:01   ` Viresh Kumar [this message]
2015-02-13 14:46     ` Rafael J. Wysocki
2015-02-13  3:42 ` Preeti U Murthy
2015-02-18 17:09 ` [tip:timers/core] " tip-bot for Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] clockevents: Introduce mode specific callbacks' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).