LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] selftests: Use -fno-integrated-as instead of -no-integrated-as
@ 2021-08-16 21:04 Nathan Chancellor
  2021-08-16 21:08 ` Nick Desaulniers
  0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2021-08-16 21:04 UTC (permalink / raw)
  To: Shuah Khan
  Cc: Mathieu Desnoyers, Peter Zijlstra, Paul E. McKenney, Boqun Feng,
	Nick Desaulniers, linux-kernel, linux-kselftest,
	clang-built-linux, Nathan Chancellor

-no-integrated-as is considered the legacy flag since clang 3.5 so move
-fno-integrated-as in case clang ever decides to remove the legacy flag.

Link: https://releases.llvm.org/3.5.0/tools/clang/docs/ReleaseNotes.html#new-compiler-flags
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 tools/testing/selftests/rseq/Makefile  | 2 +-
 tools/testing/selftests/sched/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/rseq/Makefile b/tools/testing/selftests/rseq/Makefile
index 2af9d39a9716..32f503c13c61 100644
--- a/tools/testing/selftests/rseq/Makefile
+++ b/tools/testing/selftests/rseq/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0+ OR MIT
 
 ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
-CLANG_FLAGS += -no-integrated-as
+CLANG_FLAGS += -fno-integrated-as
 endif
 
 CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L$(OUTPUT) -Wl,-rpath=./ \
diff --git a/tools/testing/selftests/sched/Makefile b/tools/testing/selftests/sched/Makefile
index 10c72f14fea9..d84a19363a62 100644
--- a/tools/testing/selftests/sched/Makefile
+++ b/tools/testing/selftests/sched/Makefile
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0+
 
 ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
-CLANG_FLAGS += -no-integrated-as
+CLANG_FLAGS += -fno-integrated-as
 endif
 
 CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/  -Wl,-rpath=./ \

base-commit: 7c60610d476766e128cc4284bb6349732cbd6606
-- 
2.33.0.rc2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests: Use -fno-integrated-as instead of -no-integrated-as
  2021-08-16 21:04 [PATCH] selftests: Use -fno-integrated-as instead of -no-integrated-as Nathan Chancellor
@ 2021-08-16 21:08 ` Nick Desaulniers
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Desaulniers @ 2021-08-16 21:08 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Shuah Khan, Mathieu Desnoyers, Peter Zijlstra, Paul E. McKenney,
	Boqun Feng, linux-kernel, linux-kselftest, clang-built-linux

On Mon, Aug 16, 2021 at 2:05 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> -no-integrated-as is considered the legacy flag since clang 3.5 so move
> -fno-integrated-as in case clang ever decides to remove the legacy flag.
>
> Link: https://releases.llvm.org/3.5.0/tools/clang/docs/ReleaseNotes.html#new-compiler-flags
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>  tools/testing/selftests/rseq/Makefile  | 2 +-
>  tools/testing/selftests/sched/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/rseq/Makefile b/tools/testing/selftests/rseq/Makefile
> index 2af9d39a9716..32f503c13c61 100644
> --- a/tools/testing/selftests/rseq/Makefile
> +++ b/tools/testing/selftests/rseq/Makefile
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0+ OR MIT
>
>  ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
> -CLANG_FLAGS += -no-integrated-as
> +CLANG_FLAGS += -fno-integrated-as
>  endif
>
>  CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/ -L$(OUTPUT) -Wl,-rpath=./ \
> diff --git a/tools/testing/selftests/sched/Makefile b/tools/testing/selftests/sched/Makefile
> index 10c72f14fea9..d84a19363a62 100644
> --- a/tools/testing/selftests/sched/Makefile
> +++ b/tools/testing/selftests/sched/Makefile
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0+
>
>  ifneq ($(shell $(CC) --version 2>&1 | head -n 1 | grep clang),)
> -CLANG_FLAGS += -no-integrated-as
> +CLANG_FLAGS += -fno-integrated-as
>  endif
>
>  CFLAGS += -O2 -Wall -g -I./ -I../../../../usr/include/  -Wl,-rpath=./ \
>
> base-commit: 7c60610d476766e128cc4284bb6349732cbd6606
> --
> 2.33.0.rc2
>


-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-16 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 21:04 [PATCH] selftests: Use -fno-integrated-as instead of -no-integrated-as Nathan Chancellor
2021-08-16 21:08 ` Nick Desaulniers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).