From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E14C433EF for ; Tue, 8 Feb 2022 22:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232099AbiBHW7a (ORCPT ); Tue, 8 Feb 2022 17:59:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231624AbiBHW71 (ORCPT ); Tue, 8 Feb 2022 17:59:27 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BEF7C061576 for ; Tue, 8 Feb 2022 14:59:25 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id m18so826827lfq.4 for ; Tue, 08 Feb 2022 14:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ItA6TI8Ni0PvSK9MRYCU3UPCNW2YkPVfVW+7WyXcgIY=; b=afjxbKw+HzBUlQ3VvuygQbzk9tugRPl9+vCKl+hHOnudj3FtAdcYJm+J0obNuEvQkF mMdDm1UwYtIBcQYD+5S69w2LC/oAIIi/zEFuRkTuJXaT25X71WtPXS4N9QxghiI29Zw6 K2PCvrwgk7c+ntSYrQLtBLuKdljo30Ej3qX5OIQqDw9temAZsjNWDUrOXXTu/gYTG+0B 4IHqkeQKU0bmSqngH3QnAumzP+5C6EPz0BRZ1WQ8bNcJX8DsOqVPh+foqEjAMVhADIvv fJaCY0xTm3hvMswNVpOcc3EIMuqy51gbtJE7qUz4sn7uTHYRZmCOEQWmQZNFkthU435E H9jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ItA6TI8Ni0PvSK9MRYCU3UPCNW2YkPVfVW+7WyXcgIY=; b=cJUToYhzLWaDY/k8diAzBwUfwnun9MKEF2otGIMy6A/jNRPfoBnx9xg5H2D+DEQnZH c+AXuX5njIgIOUSGs9PVBzkBMD8TM/GkiTjWj1z38hX0Pqy/jJQj6JIEyD+HlKCBaMrl mzXaOWPoi+fzTDuYfgkFqoamvObcYrCT7VR4btXtpc8D259EMDatKhuvUqNzb/T1tEHR oken1ga89YQpcN7RuTdWkBqlHft4pM+fYvQ5/TxAyPatTWbfvLBlOl5QG9+/DvAZwiV1 ilP6rsPrRYc5Q6UI+7r4QL9Ikly4xOJHWF64y3hlLKdNBXDXqEGfSfzvWi9UALcy7L6M 8rQA== X-Gm-Message-State: AOAM531X0YROoZ3I8m/PNP5WPKVe3QqW8vavwE75DrMUVb70csmHupNt 64vhNOl82tEQaDECLtDgYUKTUNTnf92l/tZ+A0vnGg== X-Google-Smtp-Source: ABdhPJzrXjvmHbg4P8xDaIMkX3/azpSsByQPI0FL0T+S/upQWiXIjKfa7421S1XvVu6Ron9ZMXcooOEZEXBDJE9GEbk= X-Received: by 2002:ac2:43db:: with SMTP id u27mr1290745lfl.651.1644361163719; Tue, 08 Feb 2022 14:59:23 -0800 (PST) MIME-Version: 1.0 References: <20220208225350.1331628-1-keescook@chromium.org> <20220208225350.1331628-2-keescook@chromium.org> In-Reply-To: <20220208225350.1331628-2-keescook@chromium.org> From: Nick Desaulniers Date: Tue, 8 Feb 2022 14:59:11 -0800 Message-ID: Subject: Re: [PATCH v7 1/8] fortify: Replace open-coded __gnu_inline attribute To: Kees Cook Cc: Miguel Ojeda , Nathan Chancellor , George Burgess IV , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 8, 2022 at 2:53 PM Kees Cook wrote: > > Replace open-coded gnu_inline attribute with the normal kernel > convention for attributes: __gnu_inline Reviewed-by: Nick Desaulniers > > Signed-off-by: Kees Cook > --- > include/linux/fortify-string.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h > index 53123712bb3b..439aad24ab3b 100644 > --- a/include/linux/fortify-string.h > +++ b/include/linux/fortify-string.h > @@ -2,7 +2,7 @@ > #ifndef _LINUX_FORTIFY_STRING_H_ > #define _LINUX_FORTIFY_STRING_H_ > > -#define __FORTIFY_INLINE extern __always_inline __attribute__((gnu_inline)) > +#define __FORTIFY_INLINE extern __always_inline __gnu_inline > #define __RENAME(x) __asm__(#x) > > void fortify_panic(const char *name) __noreturn __cold; > -- > 2.30.2 > > -- Thanks, ~Nick Desaulniers